[v1] net/tap: minor fixes to interaction with the bridge helper

[PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper

Daniel P. Berrangé posted 2 patches 2 years, 11 months ago

Diff against v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210505121236.532755-1-berrange@redhat.com

There is a newer version of this series

net/tap.c | 34 +++++++++++++++++++++++-----------
1 file changed, 23 insertions(+), 11 deletions(-)

Expand all Fold all

[PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper

Posted by Daniel P. Berrangé 2 years, 11 months ago

QEMU fails to report a good error message if the bridge helper exits
with success code, but forgets to pass back an FD.

There is also a minor portability problem impacting FreeBSD/NetBSD
dealing with cmsg initialization.

Daniel P. Berrangé (2):
  net/tap: fix FreeBSD portability problem receiving TAP FD
  net/tap: fix error reporting when bridge helper forgets to send an FD

 net/tap.c | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)

-- 
2.31.1

Re: [PATCH 0/2] net/tap: minor fixes to interaction with the bridge helper

Posted by Connor Kuehl 2 years, 11 months ago

On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> QEMU fails to report a good error message if the bridge helper exits
> with success code, but forgets to pass back an FD.
> 
> There is also a minor portability problem impacting FreeBSD/NetBSD
> dealing with cmsg initialization.
> 
> Daniel P. Berrangé (2):
>   net/tap: fix FreeBSD portability problem receiving TAP FD
>   net/tap: fix error reporting when bridge helper forgets to send an FD
> 
>  net/tap.c | 34 +++++++++++++++++++++++-----------
>  1 file changed, 23 insertions(+), 11 deletions(-)
> 

Just a minor question on patch 2.

Otherwise, for the series:

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>