From nobody Mon May 6 04:43:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620217057; cv=none; d=zohomail.com; s=zohoarc; b=EsNVyo2oL/mi5ijNjqUcT+pqpqkdP5rbGTyiQvdta6Aw1UNYc3JuNxH8uxI+44oCT/mCa06YelzN/1G3O6ltUiGQ02okemyebkMWqBQHKkBhCoqNdwfOiCIqMy+i7mOvUhZxcXgG4g2P7vrBP+Cqm2di+oaU0+jaZ3Zb2VCyRHE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620217057; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4GXqylJnNq57AGchGlafIrxhk2gns7BoOXwNDgEbIeI=; b=nPti7fFm1x25ebFfVjTNtgjvJpr7/SKAoVDaDqun7RtB0ILiTuGhnY7vC2AtedVKzrX+9ms8oeKi3e7qVMTpzlBnEg+YhMG+mhZDS7wDhfXUjTOjEgUdqL03S64kDQBn6wRb9V3C/568f6Z5hrFvSmkOrQVtbGTJFADiwawB1Ok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620217057988775.5821402782125; Wed, 5 May 2021 05:17:37 -0700 (PDT) Received: from localhost ([::1]:40656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leGTA-0007G0-Rk for importer@patchew.org; Wed, 05 May 2021 08:17:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leGOW-0004lH-Mi for qemu-devel@nongnu.org; Wed, 05 May 2021 08:12:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leGOT-0003es-N4 for qemu-devel@nongnu.org; Wed, 05 May 2021 08:12:48 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-559-yJGM_paxNKGO007JtB9hWA-1; Wed, 05 May 2021 08:12:40 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BAB651009628 for ; Wed, 5 May 2021 12:12:39 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6F926062C; Wed, 5 May 2021 12:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620216765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4GXqylJnNq57AGchGlafIrxhk2gns7BoOXwNDgEbIeI=; b=IV5bRqVy9HxwE47eAY8p5+Ej3oiH2IlBEp43M2Ne1zn5ZS4T+a8y5PQg7QIZP7xPg7w2L0 Pl4nXkt58nwUvoYh1b+e1OYxqhF4pGt2ICGLhCi0VPo+MMAmbBJZ5a1szDYM9Exmcwc3Ra CzthHQLj/h+P1NGYZ+oiyF7GnxvUUG4= X-MC-Unique: yJGM_paxNKGO007JtB9hWA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/2] net/tap: fix FreeBSD portability problem receiving TAP FD Date: Wed, 5 May 2021 13:12:35 +0100 Message-Id: <20210505121236.532755-2-berrange@redhat.com> In-Reply-To: <20210505121236.532755-1-berrange@redhat.com> References: <20210505121236.532755-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.693, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) The CMSG_LEN and CMSG_SPACE macros must not be assumed to return the same value. The msg_controllen field must be initialized using CMSG_SPACE when using SCM_RIGHTS. This ought to fix any FD receive issues users might be hitting on 64-bit FeeBSD / NetBSD platforms. The flaw was noticed first in GNULIB https://lists.gnu.org/archive/html/bug-gnulib/2021-02/msg00066.html and QEMU's code has the same logic bug. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Connor Kuehl --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index bae895e287..276a9077fc 100644 --- a/net/tap.c +++ b/net/tap.c @@ -467,7 +467,7 @@ static int recv_fd(int c) cmsg->cmsg_level =3D SOL_SOCKET; cmsg->cmsg_type =3D SCM_RIGHTS; cmsg->cmsg_len =3D CMSG_LEN(sizeof(fd)); - msg.msg_controllen =3D cmsg->cmsg_len; + msg.msg_controllen =3D CMSG_SPACE(sizeof(fd)); =20 iov.iov_base =3D req; iov.iov_len =3D sizeof(req); --=20 2.31.1 From nobody Mon May 6 04:43:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620217230; cv=none; d=zohomail.com; s=zohoarc; b=WGe7fHVlG2T9La2n6tGpdL4k8c4fprzJZjd2ad+MZxSR97jwxVja5W5PlVGLed1ewRYqGt0iVdQAAS8WWSed1OEsSZz2NHYiY7aArQFAdFD95V+Shbyfn+ediAcmbeT+PBj/V1r5Cjj15lo4iZzcUNA/eC3tVYMu6Ozm0HaYG8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620217230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GoWRAWw0AEhd8kSh1vKY8L/LJxyFsorXbJJD45+U+IE=; b=AjnAOz8LQpcVlpdz4C6/5c7n6OVrEnHxfs8pM2HGS2ZyZfVqxrYCJwIAyxUEUXx7zCn1AwZ3LF45zphNF2Hq1L3yMrlplUzoPrtjB+eSPi9liCGU8+df1BZqcllIynUJSFWS9usSEUI9jA32ogq85yGJPmEiOCPoKg9laELVpcI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620217230915130.47556936734054; Wed, 5 May 2021 05:20:30 -0700 (PDT) Received: from localhost ([::1]:44926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leGVx-0000b6-Ip for importer@patchew.org; Wed, 05 May 2021 08:20:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leGOY-0004n2-5s for qemu-devel@nongnu.org; Wed, 05 May 2021 08:12:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39513) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leGOT-0003eq-Kz for qemu-devel@nongnu.org; Wed, 05 May 2021 08:12:49 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-107-hGW_VI7-OwiH9Wynn7BRbA-1; Wed, 05 May 2021 08:12:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33E17108BC56 for ; Wed, 5 May 2021 12:12:41 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-253.ams2.redhat.com [10.36.114.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18669620DE; Wed, 5 May 2021 12:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620216764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoWRAWw0AEhd8kSh1vKY8L/LJxyFsorXbJJD45+U+IE=; b=VYYTfZ73qAZVoNkSVxKONyCfcuzFcmPq4EgUAuQoG2scTvKKJulHEbGJL/VeRQSz/Fj+mB iPdzUQ4GROMYK9djD3EO9vu6WIZg4FrhPgI2pdxNsp3SnZFciLYlpslDXM8oRzWBzk0pSI +7R05GonQ4EfPmRrXbqTgGXfRKrCwy4= X-MC-Unique: hGW_VI7-OwiH9Wynn7BRbA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/2] net/tap: fix error reporting when bridge helper forgets to send an FD Date: Wed, 5 May 2021 13:12:36 +0100 Message-Id: <20210505121236.532755-3-berrange@redhat.com> In-Reply-To: <20210505121236.532755-1-berrange@redhat.com> References: <20210505121236.532755-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.693, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) The recv_fd() method returns -1 on error, 0 on end of file, or an FD number on success. Technically 0 is also a valid FD number, so the return value is ambiguous. The caller doesn't even consider the possibility of 0 meaning end of file, so just blindly assume it is a valid FD. IOW if the bridge helper exits with 0 status code and forgets to send an FD, QEMU will accidentally try to use STDIN as a TAP FD. Fortunately we get an error shortly thereafter $ qemu-system-x86_64 -netdev bridge,br=3Dbr99,helper=3D/bin/true,id=3Dns0 qemu-system-x86_64: -netdev bridge,br=3Dbr99,helper=3D/bin/true,id=3Dns0: Unable to query TUNGETIFF on FD 0: Inappropriate ioctl for device It is better if we correctly diagnose this broken bridge helper though. To do this we need to return the FD in an output parameter to remove the ambiguity and then fix the caller to check for the end of file condition. With this done we now get $ qemu-system-x86_64 -netdev bridge,br=3Dbr99,helper=3D/bin/true,id=3Dns0 qemu-system-x86_64: -netdev bridge,br=3Dbr99,helper=3D/bin/true,id=3Dns0: bridge helper did not send a file descriptor Fixes: https://gitlab.com/qemu-project/qemu/-/issues/166 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Connor Kuehl Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/tap.c | 32 ++++++++++++++++++++++---------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/net/tap.c b/net/tap.c index 276a9077fc..02046c9fd2 100644 --- a/net/tap.c +++ b/net/tap.c @@ -450,9 +450,11 @@ static void launch_script(const char *setup_script, co= nst char *ifname, } } =20 -static int recv_fd(int c) +/* + * Returns: -1 on error, 0 on end of file, 1 if an FD was received + */ +static int recv_fd(int c, int *fd) { - int fd; uint8_t msgbuf[CMSG_SPACE(sizeof(fd))]; struct msghdr msg =3D { .msg_control =3D msgbuf, @@ -476,12 +478,12 @@ static int recv_fd(int c) msg.msg_iovlen =3D 1; =20 len =3D recvmsg(c, &msg, 0); - if (len > 0) { - memcpy(&fd, CMSG_DATA(cmsg), sizeof(fd)); - return fd; + if (len <=3D 0) { + return len; } =20 - return len; + memcpy(fd, CMSG_DATA(cmsg), sizeof(*fd)); + return 1; } =20 static int net_bridge_run_helper(const char *helper, const char *bridge, @@ -564,14 +566,15 @@ static int net_bridge_run_helper(const char *helper, = const char *bridge, _exit(1); =20 } else { - int fd; + int ret; + int fd =3D -1; int saved_errno; =20 close(sv[1]); =20 do { - fd =3D recv_fd(sv[0]); - } while (fd =3D=3D -1 && errno =3D=3D EINTR); + ret =3D recv_fd(sv[0], &fd); + } while (ret =3D=3D -1 && errno =3D=3D EINTR); saved_errno =3D errno; =20 close(sv[0]); @@ -580,7 +583,7 @@ static int net_bridge_run_helper(const char *helper, co= nst char *bridge, /* loop */ } sigprocmask(SIG_SETMASK, &oldmask, NULL); - if (fd < 0) { + if (ret < 0) { error_setg_errno(errp, saved_errno, "failed to recv file descriptor"); return -1; @@ -589,6 +592,15 @@ static int net_bridge_run_helper(const char *helper, c= onst char *bridge, error_setg(errp, "bridge helper failed"); return -1; } + + /* + * ret =3D=3D 0 means EOF, and if status =3D=3D 0 then helper + * exited cleanly but forgot to send us an FD. Opps... + */ + if (ret =3D=3D 0) { + error_setg(errp, "bridge helper did not send a file descriptor= "); + return -1; + } return fd; } } --=20 2.31.1