On 28/04/2021 15:16, Philippe Mathieu-Daudé wrote:
> Missing review: 2-4
>
> Since v1:
> - move cpu_check_irqs() to target/sparc/ (rth)
>
> This series fixes link failure when building either the leon3
> machine or the sun4m ones.
>
> The problem is we have hardware specific code in the architectural
> translation code. Move this code to hw/sparc/.
>
> The link failures can be reproduced doing:
>
> $ echo CONFIG_LEON3=y > default-configs/devices/sparc-softmmu.mak
> $ configure --without-default-devices
> $ ninja qemu-system-sparc
> $ ./qemu-system-sparc -M leon3 -S
>
> or:
>
> $ echo CONFIG_SUN4M=y > default-configs/devices/sparc-softmmu.mak
>
> Philippe Mathieu-Daudé (4):
> hw/sparc: Allow building without the leon3 machine
> hw/sparc64: Remove unused "hw/char/serial.h" header
> hw/sparc64: Fix code style for checkpatch.pl
> hw/sparc*: Move cpu_check_irqs() to target/sparc/
>
> target/sparc/cpu.h | 6 ----
> hw/sparc/leon3.c | 37 +++++++++++++++++++-
> hw/sparc/sun4m.c | 32 -----------------
> hw/sparc64/sparc64.c | 63 ---------------------------------
> target/sparc/int32_helper.c | 70 +++++++++++++++++--------------------
> target/sparc/int64_helper.c | 66 ++++++++++++++++++++++++++++++++++
> hw/sparc/trace-events | 4 +--
> hw/sparc64/trace-events | 4 ---
> target/sparc/trace-events | 12 ++++---
> 9 files changed, 145 insertions(+), 149 deletions(-)
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.