The first two patches allow access.flat to pass with TCG and "-cpu
max,phys-bits=52", and the last one fixes most NPT tests in svm.flat.

I found these while trying to unify the NPT and regular page table
walk, but those other patches are not appropriate for soft freeze.

Paolo

Paolo Bonzini (3):
  target/i386: allow modifying TCG phys-addr-bits
  target/i386: fail if toggling LA57 in 64-bit mode
  target/i386: svm: do not discard high 32 bits of EXITINFO1

 target/i386/cpu.c             | 23 ++++++++---------------
 target/i386/cpu.h             |  1 -
 target/i386/tcg/excp_helper.c |  7 ++++---
 target/i386/tcg/helper-tcg.h  | 14 +++++---------
 target/i386/tcg/misc_helper.c |  4 ++++
 target/i386/tcg/seg_helper.c  |  4 ++--
 target/i386/tcg/svm_helper.c  | 15 +++++++--------
 7 files changed, 30 insertions(+), 38 deletions(-)

-- 
2.26.2

Patchew URL: https://patchew.org/QEMU/20210318150022.1824646-1-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210318150022.1824646-1-pbonzini@redhat.com
Subject: [PATCH 0/3] target/i386: kvm-unit-tests fixes related to page table lookup

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   b12498f..1db136a  master     -> master
 - [tag update]      patchew/20210317032217.1460684-1-michael.roth@amd.com -> patchew/20210317032217.1460684-1-michael.roth@amd.com
 - [tag update]      patchew/20210317035242.24418-1-crosa@redhat.com -> patchew/20210317035242.24418-1-crosa@redhat.com
 * [new tag]         patchew/20210318150022.1824646-1-pbonzini@redhat.com -> patchew/20210318150022.1824646-1-pbonzini@redhat.com
Switched to a new branch 'test'
2b850d1 target/i386: svm: do not discard high 32 bits of EXITINFO1
9870ea6 target/i386: fail if toggling LA57 in 64-bit mode
7c5ca0b target/i386: allow modifying TCG phys-addr-bits

=== OUTPUT BEGIN ===
1/3 Checking commit 7c5ca0b4b6bd (target/i386: allow modifying TCG phys-addr-bits)
2/3 Checking commit 9870ea6556c6 (target/i386: fail if toggling LA57 in 64-bit mode)
ERROR: suspect code indent for conditional statements (8, 13)
#23: FILE: target/i386/tcg/misc_helper.c:170:
+        if (((t0 ^ env->cr[4]) & CR4_LA57_MASK) &&
[...]
+             raise_exception_ra(env, EXCP0D_GPF, GETPC());

total: 1 errors, 0 warnings, 10 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 2b850d1e6ac9 (target/i386: svm: do not discard high 32 bits of EXITINFO1)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210318150022.1824646-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com