[v2] hw/block/pflash: Refactors around setting the device in read-array mode

[PATCH v2 00/12] hw/block/pflash: Refactors around setting the device in read-array mode

Posted by Philippe Mathieu-Daudé 4 years, 8 months ago

I remembered this almost 2 years old series while reviewing
David Edmondson's patches... (which are included at the end).

Basically we move things around to make the code easier to maintain.

Since v1:
- Addressed David/Bin comments
- Added R-b

Missing review: patches 7 & 8

Regards,

Phil.

David Edmondson (2):
  hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro
  hw/block/pflash_cfi: Replace DPRINTF with trace events

Philippe Mathieu-Daudé (10):
  hw/block/pflash_cfi: Fix code style for checkpatch.pl
  hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table()
  hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table()
  hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings()
  hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false)
  hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array
  hw/block/pflash_cfi02: Factor out pflash_reset_state_machine()
  hw/block/pflash_cfi02: Add DeviceReset method
  hw/block/pflash_cfi01: Clarify trace events
  hw/block/pflash_cfi01: Extract pflash_mode_read_array()

 hw/block/pflash_cfi01.c | 278 ++++++++++++++++++-----------------
 hw/block/pflash_cfi02.c | 316 ++++++++++++++++++++--------------------
 hw/block/trace-events   |  40 +++--
 3 files changed, 329 insertions(+), 305 deletions(-)

-- 
2.26.2

Re: [PATCH v2 00/12] hw/block/pflash: Refactors around setting the device in read-array mode

Posted by Philippe Mathieu-Daudé 4 years, 8 months ago

On 3/10/21 6:05 PM, Philippe Mathieu-Daudé wrote:
> I remembered this almost 2 years old series while reviewing
> David Edmondson's patches... (which are included at the end).
> 
> Basically we move things around to make the code easier to maintain.
> 
> David Edmondson (2):
>   hw/block/pflash_cfi01: Correct the type of PFlashCFI01.ro
>   hw/block/pflash_cfi: Replace DPRINTF with trace events
> 
> Philippe Mathieu-Daudé (10):
>   hw/block/pflash_cfi: Fix code style for checkpatch.pl
>   hw/block/pflash_cfi01: Extract pflash_cfi01_fill_cfi_table()
>   hw/block/pflash_cfi02: Extract pflash_cfi02_fill_cfi_table()
>   hw/block/pflash_cfi02: Set rom_mode to true in pflash_setup_mappings()
>   hw/block/pflash_cfi02: Open-code pflash_register_memory(rom=false)
>   hw/block/pflash_cfi02: Rename register_memory(true) as mode_read_array
>   hw/block/pflash_cfi02: Factor out pflash_reset_state_machine()
>   hw/block/pflash_cfi02: Add DeviceReset method
>   hw/block/pflash_cfi01: Clarify trace events
>   hw/block/pflash_cfi01: Extract pflash_mode_read_array()

Thanks, patches 1-10 & 12 queued to pflash-next.