[v2] hw/ppc: Convert UIC device to QOM

[PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

Peter Maydell posted 4 patches 3 years, 3 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210108171212.16500-1-peter.maydell@linaro.org

Maintainers: Greg Kurz <groug@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, BALATON Zoltan <balaton@eik.bme.hu>

hw/ppc/ppc405.h           |   8 +-
include/hw/intc/ppc-uic.h |   7 +
include/hw/ppc/ppc4xx.h   |   9 -
hw/ppc/ppc405_boards.c    |   8 +-
hw/ppc/ppc405_uc.c        | 415 ++++----------------------------------
hw/ppc/ppc4xx_devs.c      |  38 ----
hw/ppc/sam460ex.c         |  69 +++++--
7 files changed, 107 insertions(+), 447 deletions(-)

Expand all Fold all

[PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

Posted by Peter Maydell 3 years, 3 months ago

This patchseries converts the PPC UIC "Universal Interrupt
Controller" to a QOM device.  My main reason for doing it is that
this fixes a couple of long-standing trivial Coverity issues -- the
current ppcuic_init() function allocates an array of qemu_irqs which
the callers then leak.  (The leak is trivial because it happens once
when QEMU starts.)

The first half of v1 is in master now, so this is just a
respin of the last four patches.

Changes v1->v2:
 * fixed the bug in the sam460ex conversion handling of CINT
   (tested that this now boots AROS OK to a desktop)
 * other minor code style tweaks to patch 1 as per review

thanks
-- PMM

Peter Maydell (4):
  hw/ppc/sam460ex: Drop use of ppcuic_init()
  hw/ppc: Delete unused ppc405cr_init() code
  hw/ppc/ppc405_uc: Drop use of ppcuic_init()
  hw/ppc: Remove unused ppcuic_init()

 hw/ppc/ppc405.h           |   8 +-
 include/hw/intc/ppc-uic.h |   7 +
 include/hw/ppc/ppc4xx.h   |   9 -
 hw/ppc/ppc405_boards.c    |   8 +-
 hw/ppc/ppc405_uc.c        | 415 ++++----------------------------------
 hw/ppc/ppc4xx_devs.c      |  38 ----
 hw/ppc/sam460ex.c         |  69 +++++--
 7 files changed, 107 insertions(+), 447 deletions(-)

-- 
2.20.1

Re: [PATCH v2 0/4] hw/ppc: Convert UIC device to QOM

Posted by David Gibson 3 years, 3 months ago

On Fri, Jan 08, 2021 at 05:12:08PM +0000, Peter Maydell wrote:
> This patchseries converts the PPC UIC "Universal Interrupt
> Controller" to a QOM device.  My main reason for doing it is that
> this fixes a couple of long-standing trivial Coverity issues -- the
> current ppcuic_init() function allocates an array of qemu_irqs which
> the callers then leak.  (The leak is trivial because it happens once
> when QEMU starts.)
> 
> The first half of v1 is in master now, so this is just a
> respin of the last four patches.
> 
> Changes v1->v2:
>  * fixed the bug in the sam460ex conversion handling of CINT
>    (tested that this now boots AROS OK to a desktop)
>  * other minor code style tweaks to patch 1 as per review

Applied to ppc-for-6.0, thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson