[v1] Compile QEMU with -Wimplicit-fallthrough

[PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests

Posted by Thomas Huth 5 years, 1 month ago

The softfloat tests are external repositories, so we do not care
about implicit fallthrough warnings in this code.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/fp/meson.build | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/fp/meson.build b/tests/fp/meson.build
index 3d4fb00f9d..8d739c4d59 100644
--- a/tests/fp/meson.build
+++ b/tests/fp/meson.build
@@ -27,6 +27,7 @@ tfdir = 'berkeley-testfloat-3/source'
 sfinc = include_directories(sfdir / 'include', sfspedir)
 
 tfcflags = [
+  '-Wno-implicit-fallthrough',
   '-Wno-strict-prototypes',
   '-Wno-unknown-pragmas',
   '-Wno-uninitialized',
@@ -209,6 +210,7 @@ libtestfloat = static_library(
 )
 
 sfcflags = [
+  '-Wno-implicit-fallthrough',
   '-Wno-missing-prototypes',
   '-Wno-redundant-decls',
   '-Wno-return-type',
-- 
2.27.0

Re: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests

Posted by Richard Henderson 5 years, 1 month ago

On 12/11/20 9:24 AM, Thomas Huth wrote:
> The softfloat tests are external repositories, so we do not care
> about implicit fallthrough warnings in this code.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/fp/meson.build | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

RE: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests

Posted by Chenqun (kuhn) 5 years, 1 month ago

> -----Original Message-----
> From: Thomas Huth [mailto:thuth@redhat.com]
> Sent: Friday, December 11, 2020 11:24 PM
> To: Peter Maydell <peter.maydell@linaro.org>; qemu-devel@nongnu.org
> Cc: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; Richard Henderson
> <richard.henderson@linaro.org>; Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in
> the softfloat tests
> 
> The softfloat tests are external repositories, so we do not care about implicit
> fallthrough warnings in this code.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
Reviewed-by: Chen Qun <kuhn.chenqun@huawei.com>

The warnings are frequently generated for files in this directory. 
This is a good solution for the warnings.

Thanks,
Chen Qun
>  tests/fp/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build index
> 3d4fb00f9d..8d739c4d59 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -27,6 +27,7 @@ tfdir = 'berkeley-testfloat-3/source'
>  sfinc = include_directories(sfdir / 'include', sfspedir)
> 
>  tfcflags = [
> +  '-Wno-implicit-fallthrough',
>    '-Wno-strict-prototypes',
>    '-Wno-unknown-pragmas',
>    '-Wno-uninitialized',
> @@ -209,6 +210,7 @@ libtestfloat = static_library(
>  )
> 
>  sfcflags = [
> +  '-Wno-implicit-fallthrough',
>    '-Wno-missing-prototypes',
>    '-Wno-redundant-decls',
>    '-Wno-return-type',
> --
> 2.27.0