[PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough

Thomas Huth posted 14 patches 3 years, 4 months ago
Only 3 patches received!
accel/tcg/user-exec.c                |  3 ++-
bsd-user/main.c                      |  1 +
configure                            |  1 +
disas/libvixl/vixl/a64/disasm-a64.cc |  4 ++++
disas/libvixl/vixl/globals.h         |  6 +++--
hw/intc/arm_gicv3_kvm.c              |  8 +++++++
hw/rtc/twl92230.c                    | 44 ++++++++++++------------------------
hw/timer/renesas_tmr.c               |  1 +
include/qemu/compiler.h              | 11 +++++++++
target/i386/tcg/translate.c          |  7 ++++--
target/sparc/translate.c             |  2 +-
target/sparc/win_helper.c            |  2 +-
target/unicore32/translate.c         |  2 ++
tcg/optimize.c                       |  4 ++++
tests/fp/meson.build                 |  2 ++
15 files changed, 61 insertions(+), 37 deletions(-)
[PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough
Posted by Thomas Huth 3 years, 4 months ago
 Hi!

The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2:

  Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request'
  into staging (2020-12-17 18:53:36 +0000)

are available in the Git repository at:

  https://gitlab.com/huth/qemu.git tags/pull-request-2020-12-18

for you to fetch changes up to 0a2ebce92a3f10a89843e4a7a8e2f2eba4f7b109:

  configure: Compile with -Wimplicit-fallthrough=2 (2020-12-18 09:15:47 +0100)

----------------------------------------------------------------
* Compile QEMU with -Wimplicit-fallthrough=2 to avoid bugs in
  switch-case statements
----------------------------------------------------------------

 v2:
  - Added the patch for bsd-user
  - Included Philippe's twl92230 break patch

Chen Qun (6):
      hw/timer/renesas_tmr: silence the compiler warnings
      target/i386: silence the compiler warnings in gen_shiftd_rm_T1
      hw/intc/arm_gicv3_kvm: silence the compiler warnings
      accel/tcg/user-exec: silence the compiler warnings
      target/sparc/translate: silence the compiler warnings
      target/sparc/win_helper: silence the compiler warnings

Philippe Mathieu-Daudé (1):
      hw/rtc/twl92230: Add missing 'break'

Thomas Huth (7):
      disas/libvixl: Fix fall-through annotation for GCC >= 7
      target/unicore32/translate: Add missing fallthrough annotations
      hw/rtc/twl92230: Silence warnings about missing fallthrough statements
      tcg/optimize: Add fallthrough annotations
      tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests
      bsd-user: Silence warnings about missing fallthrough statement
      configure: Compile with -Wimplicit-fallthrough=2

 accel/tcg/user-exec.c                |  3 ++-
 bsd-user/main.c                      |  1 +
 configure                            |  1 +
 disas/libvixl/vixl/a64/disasm-a64.cc |  4 ++++
 disas/libvixl/vixl/globals.h         |  6 +++--
 hw/intc/arm_gicv3_kvm.c              |  8 +++++++
 hw/rtc/twl92230.c                    | 44 ++++++++++++------------------------
 hw/timer/renesas_tmr.c               |  1 +
 include/qemu/compiler.h              | 11 +++++++++
 target/i386/tcg/translate.c          |  7 ++++--
 target/sparc/translate.c             |  2 +-
 target/sparc/win_helper.c            |  2 +-
 target/unicore32/translate.c         |  2 ++
 tcg/optimize.c                       |  4 ++++
 tests/fp/meson.build                 |  2 ++
 15 files changed, 61 insertions(+), 37 deletions(-)


Re: [PULL v2 00/14] Compile QEMU with -Wimplicit-fallthrough
Posted by Peter Maydell 3 years, 4 months ago
On Fri, 18 Dec 2020 at 08:27, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi!
>
> The following changes since commit 75ee62ac606bfc9eb59310b9446df3434bf6e8c2:
>
>   Merge remote-tracking branch 'remotes/ehabkost-gl/tags/x86-next-pull-request'
>   into staging (2020-12-17 18:53:36 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/huth/qemu.git tags/pull-request-2020-12-18
>
> for you to fetch changes up to 0a2ebce92a3f10a89843e4a7a8e2f2eba4f7b109:
>
>   configure: Compile with -Wimplicit-fallthrough=2 (2020-12-18 09:15:47 +0100)
>
> ----------------------------------------------------------------
> * Compile QEMU with -Wimplicit-fallthrough=2 to avoid bugs in
>   switch-case statements
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.

-- PMM