target/unicore32/translate: Add missing fallthrough annotations

[PATCH] target/unicore32/translate: Add missing fallthrough annotations

Thomas Huth posted 1 patch 3 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201030093157.11795-1-thuth@redhat.com

Maintainers: Guan Xuetao <gxt@mprc.pku.edu.cn>

target/unicore32/translate.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] target/unicore32/translate: Add missing fallthrough annotations

Posted by Thomas Huth 3 years, 6 months ago

Looking at the way the code is formatted here (there is an empty
line after break statements, but none where the break is missing),
the fallthrough is very likely intended here. So add a fallthrough
comment to make the it compilable with -Werror=implicit-fallthrough.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 target/unicore32/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c
index d4b06df672..962f9877a0 100644
--- a/target/unicore32/translate.c
+++ b/target/unicore32/translate.c
@@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
             do_misc(env, s, insn);
             break;
         }
+        /* fallthrough */
     case 0x1:
         if (((UCOP_OPCODES >> 2) == 2) && !UCOP_SET_S) {
             do_misc(env, s, insn);
@@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
         if (UCOP_SET(8) || UCOP_SET(5)) {
             ILLEGAL;
         }
+        /* fallthrough */
     case 0x3:
         do_ldst_ir(env, s, insn);
         break;
-- 
2.18.2

Re: [PATCH] target/unicore32/translate: Add missing fallthrough annotations

Posted by Richard Henderson 3 years, 6 months ago

On 10/30/20 2:31 AM, Thomas Huth wrote:
> Looking at the way the code is formatted here (there is an empty
> line after break statements, but none where the break is missing),
> the fallthrough is very likely intended here. So add a fallthrough
> comment to make the it compilable with -Werror=implicit-fallthrough.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  target/unicore32/translate.c | 2 ++
>  1 file changed, 2 insertions(+)

We don't need to guess based on blank lines.
This matches with the instruction set overview at

https://en.wikipedia.org/wiki/Unicore

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~