From nobody Fri May 17 22:04:12 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1604050429; cv=none; d=zohomail.com; s=zohoarc; b=gmhpgSg8Q8EBQRNO11BxU/wWAHEOX8S9NGbLT77VX2jB4LEpkx4Q6z73/Gaj4WkzcL/aGIPSR5iEisqvjVReca4B1QxBICq7im0UnrWemEkCy18xIwzADDsVIAoGnsz6ZPVAqHubmGkZ1iwiX6qaBlhn4WkR/a81Vq7JG379fd0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604050429; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=j9+co+yHNebq0st5iScvOYiGRcFH9wqN3HV3MiZmaMQ=; b=oDe6OCfdhZ7DuFtL/D7czqWZ/5p6w+oFAQ4gVw4KhkHlpnRY2xRps36qMElMXdatwgnvkjRYu7JMrtmliNrJ/pA35qnyaRhMX+SatmUn4EEvFrP78JF9RkwTvK6XYVsk+dJKJT1Y4j7w7kIkINKICPLE2n2Ihu6YwSBqLloIR7U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1604050429575621.4558547739922; Fri, 30 Oct 2020 02:33:49 -0700 (PDT) Received: from localhost ([::1]:41410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYQn5-00072X-UG for importer@patchew.org; Fri, 30 Oct 2020 05:33:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYQlb-0006E4-HX for qemu-devel@nongnu.org; Fri, 30 Oct 2020 05:32:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:44963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kYQlZ-0006H9-Rr for qemu-devel@nongnu.org; Fri, 30 Oct 2020 05:32:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-582-cNCtOz6VOnSWcfnF2kaxkA-1; Fri, 30 Oct 2020 05:32:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D179F10B9CA1; Fri, 30 Oct 2020 09:32:01 +0000 (UTC) Received: from thuth.com (ovpn-113-87.ams2.redhat.com [10.36.113.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53E876198B; Fri, 30 Oct 2020 09:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604050330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:content-type:content-type; bh=j9+co+yHNebq0st5iScvOYiGRcFH9wqN3HV3MiZmaMQ=; b=XYLqHrvIUjm+dTOnCH9aa+hTO43tencIs6AAqaqjz5o9Ka0NjTqS799G9glF5ae6wry0SP QXBs+B9efDemq2RrY6vdgd+aSDaS1OSdLV8XQViDc6CnXWMcTCFMs3+XAdjApdUunxFtPk MYxctiQrR1bNeBK33BNo9bx1s4zoTBA= X-MC-Unique: cNCtOz6VOnSWcfnF2kaxkA-1 From: Thomas Huth To: qemu-devel@nongnu.org, Guan Xuetao Subject: [PATCH] target/unicore32/translate: Add missing fallthrough annotations Date: Fri, 30 Oct 2020 10:31:57 +0100 Message-Id: <20201030093157.11795-1-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/30 01:22:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Looking at the way the code is formatted here (there is an empty line after break statements, but none where the break is missing), the fallthrough is very likely intended here. So add a fallthrough comment to make the it compilable with -Werror=3Dimplicit-fallthrough. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson --- target/unicore32/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c index d4b06df672..962f9877a0 100644 --- a/target/unicore32/translate.c +++ b/target/unicore32/translate.c @@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, D= isasContext *s) do_misc(env, s, insn); break; } + /* fallthrough */ case 0x1: if (((UCOP_OPCODES >> 2) =3D=3D 2) && !UCOP_SET_S) { do_misc(env, s, insn); @@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, D= isasContext *s) if (UCOP_SET(8) || UCOP_SET(5)) { ILLEGAL; } + /* fallthrough */ case 0x3: do_ldst_ir(env, s, insn); break; --=20 2.18.2