[PATCH V2 08/14] m68k/: fix some comment spelling errors

zhaolichang posted 14 patches 5 years, 4 months ago
There is a newer version of this series
[PATCH V2 08/14] m68k/: fix some comment spelling errors
Posted by zhaolichang 5 years, 4 months ago
I found that there are many spelling errors in the comments of qemu/target/m68k.
I used spellcheck to check the spelling errors and found some errors in the folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>
Reviewed-by: Laurent Vivier<laurent@vivier.eu>
---
 target/m68k/translate.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 3fc67aa452..133a404919 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -438,7 +438,7 @@ static TCGv gen_addr_index(DisasContext *s, uint16_t ext, TCGv tmp)
 }
 
 /*
- * Handle a base + index + displacement effective addresss.
+ * Handle a base + index + displacement effective address.
  * A NULL_QREG base means pc-relative.
  */
 static TCGv gen_lea_indexed(CPUM68KState *env, DisasContext *s, TCGv base)
@@ -1696,7 +1696,7 @@ static void bcd_add(TCGv dest, TCGv src)
 
     /*
      * t1 = (src + 0x066) + dest + X
-     *    = result with some possible exceding 0x6
+     *    = result with some possible exceeding 0x6
      */
 
     t0 = tcg_const_i32(0x066);
@@ -1706,7 +1706,7 @@ static void bcd_add(TCGv dest, TCGv src)
     tcg_gen_add_i32(t1, t0, dest);
     tcg_gen_add_i32(t1, t1, QREG_CC_X);
 
-    /* we will remove exceding 0x6 where there is no carry */
+    /* we will remove exceeding 0x6 where there is no carry */
 
     /*
      * t0 = (src + 0x0066) ^ dest
@@ -1736,7 +1736,7 @@ static void bcd_add(TCGv dest, TCGv src)
     tcg_temp_free(t0);
 
     /*
-     * remove the exceding 0x6
+     * remove the exceeding 0x6
      * for digits that have not generated a carry
      */
 
@@ -2638,7 +2638,7 @@ DISAS_INSN(negx)
     gen_flush_flags(s); /* compute old Z */
 
     /*
-     * Perform substract with borrow.
+     * Perform subtract with borrow.
      * (X, N) =  -(src + X);
      */
 
@@ -2653,7 +2653,7 @@ DISAS_INSN(negx)
     /*
      * Compute signed-overflow for negation.  The normal formula for
      * subtraction is (res ^ src) & (src ^ dest), but with dest==0
-     * this simplies to res & src.
+     * this simplifies to res & src.
      */
 
     tcg_gen_and_i32(QREG_CC_V, QREG_CC_N, src);
@@ -3159,7 +3159,7 @@ static inline void gen_subx(DisasContext *s, TCGv src, TCGv dest, int opsize)
     gen_flush_flags(s); /* compute old Z */
 
     /*
-     * Perform substract with borrow.
+     * Perform subtract with borrow.
      * (X, N) = dest - (src + X);
      */
 
@@ -3169,7 +3169,7 @@ static inline void gen_subx(DisasContext *s, TCGv src, TCGv dest, int opsize)
     gen_ext(QREG_CC_N, QREG_CC_N, opsize, 1);
     tcg_gen_andi_i32(QREG_CC_X, QREG_CC_X, 1);
 
-    /* Compute signed-overflow for substract.  */
+    /* Compute signed-overflow for subtract.  */
 
     tcg_gen_xor_i32(QREG_CC_V, QREG_CC_N, dest);
     tcg_gen_xor_i32(tmp, dest, src);
-- 
2.26.2.windows.1


Re: [PATCH V2 08/14] m68k/: fix some comment spelling errors
Posted by Laurent Vivier 5 years, 1 month ago
Le 09/10/2020 à 08:44, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu/target/m68k.
> I used spellcheck to check the spelling errors and found some errors in the folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>
> Reviewed-by: Laurent Vivier<laurent@vivier.eu>
> ---
>  target/m68k/translate.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 

Applied to my m68k-for-6.0 branch

Thanks,
Laurent


Re: [PATCH V2 08/14] m68k/: fix some comment spelling errors
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago
Hi Laurent,

On Sat, Dec 12, 2020 at 6:11 PM Laurent Vivier <laurent@vivier.eu> wrote:
> Le 09/10/2020 à 08:44, zhaolichang a écrit :
> > I found that there are many spelling errors in the comments of qemu/target/m68k.
> > I used spellcheck to check the spelling errors and found some errors in the folder.
> >
> > Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> > Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> > Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>

Do you mind replacing this line by:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks,

Phil.

> > Reviewed-by: Laurent Vivier<laurent@vivier.eu>
> > ---
> >  target/m68k/translate.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
>
> Applied to my m68k-for-6.0 branch
>
> Thanks,
> Laurent
>

Re: [PATCH V2 08/14] m68k/: fix some comment spelling errors
Posted by Laurent Vivier 5 years, 1 month ago
Le 12/12/2020 à 18:56, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
> 
> On Sat, Dec 12, 2020 at 6:11 PM Laurent Vivier <laurent@vivier.eu> wrote:
>> Le 09/10/2020 à 08:44, zhaolichang a écrit :
>>> I found that there are many spelling errors in the comments of qemu/target/m68k.
>>> I used spellcheck to check the spelling errors and found some errors in the folder.
>>>
>>> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
>>> Reviewed-by: David Edmondson <david.edmondson@oracle.com>
>>> Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>
> 
> Do you mind replacing this line by:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 

Sorry, too late...

Laurent

Re: [PATCH V2 08/14] m68k/: fix some comment spelling errors
Posted by Philippe Mathieu-Daudé 5 years, 1 month ago
On Sat, Dec 12, 2020 at 8:58 PM Laurent Vivier <laurent@vivier.eu> wrote:
> Le 12/12/2020 à 18:56, Philippe Mathieu-Daudé a écrit :
> > Hi Laurent,
> >
> > On Sat, Dec 12, 2020 at 6:11 PM Laurent Vivier <laurent@vivier.eu> wrote:
> >> Le 09/10/2020 à 08:44, zhaolichang a écrit :
> >>> I found that there are many spelling errors in the comments of qemu/target/m68k.
> >>> I used spellcheck to check the spelling errors and found some errors in the folder.
> >>>
> >>> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> >>> Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> >>> Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>
> >
> > Do you mind replacing this line by:
> > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
>
> Sorry, too late...

No problem, mojibake happens, not a big deal.

Thanks anyway :)

Phil.