[PATCH V2 00/14] fix some comment spelling errors

zhaolichang posted 14 patches 3 years, 6 months ago
Test checkpatch failed
Failed in applying to current master (apply log)
There is a newer version of this series
target/alpha/cpu.h               |  4 ++--
target/alpha/translate.c         |  2 +-
target/arm/cpu.h                 |  2 +-
target/arm/helper.c              |  4 ++--
target/arm/m_helper.c            |  2 +-
target/arm/translate-a64.c       |  4 ++--
target/arm/translate-sve.c       |  2 +-
target/avr/helper.c              |  6 +++---
target/cris/helper.c             |  6 +++---
target/cris/op_helper.c          |  2 +-
target/cris/translate.c          | 14 +++++++-------
target/i386/cpu.c                |  4 ++--
target/i386/hax-interface.h      |  4 ++--
target/i386/hax-windows.c        |  2 +-
target/i386/kvm.c                |  2 +-
target/i386/machine.c            |  6 +++---
target/i386/translate.c          |  8 ++++----
target/i386/whpx-all.c           |  2 +-
target/m68k/translate.c          | 16 ++++++++--------
target/mips/internal.h           |  2 +-
target/mips/translate.c          | 10 +++++-----
target/mips/translate_init.c.inc |  2 +-
target/openrisc/cpu.h            |  2 +-
target/ppc/cpu.h                 |  6 +++---
target/ppc/excp_helper.c         |  6 +++---
target/ppc/fpu_helper.c          |  2 +-
target/ppc/internal.h            |  2 +-
target/ppc/kvm.c                 |  2 +-
target/ppc/machine.c             |  2 +-
target/ppc/mmu-hash64.c          |  2 +-
target/ppc/mmu_helper.c          |  4 ++--
target/ppc/translate_init.c.inc  |  2 +-
target/riscv/cpu.c               |  2 +-
target/riscv/cpu_bits.h          |  2 +-
target/riscv/csr.c               |  6 +++---
target/riscv/vector_helper.c     |  2 +-
target/rx/op_helper.c            |  2 +-
target/rx/translate.c            |  2 +-
target/s390x/cpu_models.h        |  4 ++--
target/s390x/excp_helper.c       |  2 +-
target/s390x/fpu_helper.c        |  2 +-
target/s390x/insn-data.def       |  2 +-
target/s390x/ioinst.c            |  2 +-
target/s390x/misc_helper.c       |  2 +-
target/s390x/translate.c         |  4 ++--
target/s390x/translate_vx.c.inc  |  2 +-
target/sh4/cpu.h                 |  2 +-
target/sh4/op_helper.c           |  2 +-
target/sh4/translate.c           |  2 +-
target/sparc/asi.h               |  2 +-
target/tricore/csfr.def          |  2 +-
target/tricore/translate.c       |  2 +-
target/unicore32/translate.c     |  2 +-
53 files changed, 93 insertions(+), 93 deletions(-)
[PATCH V2 00/14] fix some comment spelling errors
Posted by zhaolichang 3 years, 6 months ago
I found that there are many spelling errors in the comments of qemu/target/.
I used spellcheck to check the spelling errors and found some errors in the folder.

The checkpatch.pl file in the Linux kernel can check spelling errors in patches.
I'm trying to add this function to the checkpatch.pl in qemu,
so that no similar spelling errors will occur in the feture.
It's not done yet and I will commit the patch when it's done.

v1 -> v2:
  add reviewed-by for patch

Signed-off-by: zhaolichang <zhaolichang@huawei.com>

zhaolichang (14):
  cris/: fix some comment spelling errors
  ppc/: fix some comment spelling errors
  riscv/: fix some comment spelling errors
  rx/: fix some comment spelling errors
  tricore/: fix some comment spelling errors
  mips/: fix some comment spelling errors
  s390x/: fix some comment spelling errors
  m68k/: fix some comment spelling errors
  sh4/: fix some comment spelling errors
  i386/: fix some comment spelling errors
  avr/: fix some comment spelling errors
  arm/: fix some comment spelling errors
  alpha/: fix some comment spelling errors
  target/: fix some comment spelling errors

 target/alpha/cpu.h               |  4 ++--
 target/alpha/translate.c         |  2 +-
 target/arm/cpu.h                 |  2 +-
 target/arm/helper.c              |  4 ++--
 target/arm/m_helper.c            |  2 +-
 target/arm/translate-a64.c       |  4 ++--
 target/arm/translate-sve.c       |  2 +-
 target/avr/helper.c              |  6 +++---
 target/cris/helper.c             |  6 +++---
 target/cris/op_helper.c          |  2 +-
 target/cris/translate.c          | 14 +++++++-------
 target/i386/cpu.c                |  4 ++--
 target/i386/hax-interface.h      |  4 ++--
 target/i386/hax-windows.c        |  2 +-
 target/i386/kvm.c                |  2 +-
 target/i386/machine.c            |  6 +++---
 target/i386/translate.c          |  8 ++++----
 target/i386/whpx-all.c           |  2 +-
 target/m68k/translate.c          | 16 ++++++++--------
 target/mips/internal.h           |  2 +-
 target/mips/translate.c          | 10 +++++-----
 target/mips/translate_init.c.inc |  2 +-
 target/openrisc/cpu.h            |  2 +-
 target/ppc/cpu.h                 |  6 +++---
 target/ppc/excp_helper.c         |  6 +++---
 target/ppc/fpu_helper.c          |  2 +-
 target/ppc/internal.h            |  2 +-
 target/ppc/kvm.c                 |  2 +-
 target/ppc/machine.c             |  2 +-
 target/ppc/mmu-hash64.c          |  2 +-
 target/ppc/mmu_helper.c          |  4 ++--
 target/ppc/translate_init.c.inc  |  2 +-
 target/riscv/cpu.c               |  2 +-
 target/riscv/cpu_bits.h          |  2 +-
 target/riscv/csr.c               |  6 +++---
 target/riscv/vector_helper.c     |  2 +-
 target/rx/op_helper.c            |  2 +-
 target/rx/translate.c            |  2 +-
 target/s390x/cpu_models.h        |  4 ++--
 target/s390x/excp_helper.c       |  2 +-
 target/s390x/fpu_helper.c        |  2 +-
 target/s390x/insn-data.def       |  2 +-
 target/s390x/ioinst.c            |  2 +-
 target/s390x/misc_helper.c       |  2 +-
 target/s390x/translate.c         |  4 ++--
 target/s390x/translate_vx.c.inc  |  2 +-
 target/sh4/cpu.h                 |  2 +-
 target/sh4/op_helper.c           |  2 +-
 target/sh4/translate.c           |  2 +-
 target/sparc/asi.h               |  2 +-
 target/tricore/csfr.def          |  2 +-
 target/tricore/translate.c       |  2 +-
 target/unicore32/translate.c     |  2 +-
 53 files changed, 93 insertions(+), 93 deletions(-)

-- 
2.26.2.windows.1


Re: [PATCH V2 00/14] fix some comment spelling errors
Posted by no-reply@patchew.org 3 years, 6 months ago
Patchew URL: https://patchew.org/QEMU/20201009064449.2336-1-zhaolichang@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201009064449.2336-1-zhaolichang@huawei.com
Subject: [PATCH V2 00/14] fix some comment spelling errors

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201009064449.2336-1-zhaolichang@huawei.com -> patchew/20201009064449.2336-1-zhaolichang@huawei.com
 * [new tag]         patchew/20201009064858.323624-1-armbru@redhat.com -> patchew/20201009064858.323624-1-armbru@redhat.com
Switched to a new branch 'test'
25b65d8 target/: fix some comment spelling errors
085cdde alpha/: fix some comment spelling errors
ec812f0 arm/: fix some comment spelling errors
729762d avr/: fix some comment spelling errors
3e0605c i386/: fix some comment spelling errors
02d26f2 sh4/: fix some comment spelling errors
cc0c6a7 m68k/: fix some comment spelling errors
d3713f0 s390x/: fix some comment spelling errors
be98a94 mips/: fix some comment spelling errors
68e09fe tricore/: fix some comment spelling errors
a8a59c3 rx/: fix some comment spelling errors
c6e1b75 riscv/: fix some comment spelling errors
a898e79 ppc/: fix some comment spelling errors
b6fffd3 cris/: fix some comment spelling errors

=== OUTPUT BEGIN ===
1/14 Checking commit b6fffd33b968 (cris/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#23: FILE: target/cris/helper.c:144:
+        /* These exceptions are generated by the core itself.

WARNING: Block comments use a leading /* on a separate line
#32: FILE: target/cris/helper.c:200:
+        /* These exceptions are generated by the core itself.

WARNING: Block comments use a leading /* on a separate line
#41: FILE: target/cris/helper.c:259:
+    /* Clear the excption_index to avoid spurious hw_aborts for recursive

ERROR: trailing whitespace
#112: FILE: target/cris/translate.c:3056:
+ * The TB containing the branch insn will set up env->btarget and evaluate $

total: 1 errors, 3 warnings, 86 lines checked

Patch 1/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/14 Checking commit a898e796b356 (ppc/: fix some comment spelling errors)
3/14 Checking commit c6e1b757e105 (riscv/: fix some comment spelling errors)
4/14 Checking commit a8a59c37ccbf (rx/: fix some comment spelling errors)
5/14 Checking commit 68e09fe5f350 (tricore/: fix some comment spelling errors)
WARNING: Block comments use a trailing */ on a separate line
#46: FILE: target/tricore/translate.c:400:
+                                    since no exception occurs */

total: 0 errors, 1 warnings, 21 lines checked

Patch 5/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/14 Checking commit be98a94fb597 (mips/: fix some comment spelling errors)
7/14 Checking commit d3713f00a7b9 (s390x/: fix some comment spelling errors)
8/14 Checking commit cc0c6a7697e5 (m68k/: fix some comment spelling errors)
9/14 Checking commit 02d26f2e1170 (sh4/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#24: FILE: target/sh4/cpu.h:163:
+    uint32_t ttb;^I^I/* translation table base register */$

WARNING: Block comments use a trailing */ on a separate line
#37: FILE: target/sh4/op_helper.c:403:
+       IEEE rule that other exceptions take precedence.  */

WARNING: Block comments use a leading /* on a separate line
#50: FILE: target/sh4/translate.c:1962:
+        /* Here we want to recognize ld_dst being saved for later consumption,

total: 1 errors, 2 warnings, 24 lines checked

Patch 9/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/14 Checking commit 3e0605cc7e54 (i386/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#23: FILE: target/i386/cpu.c:4680:
+/* Compatibility hack to maintain legacy +-feat semantic,

WARNING: Block comments use a trailing */ on a separate line
#121: FILE: target/i386/translate.c:896:
+   value 'b'. In the fast case, T0 is guaranteed not to be used. */

WARNING: Block comments use a trailing */ on a separate line
#130: FILE: target/i386/translate.c:1029:
+   value 'b'. In the fast case, T0 is guaranteed not to be used. */

WARNING: Block comments use a leading /* on a separate line
#148: FILE: target/i386/translate.c:6844:
+                /* Needs no atomic ops; we suppressed the normal

total: 0 errors, 4 warnings, 110 lines checked

Patch 10/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/14 Checking commit 729762daa63d (avr/: fix some comment spelling errors)
12/14 Checking commit ec812f092ed3 (arm/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#24: FILE: target/arm/cpu.h:2093:
+/* Function for determining whether guest cp register reads and writes should

total: 0 errors, 1 warnings, 56 lines checked

Patch 12/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/14 Checking commit 085cdde202db (alpha/: fix some comment spelling errors)
WARNING: Block comments use a leading /* on a separate line
#33: FILE: target/alpha/cpu.h:373:
+/* CPUAlphaState->flags constants.  These are laid out so that we

total: 0 errors, 1 warnings, 24 lines checked

Patch 13/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/14 Checking commit 25b65d88a33a (target/: fix some comment spelling errors)
ERROR: code indent should never use tabs
#37: FILE: target/sparc/asi.h:234:
+#define ASI_IC_INSTR^I^I0x66 /* Insn cache instruction ram diag^I*/$

total: 1 errors, 0 warnings, 24 lines checked

Patch 14/14 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20201009064449.2336-1-zhaolichang@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com