hw/misc/mips_cpc: Start vCPU when powered on

[PATCH] hw/misc/mips_cpc: Start vCPU when powered on

Philippe Mathieu-Daudé posted 1 patch 3 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201007113942.2523866-1-f4bug@amsat.org

Maintainers: Jiaxun Yang <jiaxun.yang@flygoat.com>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>

hw/misc/mips_cpc.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] hw/misc/mips_cpc: Start vCPU when powered on

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

In commit 102ca9667d we set "start-powered-off" on all vCPUs
included in the CPS (Coherent Processing System) but forgot to
start the vCPUS on when they are powered on in the CPC (Cluster
Power Controller).

This fixes the following tests:

  $ avocado run tests/acceptance/machine_mips_malta.py
   (1/3) test_mips_malta_i6400_framebuffer_logo_1core: PASS (3.67 s)
   (2/3) test_mips_malta_i6400_framebuffer_logo_7cores: INTERRUPTED: Test interrupted by SIGTERM (30.22 s)
   (3/3) test_mips_malta_i6400_framebuffer_logo_8cores: INTERRUPTED: Test interrupted by SIGTERM (30.25 s)
  RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | CANCEL 0

Fixes: 102ca9667d ("mips/cps: Use start-powered-off CPUState property")
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/mips_cpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
index 2f7b2c9592..7c11fb3d44 100644
--- a/hw/misc/mips_cpc.c
+++ b/hw/misc/mips_cpc.c
@@ -38,6 +38,7 @@ static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
     MIPSCPCState *cpc = (MIPSCPCState *) data.host_ptr;
 
     cpu_reset(cs);
+    cs->halted = 0;
     cpc->vp_running |= 1ULL << cs->cpu_index;
 }
 
-- 
2.26.2

Re: [PATCH] hw/misc/mips_cpc: Start vCPU when powered on

Posted by Alex Bennée 3 years, 6 months ago

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> In commit 102ca9667d we set "start-powered-off" on all vCPUs
> included in the CPS (Coherent Processing System) but forgot to
> start the vCPUS on when they are powered on in the CPC (Cluster
> Power Controller).
>
> This fixes the following tests:
>
>   $ avocado run tests/acceptance/machine_mips_malta.py
>    (1/3) test_mips_malta_i6400_framebuffer_logo_1core: PASS (3.67 s)
>    (2/3) test_mips_malta_i6400_framebuffer_logo_7cores: INTERRUPTED: Test interrupted by SIGTERM (30.22 s)
>    (3/3) test_mips_malta_i6400_framebuffer_logo_8cores: INTERRUPTED: Test interrupted by SIGTERM (30.25 s)
>   RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | CANCEL 0
>
> Fixes: 102ca9667d ("mips/cps: Use start-powered-off CPUState property")
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Tested-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Queued to prepr/misc-testing-gitdm-plugin-fixes, thanks.

-- 
Alex Bennée