From nobody Sat May 18 05:53:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) client-ip=209.85.221.66; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f66.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1602070786; cv=none; d=zohomail.com; s=zohoarc; b=G6ZsLc8D1Q1hbFAyd6URuB3TaVbUzYXlp6bnZ8FFQ7ysxTfnjvYXvkekiB9S34cGopHCeXK4MKmgBBPrMy1po5mr37N++M5S05QUNl3N5PEGfGVhsZjE7nFNeiPAnU+OkcWbB1XpUz5WCXpVKMJxZhMvXWaXDNkSLeK7IAwKDdg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602070786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=5+7THP4dY/8al2VHQ8XamujtFg9xFO4ttfHPSEDv+4I=; b=J/IdKjppWCaXLk6JXTi91JI/kdQOKaAXJq4+g+KGdB9DYSSJf17uZFDRWyFyBwqhbru5OIpE6Y56ie62OAsMQjK3hOIX6UF4Gq9P4QeTYdPfHlos1hf9d/4EUwrs3B5vSC14qnqeLZ85CbX6xjTkN3+qKVLg+hqtE1pozM3M4L4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.66 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.zohomail.com with SMTPS id 1602070786670833.1885667371913; Wed, 7 Oct 2020 04:39:46 -0700 (PDT) Received: by mail-wr1-f66.google.com with SMTP id w5so1755757wrp.8 for ; Wed, 07 Oct 2020 04:39:46 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id u15sm2575279wrm.77.2020.10.07.04.39.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 04:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5+7THP4dY/8al2VHQ8XamujtFg9xFO4ttfHPSEDv+4I=; b=Ys9cJuu056cdEEG+tJK56Zabf2NT81/emyksgw4nwGBtIEvXZbxdK0SgVWPTWy3KNp ENoSBD0C4UNMlE66FUU06vFRyfGafpeDvy7P3Bt0yX7WINaOn18yPohsZ7G4mn3FPR33 PzHiTjLUnHf/ICR1r57OINgWPlcBHkYBS9yjLj675syxuBwe9du8UsQuXfEKRsEm055y S5PH7B5J9uh7dkFdo+X7dG0GlTkJ2sVgt7I0v0BEHzJ7GVqMAU+nJcb4FNX6jRUBuzuq IKa6BVd0+IPdWcLXIcvJVDeJiVacubgpCV5L3Rdw2od3Wp83assja6yibLinHBfrQPXy 9xFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=5+7THP4dY/8al2VHQ8XamujtFg9xFO4ttfHPSEDv+4I=; b=NsZruKIK1kaBFcPqadg11XVooS5EcISr854A/AzmOjp614nOSMtS+rmHTPmReH9+ZP KTu4+B4T/kbBA3O/Pb4Uz2V55+5DfJnNYEA+hzJDFzoPJit54pl1rdEquOOKykOInAdS qVFbJHXD0SgoqGtpix9ovr/EH7IAn2jyBUdz7orkA3vghcX31i2uEnfZO+v99+3yt0VW Gmomf34AkHRwQKgCx6zNTSOmkxhpp/+uAUVmuQteBkn/fXHY8n1pMzvbL6df0BCBdvJO 2snObcifxZq9uA+KGDW3FtKYJpoIxUBlIxGyuW/ImPppXQ4yffbM3ejuglLyMA4tXIHc tmpg== X-Gm-Message-State: AOAM532mI59cmR8FtvqHk1j3lyuAccxSAMSQzZ/zoij/wq+B6hn7bVEY Q/OGZMUN6Q0WoEKCMUSkRcQ= X-Google-Smtp-Source: ABdhPJwfQJghyz/IFYjkA7rwU7Vl16RLPCx4J0LNOD13VPk/dUg+VxRnxH/J+USUwRyB17JiRi+hJg== X-Received: by 2002:adf:ce01:: with SMTP id p1mr2871450wrn.33.1602070784757; Wed, 07 Oct 2020 04:39:44 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: David Gibson , Thiago Jung Bauermann , Aurelien Jarno , Jiaxun Yang , Aleksandar Markovic , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH] hw/misc/mips_cpc: Start vCPU when powered on Date: Wed, 7 Oct 2020 13:39:42 +0200 Message-Id: <20201007113942.2523866-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) In commit 102ca9667d we set "start-powered-off" on all vCPUs included in the CPS (Coherent Processing System) but forgot to start the vCPUS on when they are powered on in the CPC (Cluster Power Controller). This fixes the following tests: $ avocado run tests/acceptance/machine_mips_malta.py (1/3) test_mips_malta_i6400_framebuffer_logo_1core: PASS (3.67 s) (2/3) test_mips_malta_i6400_framebuffer_logo_7cores: INTERRUPTED: Test i= nterrupted by SIGTERM (30.22 s) (3/3) test_mips_malta_i6400_framebuffer_logo_8cores: INTERRUPTED: Test i= nterrupted by SIGTERM (30.25 s) RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | = CANCEL 0 Fixes: 102ca9667d ("mips/cps: Use start-powered-off CPUState property") Reported-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/misc/mips_cpc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c index 2f7b2c9592..7c11fb3d44 100644 --- a/hw/misc/mips_cpc.c +++ b/hw/misc/mips_cpc.c @@ -38,6 +38,7 @@ static void mips_cpu_reset_async_work(CPUState *cs, run_o= n_cpu_data data) MIPSCPCState *cpc =3D (MIPSCPCState *) data.host_ptr; =20 cpu_reset(cs); + cs->halted =3D 0; cpc->vp_running |=3D 1ULL << cs->cpu_index; } =20 --=20 2.26.2