[RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon

Philippe Mathieu-Daudé posted 3 patches 3 years, 7 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201005105442.2093105-1-philmd@redhat.com
Maintainers: Laurent Vivier <laurent@vivier.eu>, Michael Tokarev <mjt@tls.msk.ru>
There is a newer version of this series
hw/nvram/fw_cfg.c            |  7 -------
qom/fw_cfg_interface.c       | 15 +++++++++++++++
MAINTAINERS                  |  1 +
qom/meson.build              |  5 +++++
tests/Makefile.include       |  5 +++++
tests/qemu-storage-daemon.sh | 10 ++++++++++
6 files changed, 36 insertions(+), 7 deletions(-)
create mode 100644 qom/fw_cfg_interface.c
create mode 100755 tests/qemu-storage-daemon.sh
[RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon
Posted by Philippe Mathieu-Daudé 3 years, 7 months ago
Attempt to fix the issue reported by Kevin.

Introduce a trivial test, but there is currently no
framework in place to test qemu-storage-daemon.

There might be better fix to this QOM issue,
I went for the easiest one I could figure out.

Philippe Mathieu-Daudé (3):
  qom: Always register FW_CFG_DATA_GENERATOR_INTERFACE
  tests: Only build socket_scm_helper when a softmmu target is available
  tests: Add a trivial qemu-storage-daemon test

 hw/nvram/fw_cfg.c            |  7 -------
 qom/fw_cfg_interface.c       | 15 +++++++++++++++
 MAINTAINERS                  |  1 +
 qom/meson.build              |  5 +++++
 tests/Makefile.include       |  5 +++++
 tests/qemu-storage-daemon.sh | 10 ++++++++++
 6 files changed, 36 insertions(+), 7 deletions(-)
 create mode 100644 qom/fw_cfg_interface.c
 create mode 100755 tests/qemu-storage-daemon.sh

-- 
2.26.2

Re: [RFC PATCH 0/3] qom: Fix missing interface in qemu-storage-daemon
Posted by no-reply@patchew.org 3 years, 7 months ago
Patchew URL: https://patchew.org/QEMU/20201005105442.2093105-1-philmd@redhat.com/



Hi,

This series failed build test on FreeBSD host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
  QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
  QEMU=/usr/libexec/qemu-kvm
else
  exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20201005105442.2093105-1-philmd@redhat.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com