[v3] qom: Fix missing interface in qemu-storage-daemon

[PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

Philippe Mathieu-Daudé posted 1 patch 3 years, 7 months ago

Diff against v1 v2
Download series mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20201006153636.2383248-1-philmd@redhat.com

hw/nvram/fw_cfg-interface.c | 15 +++++++++++++++
hw/nvram/fw_cfg.c           |  7 -------
MAINTAINERS                 |  2 +-
hw/nvram/meson.build        |  3 +++
4 files changed, 19 insertions(+), 8 deletions(-)
create mode 100644 hw/nvram/fw_cfg-interface.c

Expand all Fold all

[PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

Attempt to fix the issue reported by Kevin.

Since v2:
- Rename function (lersek)

Since RFC(v1):
- Keep it local to hw/nvram (danpb)
- Based on Meson cleanup

Based-on: <20201006125602.2311423-1-philmd@redhat.com>

Base is available in the Git repository at:

  https://gitlab.com/philmd/qemu.git branches/meson_libraries_consistency

Philippe Mathieu-Daudé (1):
  hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE

 hw/nvram/fw_cfg-interface.c | 15 +++++++++++++++
 hw/nvram/fw_cfg.c           |  7 -------
 MAINTAINERS                 |  2 +-
 hw/nvram/meson.build        |  3 +++
 4 files changed, 19 insertions(+), 8 deletions(-)
 create mode 100644 hw/nvram/fw_cfg-interface.c

-- 
2.26.2

Re: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

Posted by no-reply@patchew.org 3 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20201006153636.2383248-1-philmd@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201006153636.2383248-1-philmd@redhat.com
Subject: [PATCH v3 0/1] qom: Fix missing interface in qemu-storage-daemon

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20201006153636.2383248-1-philmd@redhat.com -> patchew/20201006153636.2383248-1-philmd@redhat.com
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly
Traceback (most recent call last):
  File "patchew-tester2/src/patchew-cli", line 531, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester2/src/patchew-cli", line 62, in git_clone_repo
    subprocess.check_call(clone_cmd, stderr=logf, stdout=logf)
  File "/opt/rh/rh-python36/root/usr/lib64/python3.6/subprocess.py", line 291, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'clone', '-q', '/home/patchew2/.cache/patchew-git-cache/httpsgithubcompatchewprojectqemu-3c8cf5a9c21ff8782164d1def7f44bd888713384', '/var/tmp/patchew-tester-tmp-ttyqifjv/src']' returned non-zero exit status 128.



The full log is available at
http://patchew.org/logs/20201006153636.2383248-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com