[PATCH v5 00/11] i440fx/acpi: addition of feature and bug fixes.

Ani Sinha posted 11 patches 4 days ago
Failed in applying to current master (apply log)
hw/acpi/pcihp.c                   |  15 +++++++++
hw/acpi/piix4.c                   |   6 ++--
hw/i386/acpi-build.c              |  37 ++++++++++++++--------
tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
tests/qtest/bios-tables-test.c    |  49 ++++++++++++++++++++++++++++++
17 files changed, 92 insertions(+), 15 deletions(-)
create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
create mode 100644 tests/data/acpi/pc/DSDT.roothp

[PATCH v5 00/11] i440fx/acpi: addition of feature and bug fixes.

Posted by Ani Sinha 4 days ago
In v5, I have tried to address all the latest review comments in commit logs
and in patches. Also added "Reviewed-by" and "Acked-by" tags when a particular
patch was already reviewed.

Unit tests pass when the patch series is applied on top of the latest qemu master
branch.

Disassembly of DSDT table is here:  https://pastebin.ubuntu.com/p/WvpYYjpPN8/
when pci hotplug is turned off globally.


Ani Sinha (11):
  tests/acpi: document addition of table DSDT.roothp for unit testing
    root pci hotplug on/off
  tests/acpi: add a new unit test to test hotplug off/on feature on the
    root pci bus
  tests/acpi: add a new ACPI table in order to test root pci hotplug
    on/off
  Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
    non-hotpluggable bus
  i440fx/acpi: do not add hotplug related amls for cold plugged bridges
  tests/acpi: list added acpi table binary file for pci bridge hotplug
    test
  tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
    bridge flag
  tests/acpi: add newly added acpi DSDT table blob for pci bridge
    hotplug flag
  piix4: don't reserve hw resources when hotplug is off globally
  tests/acpi: unit test exercising hotplug off for pci root bus & bridge
    in i440fx
  tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx
    hotplug

 hw/acpi/pcihp.c                   |  15 +++++++++
 hw/acpi/piix4.c                   |   6 ++--
 hw/i386/acpi-build.c              |  37 ++++++++++++++--------
 tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
 tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
 tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
 tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
 tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
 tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
 tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
 tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
 tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
 tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
 tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
 tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
 tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
 tests/qtest/bios-tables-test.c    |  49 ++++++++++++++++++++++++++++++
 17 files changed, 92 insertions(+), 15 deletions(-)
 create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
 create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
 create mode 100644 tests/data/acpi/pc/DSDT.roothp

-- 
2.17.1


Re: [PATCH v5 00/11] i440fx/acpi: addition of feature and bug fixes.

Posted by Igor Mammedov 3 days ago
On Wed, 16 Sep 2020 13:48:59 +0530
Ani Sinha <ani@anisinha.ca> wrote:

> In v5, I have tried to address all the latest review comments in commit logs
> and in patches. Also added "Reviewed-by" and "Acked-by" tags when a particular
> patch was already reviewed.

points that weren't addressed in this version across whole series:

(1)
s/amls/ACPI code/
(2)
make commit message fit in 80crl/line limit (modulo diffs).

so pls fix that before re-spinning (including already acked patches)

> Unit tests pass when the patch series is applied on top of the latest qemu master
> branch.
> 
> Disassembly of DSDT table is here:  https://pastebin.ubuntu.com/p/WvpYYjpPN8/
> when pci hotplug is turned off globally.
> 
> 
> Ani Sinha (11):
>   tests/acpi: document addition of table DSDT.roothp for unit testing
>     root pci hotplug on/off
>   tests/acpi: add a new unit test to test hotplug off/on feature on the
>     root pci bus
>   tests/acpi: add a new ACPI table in order to test root pci hotplug
>     on/off
>   Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
>     non-hotpluggable bus
>   i440fx/acpi: do not add hotplug related amls for cold plugged bridges
>   tests/acpi: list added acpi table binary file for pci bridge hotplug
>     test
>   tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
>     bridge flag
>   tests/acpi: add newly added acpi DSDT table blob for pci bridge
>     hotplug flag
>   piix4: don't reserve hw resources when hotplug is off globally
>   tests/acpi: unit test exercising hotplug off for pci root bus & bridge
>     in i440fx
>   tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx
>     hotplug
> 
>  hw/acpi/pcihp.c                   |  15 +++++++++
>  hw/acpi/piix4.c                   |   6 ++--
>  hw/i386/acpi-build.c              |  37 ++++++++++++++--------
>  tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
>  tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
>  tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
>  tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
>  tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
>  tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
>  tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
>  tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
>  tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
>  tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
>  tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
>  tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
>  tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
>  tests/qtest/bios-tables-test.c    |  49 ++++++++++++++++++++++++++++++
>  17 files changed, 92 insertions(+), 15 deletions(-)
>  create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
>  create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
>  create mode 100644 tests/data/acpi/pc/DSDT.roothp
>