[PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.

Ani Sinha posted 13 patches 3 years, 6 months ago
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200918084111.15339-1-ani@anisinha.ca
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <rth@twiddle.net>, Aurelien Jarno <aurelien@aurel32.net>, Igor Mammedov <imammedo@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
hw/acpi/pcihp.c                   |  15 +++++++++
hw/acpi/piix4.c                   |   6 ++--
hw/i386/acpi-build.c              |  37 ++++++++++++++--------
tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
tests/qtest/bios-tables-test.c    |  49 ++++++++++++++++++++++++++++++
17 files changed, 92 insertions(+), 15 deletions(-)
create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
create mode 100644 tests/data/acpi/pc/DSDT.roothp
[PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.
Posted by Ani Sinha 3 years, 6 months ago
Final patch series with all the patches reviewed or ack'd and marked as such.
Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon.

--Ani

Ani Sinha (13):
  tests/acpi: mark addition of table DSDT.roothp for unit testing root
    pci hotplug
  tests/acpi: add new unit test to test hotplug off/on feature on the
    root pci bus
  tests/acpi: add a new ACPI table in order to test root pci hotplug
    on/off
  Fix a gap where acpi_pcihp_find_hotplug_bus() returns a
    non-hotpluggable bus
  i440fx/acpi: do not add hotplug related amls for cold plugged bridges
  tests/acpi: list added acpi table binary file for pci bridge hotplug
    test
  tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support'
    bridge flag
  tests/acpi: add newly added acpi DSDT table blob for pci bridge
    hotplug flag
  Add ACPI DSDT tables for q35 that are being updated by the next patch
  piix4: don't reserve hw resources when hotplug is off globally
  tests/acpi: update golden master DSDT binary table blobs for q35
  tests/acpi: unit test exercising global pci hotplug off for i440fx
  tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx
    hotplug

 hw/acpi/pcihp.c                   |  15 +++++++++
 hw/acpi/piix4.c                   |   6 ++--
 hw/i386/acpi-build.c              |  37 ++++++++++++++--------
 tests/data/acpi/pc/DSDT.hpbridge  | Bin 0 -> 4895 bytes
 tests/data/acpi/pc/DSDT.hpbrroot  | Bin 0 -> 2953 bytes
 tests/data/acpi/pc/DSDT.roothp    | Bin 0 -> 5130 bytes
 tests/data/acpi/q35/DSDT          | Bin 7678 -> 7670 bytes
 tests/data/acpi/q35/DSDT.acpihmat | Bin 9002 -> 8994 bytes
 tests/data/acpi/q35/DSDT.bridge   | Bin 7695 -> 7688 bytes
 tests/data/acpi/q35/DSDT.cphp     | Bin 8141 -> 8133 bytes
 tests/data/acpi/q35/DSDT.dimmpxm  | Bin 9331 -> 9323 bytes
 tests/data/acpi/q35/DSDT.ipmibt   | Bin 7753 -> 7745 bytes
 tests/data/acpi/q35/DSDT.memhp    | Bin 9037 -> 9029 bytes
 tests/data/acpi/q35/DSDT.mmio64   | Bin 8808 -> 8801 bytes
 tests/data/acpi/q35/DSDT.numamem  | Bin 7684 -> 7676 bytes
 tests/data/acpi/q35/DSDT.tis      | Bin 8283 -> 8276 bytes
 tests/qtest/bios-tables-test.c    |  49 ++++++++++++++++++++++++++++++
 17 files changed, 92 insertions(+), 15 deletions(-)
 create mode 100644 tests/data/acpi/pc/DSDT.hpbridge
 create mode 100644 tests/data/acpi/pc/DSDT.hpbrroot
 create mode 100644 tests/data/acpi/pc/DSDT.roothp

-- 
2.17.1


Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.
Posted by Philippe Mathieu-Daudé 3 years, 6 months ago
On 9/18/20 10:40 AM, Ani Sinha wrote:
> Final patch series with all the patches reviewed or ack'd and marked as such.
> Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon.

FYI there is no need to collect tags on the final version.
Tools already do that for you, see:
https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/

The maintainer can import the patches with the proper Message-Id /
Reviewed-by / Acked-by / Tested-by tags added using:
https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox

Regards,

Phil.


Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.
Posted by Ani Sinha 3 years, 6 months ago
On Fri, Sep 18, 2020 at 3:26 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> On 9/18/20 10:40 AM, Ani Sinha wrote:
> > Final patch series with all the patches reviewed or ack'd and marked as such.
> > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon.
>
> FYI there is no need to collect tags on the final version.
> Tools already do that for you, see:
> https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/
>
> The maintainer can import the patches with the proper Message-Id /
> Reviewed-by / Acked-by / Tested-by tags added using:
> https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox

Interesting!

>
> Regards,
>
> Phil.
>

Re: [PATCH v10 00/13] i440fx/acpi: addition of feature and bug fixes.
Posted by Michael S. Tsirkin 3 years, 6 months ago
On Fri, Sep 18, 2020 at 11:55:54AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/18/20 10:40 AM, Ani Sinha wrote:
> > Final patch series with all the patches reviewed or ack'd and marked as such.
> > Thanks Julia and Igor for the reviews. Hope this series gets pulled in soon.
> 
> FYI there is no need to collect tags on the final version.

Right but if a new version is posted then yes you want to
include tags.

> Tools already do that for you, see:
> https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/
> 
> The maintainer can import the patches with the proper Message-Id /
> Reviewed-by / Acked-by / Tested-by tags added using:
> https://patchew.org/QEMU/20200918072325.9933-1-ani@anisinha.ca/mbox
> 
> Regards,
> 
> Phil.