[PATCH v2 00/12] target/microblaze improvements

Richard Henderson posted 12 patches 5 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200903072650.1360454-1-richard.henderson@linaro.org
Test docker-quick@centos7 failed
Test docker-mingw@fedora failed
Test checkpatch failed
Test FreeBSD failed
Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
There is a newer version of this series
target/microblaze/cpu.h       |  11 +-
target/microblaze/mmu.h       |  15 +--
target/microblaze/cpu.c       |  19 +--
target/microblaze/helper.c    | 216 +++++++++++++++-------------------
target/microblaze/machine.c   | 112 ++++++++++++++++++
target/microblaze/mmu.c       |  11 +-
target/microblaze/translate.c | 166 ++++++++++++++++++--------
target/microblaze/meson.build |   5 +-
8 files changed, 362 insertions(+), 193 deletions(-)
create mode 100644 target/microblaze/machine.c
[PATCH v2 00/12] target/microblaze improvements
Posted by Richard Henderson 5 years, 2 months ago
Version 2 includes fixes for iflags that could cause lockups.

It seems it was easier to do so with icount=7, which is what we do during
the replay acceptance tests.  This causes TBs to contain no more than 7
insns, and often less to make up for an incomplete count elsewhere.
Which stressed the iflags bits around delay slots and imm in ways that
pure single-step doesn't.

In addition, cpu vmstate is filled in and interrupt logging is tidied.


r~


Richard Henderson (12):
  target/microblaze: Collected fixes for env->iflags
  target/microblaze: Renumber D_FLAG
  target/microblaze: Cleanup mb_cpu_do_interrupt
  target/microblaze: Rename mmu structs
  target/microblaze: Fill in VMStateDescription for cpu
  target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT
  target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP
  target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT
  target/microblaze: Handle DISAS_EXIT_NEXT in delay slot
  target/microblaze: Force rtid, rted, rtbd to exit
  target/microblaze: Use tcg_gen_lookup_and_goto_ptr
  target/microblaze: Diagnose invalid insns in delay slots

 target/microblaze/cpu.h       |  11 +-
 target/microblaze/mmu.h       |  15 +--
 target/microblaze/cpu.c       |  19 +--
 target/microblaze/helper.c    | 216 +++++++++++++++-------------------
 target/microblaze/machine.c   | 112 ++++++++++++++++++
 target/microblaze/mmu.c       |  11 +-
 target/microblaze/translate.c | 166 ++++++++++++++++++--------
 target/microblaze/meson.build |   5 +-
 8 files changed, 362 insertions(+), 193 deletions(-)
 create mode 100644 target/microblaze/machine.c

-- 
2.25.1


Re: [PATCH v2 00/12] target/microblaze improvements
Posted by Thomas Huth 5 years, 2 months ago
On 03/09/2020 09.26, Richard Henderson wrote:
> Version 2 includes fixes for iflags that could cause lockups.
> 
> It seems it was easier to do so with icount=7, which is what we do during
> the replay acceptance tests.  This causes TBs to contain no more than 7
> insns, and often less to make up for an incomplete count elsewhere.
> Which stressed the iflags bits around delay slots and imm in ways that
> pure single-step doesn't.
> 
> In addition, cpu vmstate is filled in and interrupt logging is tidied.

Thanks, this fixes the failing acceptance test in the Gitlab-CI for me:

 https://gitlab.com/huth/qemu/-/pipelines/185245009

Tested-by: Thomas Huth <thuth@redhat.com>