[PATCH v3 0/7] hw/misc: Add LED device

Philippe Mathieu-Daudé posted 7 patches 3 years, 11 months ago
Test FreeBSD passed
Test asan passed
Test docker-quick@centos7 failed
Test checkpatch passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200620230719.32139-1-f4bug@amsat.org
There is a newer version of this series
include/hw/misc/led.h         | 100 ++++++++++++++++++++++
include/hw/misc/mps2-fpgaio.h |   1 +
include/hw/misc/mps2-scc.h    |   1 +
hw/arm/aspeed.c               |  17 ++++
hw/arm/tosa.c                 |  40 +++------
hw/misc/led.c                 | 151 ++++++++++++++++++++++++++++++++++
hw/misc/mps2-fpgaio.c         |  13 +--
hw/misc/mps2-scc.c            |  23 +++---
MAINTAINERS                   |   6 ++
hw/arm/Kconfig                |   2 +
hw/misc/Kconfig               |   5 ++
hw/misc/Makefile.objs         |   1 +
hw/misc/trace-events          |   6 +-
13 files changed, 321 insertions(+), 45 deletions(-)
create mode 100644 include/hw/misc/led.h
create mode 100644 hw/misc/led.c
[PATCH v3 0/7] hw/misc: Add LED device
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
Hello,

These patches are part of the GSoC unselected 'QEMU visualizer'
project.  As the AVR port is not merged, I switched to microbit
to keep working on it.

This series presents a proof of concept of LED device that can
be easily connected to a GPIO.

Since v2:
- Rebased on PCA9552
- Model intensity to be ready for PWM use (Dave)
- Remove QMP events until we get a UI visualizer (Peter)
- Remove microbit patch (Peter)

Since v1: addressed Eric Blake review comments
- Added QMP rate limit

Next steps planned:

- PoC visualizer...
- look at using a dbus backend (elmarco)
- look at LED array/matrix such 7segments.

Regards,

Phil.

Based-on: <20200620225854.31160-1-f4bug@amsat.org>

Philippe Mathieu-Daudé (7):
  hw/misc: Add a LED device
  hw/misc/led: Add helper to connect LED to GPIO output
  hw/misc/led: Emit a trace event when LED intensity has changed
  hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
  hw/misc/mps2-fpgaio: Use the LED device
  hw/misc/mps2-scc: Use the LED device
  hw/arm/tosa: Replace fprintf() calls by LED devices

 include/hw/misc/led.h         | 100 ++++++++++++++++++++++
 include/hw/misc/mps2-fpgaio.h |   1 +
 include/hw/misc/mps2-scc.h    |   1 +
 hw/arm/aspeed.c               |  17 ++++
 hw/arm/tosa.c                 |  40 +++------
 hw/misc/led.c                 | 151 ++++++++++++++++++++++++++++++++++
 hw/misc/mps2-fpgaio.c         |  13 +--
 hw/misc/mps2-scc.c            |  23 +++---
 MAINTAINERS                   |   6 ++
 hw/arm/Kconfig                |   2 +
 hw/misc/Kconfig               |   5 ++
 hw/misc/Makefile.objs         |   1 +
 hw/misc/trace-events          |   6 +-
 13 files changed, 321 insertions(+), 45 deletions(-)
 create mode 100644 include/hw/misc/led.h
 create mode 100644 hw/misc/led.c

-- 
2.21.3


Re: [PATCH v3 0/7] hw/misc: Add LED device
Posted by no-reply@patchew.org 3 years, 11 months ago
Patchew URL: https://patchew.org/QEMU/20200620230719.32139-1-f4bug@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TEST    iotest-qcow2: 143
  TEST    iotest-qcow2: 150
**
ERROR:/tmp/qemu-test/src/hw/core/qdev.c:1074:device_finalize: assertion failed: (dev->canonical_path)
Broken pipe
/tmp/qemu-test/src/tests/qtest/libqtest.c:175: kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)
ERROR - too few tests run (expected 6, got 5)
make: *** [check-qtest-aarch64] Error 1
make: *** Waiting for unfinished jobs....
  TEST    iotest-qcow2: 154
  TEST    iotest-qcow2: 156
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=33590eb6142241b28b0d323737d99da2', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-0uwqudqi/src/docker-src.2020-06-20-19.46.06.26129:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=33590eb6142241b28b0d323737d99da2
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-0uwqudqi/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    12m38.919s
user    0m8.142s


The full log is available at
http://patchew.org/logs/20200620230719.32139-1-f4bug@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com