[v6] hw/misc: Add LED device

[PATCH v6 0/7] hw/misc: Add LED device

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

Hello,

These patches are part of the GSoC unselected 'QEMU visualizer'
project.

This series introduce a LED device that can be easily connected
to a GPIO output.

Missing review:
- Patch #2: "hw/misc/led: Allow connecting from GPIO output"

Since v5:
- Rebased on "QOM boilerplate cleanup" (use DECLARE_INSTANCE_CHECKER)
- Addressed Luc and Richard comments
- Do not use confusing "polarity-inverted" property
- Reset LEDs in MPS2 devices
- Document GpioPolarity

Since v4:
- Fixed typos (Luc)
- Removed TYPE_TOSA_MISC_GPIO qdev conversion patch (Peter)

Since v3:
- Rebased (TYPE_TOSA_MISC_GPIO)
- Rebased (Meson)
- Addressed Richard's review comments
- Improved doc/comments

Since v2:
- Rebased on PCA9552
- Model intensity to be ready for PWM use (Dave)
- Remove QMP events until we get a UI visualizer (Peter)
- Remove microbit patch (Peter)

Since v1: addressed Eric Blake review comments
- Added QMP rate limit

Next steps planned:

- PoC visualizer...
- look at using a dbus backend (elmarco)
- look at LED array/matrix such 7segments.

Regards,

Phil.

$ git backport-diff -r v6.. -u v5
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respective=
ly

001/7:[0013] [FC] 'hw/misc/led: Add a LED device'
002/7:[0026] [FC] 'hw/misc/led: Allow connecting from GPIO output'
003/7:[----] [--] 'hw/misc/led: Emit a trace event when LED intensity has cha=
nged'
004/7:[----] [--] 'hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 =
#1'
005/7:[0004] [FC] 'hw/misc/mps2-fpgaio: Use the LED device'
006/7:[0004] [FC] 'hw/misc/mps2-scc: Use the LED device'
007/7:[----] [-C] 'hw/arm/tosa: Replace fprintf() calls by LED devices'

Philippe Mathieu-Daud=C3=A9 (7):
  hw/misc/led: Add a LED device
  hw/misc/led: Allow connecting from GPIO output
  hw/misc/led: Emit a trace event when LED intensity has changed
  hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
  hw/misc/mps2-fpgaio: Use the LED device
  hw/misc/mps2-scc: Use the LED device
  hw/arm/tosa: Replace fprintf() calls by LED devices

 include/hw/misc/led.h         |  97 ++++++++++++++++++++
 include/hw/misc/mps2-fpgaio.h |   2 +
 include/hw/misc/mps2-scc.h    |   2 +
 include/hw/qdev-core.h        |  16 ++++
 hw/arm/aspeed.c               |  20 +++++
 hw/arm/tosa.c                 |  40 ++++-----
 hw/misc/led.c                 | 161 ++++++++++++++++++++++++++++++++++
 hw/misc/mps2-fpgaio.c         |  23 +++--
 hw/misc/mps2-scc.c            |  27 +++---
 MAINTAINERS                   |   6 ++
 hw/arm/Kconfig                |   2 +
 hw/misc/Kconfig               |   5 ++
 hw/misc/meson.build           |   1 +
 hw/misc/trace-events          |   6 +-
 14 files changed, 365 insertions(+), 43 deletions(-)
 create mode 100644 include/hw/misc/led.h
 create mode 100644 hw/misc/led.c

--=20
2.26.2

Re: [PATCH v6 0/7] hw/misc: Add LED device

Posted by no-reply@patchew.org 3 years, 7 months ago

Patchew URL: https://patchew.org/QEMU/20200912134041.946260-1-f4bug@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.






The full log is available at
http://patchew.org/logs/20200912134041.946260-1-f4bug@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH v6 0/7] hw/misc: Add LED device

Posted by Philippe Mathieu-Daudé 3 years, 7 months ago

On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote:
> Hello,
> 
> These patches are part of the GSoC unselected 'QEMU visualizer'
> project.
> 
> This series introduce a LED device that can be easily connected
> to a GPIO output.
[...]
> Philippe Mathieu-Daud=C3=A9 (7):
>   hw/misc/led: Add a LED device
>   hw/misc/led: Allow connecting from GPIO output
>   hw/misc/led: Emit a trace event when LED intensity has changed
>   hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
>   hw/misc/mps2-fpgaio: Use the LED device
>   hw/misc/mps2-scc: Use the LED device
>   hw/arm/tosa: Replace fprintf() calls by LED devices

This series is now fully reviewed.

Peter, since so far only ARM boards use the LED device,
do you mind queuing it via your ARM tree?

Alternatively I can ask Paolo or send a pull request
myself is both of you think it is out of the scope of
your maintenance area.

Thanks,

Phil.

Re: [PATCH v6 0/7] hw/misc: Add LED device

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

Hi Cédric,

On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote:
> On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote:
>> Hello,
>>
>> These patches are part of the GSoC unselected 'QEMU visualizer'
>> project.
>>
>> This series introduce a LED device that can be easily connected
>> to a GPIO output.
> [...]
>> Philippe Mathieu-Daud=C3=A9 (7):
>>    hw/misc/led: Add a LED device
>>    hw/misc/led: Allow connecting from GPIO output
>>    hw/misc/led: Emit a trace event when LED intensity has changed
>>    hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
>>    hw/misc/mps2-fpgaio: Use the LED device
>>    hw/misc/mps2-scc: Use the LED device
>>    hw/arm/tosa: Replace fprintf() calls by LED devices
> 
> This series is now fully reviewed.

Since the Aspeed board is the main user, do you mind
taking this series via your aspeed tree?

> 
> Peter, since so far only ARM boards use the LED device,
> do you mind queuing it via your ARM tree?
> 
> Alternatively I can ask Paolo or send a pull request
> myself is both of you think it is out of the scope of
> your maintenance area.
> 
> Thanks,
> 
> Phil.
>

Re: [PATCH v6 0/7] hw/misc: Add LED device

Posted by Philippe Mathieu-Daudé 3 years, 5 months ago

On 10/16/20 5:29 PM, Philippe Mathieu-Daudé wrote:
> On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote:
>> On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote:
>>> Hello,
>>>
>>> These patches are part of the GSoC unselected 'QEMU visualizer'
>>> project.
>>>
>>> This series introduce a LED device that can be easily connected
>>> to a GPIO output.
>> [...]
>>> Philippe Mathieu-Daud=C3=A9 (7):
>>>    hw/misc/led: Add a LED device
>>>    hw/misc/led: Allow connecting from GPIO output
>>>    hw/misc/led: Emit a trace event when LED intensity has changed
>>>    hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
>>>    hw/misc/mps2-fpgaio: Use the LED device
>>>    hw/misc/mps2-scc: Use the LED device
>>>    hw/arm/tosa: Replace fprintf() calls by LED devices
>>
>> This series is now fully reviewed.

As soft-freeze is tomorrow, I'll go ahead and send a pull request.

Thanks,

Phil.

Re: [PATCH v6 0/7] hw/misc: Add LED device

Posted by Cédric Le Goater 3 years, 5 months ago

On 10/26/20 11:00 PM, Philippe Mathieu-Daudé wrote:
> On 10/16/20 5:29 PM, Philippe Mathieu-Daudé wrote:
>> On 9/19/20 2:30 PM, Philippe Mathieu-Daudé wrote:
>>> On 9/12/20 3:40 PM, Philippe Mathieu-Daudé wrote:
>>>> Hello,
>>>>
>>>> These patches are part of the GSoC unselected 'QEMU visualizer'
>>>> project.
>>>>
>>>> This series introduce a LED device that can be easily connected
>>>> to a GPIO output.
>>> [...]
>>>> Philippe Mathieu-Daud=C3=A9 (7):
>>>>    hw/misc/led: Add a LED device
>>>>    hw/misc/led: Allow connecting from GPIO output
>>>>    hw/misc/led: Emit a trace event when LED intensity has changed
>>>>    hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1
>>>>    hw/misc/mps2-fpgaio: Use the LED device
>>>>    hw/misc/mps2-scc: Use the LED device
>>>>    hw/arm/tosa: Replace fprintf() calls by LED devices
>>>
>>> This series is now fully reviewed.
> 
> As soft-freeze is tomorrow, I'll go ahead and send a pull request.

You did well. I was out for a couple of weeks.

Thanks,

C.