[v1] decodetree: Add non-overlapping groups

[PULL 0/9] decodetree: Add non-overlapping groups

Richard Henderson posted 9 patches 3 years, 10 months ago

Diff against v1 v2 v3
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200609162504.780080-1-richard.henderson@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>, Cleber Rosa <crosa@redhat.com>

There is a newer version of this series

target/arm/t32.decode                        |   4 +-
tests/decode/err_pattern_group_nest1.decode  |  11 +-
tests/decode/err_pattern_group_nest2.decode  |   6 +
tests/decode/err_pattern_group_nest3.decode  |  14 +
tests/decode/succ_pattern_group_nest2.decode |  13 +
tests/decode/succ_pattern_group_nest3.decode |  11 +
tests/decode/succ_pattern_group_nest4.decode |  13 +
scripts/decodetree.py                        | 513 +++++++++++++++------------
8 files changed, 360 insertions(+), 225 deletions(-)
create mode 100644 tests/decode/err_pattern_group_nest2.decode
create mode 100644 tests/decode/err_pattern_group_nest3.decode
create mode 100644 tests/decode/succ_pattern_group_nest2.decode
create mode 100644 tests/decode/succ_pattern_group_nest3.decode
create mode 100644 tests/decode/succ_pattern_group_nest4.decode

Expand all Fold all

[PULL 0/9] decodetree: Add non-overlapping groups

Posted by Richard Henderson 3 years, 10 months ago

The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2:

  Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-dt-20200609

for you to fetch changes up to d6084fba47bb9aef79775c1102d4b647eb58c365:

  target/arm: Use a non-overlapping group for misc control (2020-06-09 09:21:19 -0700)

----------------------------------------------------------------
Add non-overlapping groups

----------------------------------------------------------------
Richard Henderson (9):
      decodetree: Tidy error_with_file
      decodetree: Rename MultiPattern to IncMultiPattern
      decodetree: Split out MultiPattern from IncMultiPattern
      decodetree: Allow group covering the entire insn space
      decodetree: Move semantic propagation into classes
      decodetree: Implement non-overlapping groups
      tests/decode: Test non-overlapping groups
      decodetree: Drop check for less than 2 patterns in a group
      target/arm: Use a non-overlapping group for misc control

 target/arm/t32.decode                        |   4 +-
 tests/decode/err_pattern_group_nest1.decode  |  11 +-
 tests/decode/err_pattern_group_nest2.decode  |   6 +
 tests/decode/err_pattern_group_nest3.decode  |  14 +
 tests/decode/succ_pattern_group_nest2.decode |  13 +
 tests/decode/succ_pattern_group_nest3.decode |  11 +
 tests/decode/succ_pattern_group_nest4.decode |  13 +
 scripts/decodetree.py                        | 513 +++++++++++++++------------
 8 files changed, 360 insertions(+), 225 deletions(-)
 create mode 100644 tests/decode/err_pattern_group_nest2.decode
 create mode 100644 tests/decode/err_pattern_group_nest3.decode
 create mode 100644 tests/decode/succ_pattern_group_nest2.decode
 create mode 100644 tests/decode/succ_pattern_group_nest3.decode
 create mode 100644 tests/decode/succ_pattern_group_nest4.decode

Re: [PULL 0/9] decodetree: Add non-overlapping groups

Posted by Peter Maydell 3 years, 9 months ago

On Tue, 9 Jun 2020 at 17:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
> ----------------------------------------------------------------
> Add non-overlapping groups
>
> ----------------------------------------------------------------
> Richard Henderson (9):
>       decodetree: Tidy error_with_file
>       decodetree: Rename MultiPattern to IncMultiPattern
>       decodetree: Split out MultiPattern from IncMultiPattern
>       decodetree: Allow group covering the entire insn space
>       decodetree: Move semantic propagation into classes
>       decodetree: Implement non-overlapping groups
>       tests/decode: Test non-overlapping groups
>       decodetree: Drop check for less than 2 patterns in a group
>       target/arm: Use a non-overlapping group for misc control
>
>  target/arm/t32.decode                        |   4 +-
>  tests/decode/err_pattern_group_nest1.decode  |  11 +-
>  tests/decode/err_pattern_group_nest2.decode  |   6 +
>  tests/decode/err_pattern_group_nest3.decode  |  14 +
>  tests/decode/succ_pattern_group_nest2.decode |  13 +
>  tests/decode/succ_pattern_group_nest3.decode |  11 +
>  tests/decode/succ_pattern_group_nest4.decode |  13 +
>  scripts/decodetree.py                        | 513 +++++++++++++++------------

Hi, Richard. I've just noticed that when we added non-overlapping
group support to decodetree we forgot to update docs/devel/decodetree.rst,
which still thinks the only kind of group is the overlapping kind.
Any chance of a patch to update the docs?

thanks
-- PMM

Re: [PULL 0/9] decodetree: Add non-overlapping groups

Posted by Peter Maydell 3 years, 10 months ago

On Tue, 9 Jun 2020 at 17:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2:
>
>   Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging (2020-06-08 11:04:57 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/rth7680/qemu.git tags/pull-dt-20200609
>
> for you to fetch changes up to d6084fba47bb9aef79775c1102d4b647eb58c365:
>
>   target/arm: Use a non-overlapping group for misc control (2020-06-09 09:21:19 -0700)
>
> ----------------------------------------------------------------
> Add non-overlapping groups
>
> ----------------------------------------------------------------


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM