[PATCH v3 0/9] decodetree: Add non-overlapping groups

Richard Henderson posted 9 patches 3 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200608183652.661386-1-richard.henderson@linaro.org
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Maintainers: Cleber Rosa <crosa@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Richard Henderson <rth@twiddle.net>, Paolo Bonzini <pbonzini@redhat.com>
target/arm/t32.decode                        |   4 +-
tests/decode/err_pattern_group_nest1.decode  |  11 +-
tests/decode/err_pattern_group_nest2.decode  |   6 +
tests/decode/err_pattern_group_nest3.decode  |  14 +
tests/decode/succ_pattern_group_nest2.decode |  13 +
tests/decode/succ_pattern_group_nest3.decode |  11 +
tests/decode/succ_pattern_group_nest4.decode |  13 +
scripts/decodetree.py                        | 513 +++++++++++--------
8 files changed, 360 insertions(+), 225 deletions(-)
create mode 100644 tests/decode/err_pattern_group_nest2.decode
create mode 100644 tests/decode/err_pattern_group_nest3.decode
create mode 100644 tests/decode/succ_pattern_group_nest2.decode
create mode 100644 tests/decode/succ_pattern_group_nest3.decode
create mode 100644 tests/decode/succ_pattern_group_nest4.decode
[PATCH v3 0/9] decodetree: Add non-overlapping groups
Posted by Richard Henderson 3 years, 10 months ago
This is a feature that Peter requested for completing the
neon decodetree conversion.

Changes for v3:
  - Remove check for less than 2 patterns in a group.

Changes for v2:
  - Rebase on master, which includes some generic python cleanups.
  - Indentation error message restored.
  - 4 new testcases

Peter, do you want me to include the final patch in any
decodetree pull request, or shall I leave that for you
to pick up through the target-arm.next tree?


r~


Richard Henderson (9):
  decodetree: Tidy error_with_file
  decodetree: Rename MultiPattern to IncMultiPattern
  decodetree: Split out MultiPattern from IncMultiPattern
  decodetree: Allow group covering the entire insn space
  decodetree: Move semantic propagation into classes
  decodetree: Implement non-overlapping groups
  tests/decode: Test non-overlapping groups
  decodetree: Drop check for less than 2 patterns in a group
  target/arm: Use a non-overlapping group for misc control

 target/arm/t32.decode                        |   4 +-
 tests/decode/err_pattern_group_nest1.decode  |  11 +-
 tests/decode/err_pattern_group_nest2.decode  |   6 +
 tests/decode/err_pattern_group_nest3.decode  |  14 +
 tests/decode/succ_pattern_group_nest2.decode |  13 +
 tests/decode/succ_pattern_group_nest3.decode |  11 +
 tests/decode/succ_pattern_group_nest4.decode |  13 +
 scripts/decodetree.py                        | 513 +++++++++++--------
 8 files changed, 360 insertions(+), 225 deletions(-)
 create mode 100644 tests/decode/err_pattern_group_nest2.decode
 create mode 100644 tests/decode/err_pattern_group_nest3.decode
 create mode 100644 tests/decode/succ_pattern_group_nest2.decode
 create mode 100644 tests/decode/succ_pattern_group_nest3.decode
 create mode 100644 tests/decode/succ_pattern_group_nest4.decode

-- 
2.25.1


Re: [PATCH v3 0/9] decodetree: Add non-overlapping groups
Posted by Peter Maydell 3 years, 10 months ago
On Mon, 8 Jun 2020 at 19:36, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> This is a feature that Peter requested for completing the
> neon decodetree conversion.
>
> Changes for v3:
>   - Remove check for less than 2 patterns in a group.
>
> Changes for v2:
>   - Rebase on master, which includes some generic python cleanups.
>   - Indentation error message restored.
>   - 4 new testcases
>
> Peter, do you want me to include the final patch in any
> decodetree pull request, or shall I leave that for you
> to pick up through the target-arm.next tree?

I think it's probably easier if you put the whole set into
a decodetree pullreq. I'm still a fair way from having the
next neon-conversion patchset ready to send out for review,
so if the set goes into master before then that would be
most convenient.

thanks
-- PMM