[v3] drop unallocated_blocks_are_zero

[PATCH v3 00/10] drop unallocated_blocks_are_zero

Vladimir Sementsov-Ogievskiy posted 10 patches 5 years, 5 months ago

Diff against v1 v2
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200528094405.145708-1-vsementsov@virtuozzo.com

Maintainers: Max Reitz <mreitz@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Peter Lieven <pl@kamp.de>, Stefan Weil <sw@weilnetz.de>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Jeff Cody <codyprime@gmail.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>

block/qed.h               |  1 -
include/block/block.h     |  6 ----
include/block/block_int.h | 12 +++++++-
block.c                   | 15 ---------
block/crypto.c            |  1 -
block/file-posix.c        |  3 --
block/io.c                |  8 ++---
block/iscsi.c             |  1 -
block/qcow2.c             |  1 -
block/qed.c               | 65 ++++-----------------------------------
block/vdi.c               |  3 +-
block/vhdx.c              |  3 --
block/vpc.c               |  3 +-
qemu-img.c                |  4 +--
14 files changed, 24 insertions(+), 102 deletions(-)

Expand all Fold all

[PATCH v3 00/10] drop unallocated_blocks_are_zero

Posted by Vladimir Sementsov-Ogievskiy 5 years, 5 months ago

This is first step to block-status refactoring, and solves most simple
problem mentioned in my investigation of block-status described in
the thread "backing chain & block status & filters":
  https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html

The whole series is reviewed, let's proceed with it please!

v3: rebase on master
02: grammar fix in commit msg, add Eric's r-b
03,04,09: add Eric's r-b
10: add my r-b

Eric Blake (1):
  qed: Simplify backing reads

Vladimir Sementsov-Ogievskiy (9):
  qemu-img: convert: don't use unallocated_blocks_are_zero
  block: inline bdrv_unallocated_blocks_are_zero()
  block/vdi: return ZERO block-status when appropriate
  block/vpc: return ZERO block-status when appropriate
  block/crypto: drop unallocated_blocks_are_zero
  block/iscsi: drop unallocated_blocks_are_zero
  block/file-posix: drop unallocated_blocks_are_zero
  block/vhdx: drop unallocated_blocks_are_zero
  block: drop unallocated_blocks_are_zero

 block/qed.h               |  1 -
 include/block/block.h     |  6 ----
 include/block/block_int.h | 12 +++++++-
 block.c                   | 15 ---------
 block/crypto.c            |  1 -
 block/file-posix.c        |  3 --
 block/io.c                |  8 ++---
 block/iscsi.c             |  1 -
 block/qcow2.c             |  1 -
 block/qed.c               | 65 ++++-----------------------------------
 block/vdi.c               |  3 +-
 block/vhdx.c              |  3 --
 block/vpc.c               |  3 +-
 qemu-img.c                |  4 +--
 14 files changed, 24 insertions(+), 102 deletions(-)

-- 
2.18.0

Re: [PATCH v3 00/10] drop unallocated_blocks_are_zero

Posted by Max Reitz 5 years, 4 months ago

On 28.05.20 11:43, Vladimir Sementsov-Ogievskiy wrote:
> This is first step to block-status refactoring, and solves most simple
> problem mentioned in my investigation of block-status described in
> the thread "backing chain & block status & filters":
>   https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html
> 
> The whole series is reviewed, let's proceed with it please!
> 
> v3: rebase on master
> 02: grammar fix in commit msg, add Eric's r-b
> 03,04,09: add Eric's r-b
> 10: add my r-b

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Re: [PATCH v3 00/10] drop unallocated_blocks_are_zero

Posted by Vladimir Sementsov-Ogievskiy 5 years, 4 months ago

03.07.2020 17:06, Max Reitz wrote:
> On 28.05.20 11:43, Vladimir Sementsov-Ogievskiy wrote:
>> This is first step to block-status refactoring, and solves most simple
>> problem mentioned in my investigation of block-status described in
>> the thread "backing chain & block status & filters":
>>    https://lists.gnu.org/archive/html/qemu-devel/2020-04/msg04706.html
>>
>> The whole series is reviewed, let's proceed with it please!
>>
>> v3: rebase on master
>> 02: grammar fix in commit msg, add Eric's r-b
>> 03,04,09: add Eric's r-b
>> 10: add my r-b
> 
> Thanks, applied to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 

Thanks!

-- 
Best regards,
Vladimir