From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659136; cv=pass; d=zohomail.com; s=zohoarc; b=bMiB9s7Oxwd37hiL5BBp+WgQZ2EJeReKnt4RsN+W//gCr2KzhxvAp9BBZFUxZmdUuH9GopGsmva1MgZG5AAMrWkEbwRQRP+Mhv7Y2gFs4KkNZdwXBnusc2qvqCLE8rzu2duBmGCUerdzhxDYNiBL1msgFA7V/+fQEm8g3ub8Gd8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659136; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zXu/gKq4Wl67OR3F11VPGh+VLwJw5TVF+p9rh/Xobss=; b=jz5iyFV6HM415kK/JMKjhgVP465zMvrV2Iql0kb/WOMmax2ya4oStroFDCjzE5aiA/DOQZn0gZZ9poptht4D0EXDZUFrPzXxHWoK6fgfLbm0l+d4T2VsTX9kzwOvzxM5jdIBM74hKkoA8Dyx7gg9hbT8ZEPEubNhEWLMmmXiSxU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659136274282.67095713228275; Thu, 28 May 2020 02:45:36 -0700 (PDT) Received: from localhost ([::1]:36906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF6U-0001IW-NW for importer@patchew.org; Thu, 28 May 2020 05:45:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5M-00083E-Om; Thu, 28 May 2020 05:44:24 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5L-0002k0-I4; Thu, 28 May 2020 05:44:24 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:20 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:19 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UQNwDur1DXqTAZ6UViT2xM7ADvnSH3Qo5NKpxUJMtLtiOcJx3b+++WCEc1gBO0kZ/6vGYrdjzAGiQYgsS/MSeNPoe84ju8srpUZyQa0yeaUn6M9vfWtulGxeC18tspE/8y1OIe5xqdWeCRxFRzgIWsGv5z5rHKpd5ObNFHHhTE5TrYnGmaaVwwtdO8K6wyzVFY83tJbJnrMURseao5M/QTENNap6NbS2bFFt59EuTwOb1yrTVLuOMM80ZSMrgsdqk60Gj20jFSqsGLdkVvz7J0zLpyXQEGuEcuA5zh8FyG2hDJEG2sGLB5eIKpCJce2PQTZaqBK5cEmQMnixkmt7WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXu/gKq4Wl67OR3F11VPGh+VLwJw5TVF+p9rh/Xobss=; b=VVYLHPvV+B5k5QxtGwO2t4uJ57QAnGk0HsWkZpmk9ZchQ5SMVzPYXU6MrhWOqitZ9/NrWpzDSg2RWJZLfUX3iybngN9fsV0PKDMSyfgui+kuyNRrStcZz6LLUI4qSE8QKWUOz2JQpxyR6G4NM4x0QVCTT9z3YURln4dc0uQ3rBx96MJdnvVfIfJgUrhH+yl0AXfGQDoDkBU1kwOTOEluprUAKkxv8kUC2q7q4wyLpaMvm0Lc7ClArSnfmZoaWzFupI2CiCjZH7ki9MAXxSuZK8UUd0k1m876NmUdwoqsGmsNacnzofbx6k5LgGGaV8Vb/jC6Nm+oO3myNTAx8nCP/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zXu/gKq4Wl67OR3F11VPGh+VLwJw5TVF+p9rh/Xobss=; b=hs1zSXqD+hsahug2brHo01+FsTyaaePfGVOQFx40Vd6p56Ot9U1YGx3dIyq4NWTXuYp06RzLwAa34IHxfChnQaOmcPPMgTdMMG3HGeJQIU1ubhd2hbNsEn+EReCZRegW9ssF+t0qBwG6MOYZSfV3IHmHFSaw8pVtwZmdyjtdR0U= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 01/10] qemu-img: convert: don't use unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:43:56 +0300 Message-Id: <20200528094405.145708-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07db0098-5513-4e65-a330-08d802ebb1ca X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:262; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AaoEKw0xTRVlgMTV8Mg1w92KnfxEL/motoRjIkGkTugBgPKDXidAF1QxLZa5X0OHxzXdmvVMsCCyBH+HVw480JI+LzhWj685q+WTsRTJ2M826sni74rbxfqOwPhie28UqTUrKnWa8I0CUWY4M3Z6QcRtBME8CopWmXNew/LzAI3p7a0YAqW0hfliAESZqC4/7d5PRMfofD1XvCgJBJS9NnevnGA6FHonYcbilq/1xHvg/HaQwMp/QVI5BwHCRyJXr1Xmn484fKNsWW3hOd5CCP8C1qjl2KWRqV0Zf7svbvSPMLB4ejOoxE8kSRxlD9Y6XtQuwtS6I6A1Ddx/3gKK6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: YKLNjKB58vn3RTN6jJwgWpK9DSyhrk0oL/NLHlJA2o6rnv/w/CmRRltG+PfFCeL/DjjND0iU5JIu3Lo3ij2jG4oylegNz0dCHnzTRZlEWBQYYGWVP2+yQciW0ZZ4VRBkjckeHw4xU07g9vi1X7mOyCz/cOqY++yvObYBDUKy16+EYLk5k8S2QVG4XinKkJb+IIol/Xn4OUDnwVV6rhXEwsIBYxYaWZn1YGx2XLSNStX4MzSyt+SGEO5BW4TasZjLPI2LPTYr0XF9FLTudiIX+8HnNBH0AhLC5qs5Pw7WFk2N35fBgkbeoLWEhv3GbMjP9kL3wbJ1VEQcRAe7Ke14CllSvF1BrLCnM0Yre+O/dlG8GtuaFBNjZ/sUxbiLW7aPGFPuiMjIhYIgtWPFmnbdIfXBQZw49hDm53bDmIAcpYWWaFKzCzqOFndRacPZ2dGrebp516vzS/V/tqh0IxJmjxg4KESoCDfwHAwMEoQdtro= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07db0098-5513-4e65-a330-08d802ebb1ca X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:19.8931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OUr27YFy5d4ALZZM9iblLSK2VjaPG9bVStqZOEfyatLEl0X70HradPzuKUfIUNvbTr2hMa4AprboVi+iPoICdvYDQLtTT01BWX4VQXK8zMk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" qemu-img convert wants to distinguish ZERO which comes from short backing files. unallocated_blocks_are_zero field of bdi is unrelated: space after EOF is always considered to be zero anyway. So, just make post_backing_zero true in case of short backing file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- qemu-img.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 2d30682f12..9fcfafe470 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1660,7 +1660,6 @@ typedef struct ImgConvertState { BlockBackend *target; bool has_zero_init; bool compressed; - bool unallocated_blocks_are_zero; bool target_is_new; bool target_has_backing; int64_t target_backing_sectors; /* negative if unknown */ @@ -1705,7 +1704,7 @@ static int convert_iteration_sectors(ImgConvertState = *s, int64_t sector_num) =20 if (s->target_backing_sectors >=3D 0) { if (sector_num >=3D s->target_backing_sectors) { - post_backing_zero =3D s->unallocated_blocks_are_zero; + post_backing_zero =3D true; } else if (sector_num + n > s->target_backing_sectors) { /* Split requests around target_backing_sectors (because * starting from there, zeros are handled differently) */ @@ -2610,7 +2609,6 @@ static int img_convert(int argc, char **argv) } else { s.compressed =3D s.compressed || bdi.needs_compressed_writes; s.cluster_sectors =3D bdi.cluster_size / BDRV_SECTOR_SIZE; - s.unallocated_blocks_are_zero =3D bdi.unallocated_blocks_are_zero; } =20 ret =3D convert_do_copy(&s); --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659153; cv=pass; d=zohomail.com; s=zohoarc; b=nTzazYRCUrwY0chyI0x7LROq+VW4e9/0yGPXU0GII8y+0Zl4ovC6xC4lZiv99xHW7v6pfmszHEQ1uz+Dgg8xKB2I0Jk4HNBDkOronlO1qCG8ifUeriqdmQG83dYClbGcTSbov3LNgC/xkHWnkH1+9SnmykZ9HxKUmYEfzio7ssE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659153; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MfC4Cz4jbnChRj77AzLGlNCwKOcwXVbPBerKDlE+nPs=; b=ha0joVb3cc12rZxfMVIua2DNukdaEGySK6g+2t/Q1rZ3AbhmSXcfuSziz3G1f3TbvH3RWS/hQTOZAdfmevleSWZ0w44J02+oyexXfC4si1rMYHerR8t4dGOPNd6+ySN9TQ4ivxRN95ohzLnjW8MhDzPKdLyjBo2jP5vR7vFcGh4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659153159626.5515341164713; Thu, 28 May 2020 02:45:53 -0700 (PDT) Received: from localhost ([::1]:37926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF6l-0001hy-Pa for importer@patchew.org; Thu, 28 May 2020 05:45:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5O-00084t-6O; Thu, 28 May 2020 05:44:26 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5N-0002k0-Ci; Thu, 28 May 2020 05:44:25 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:21 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:21 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VR7MblqJbfZnwpomGo0GrKUhpYaUSab/kYHgoL70aPAy8XQFNmS57Vqhb8wMeSULXj/GRHpyGQls+ki1mdzoLJ1kOzM2sPWOSwRk3O43HDtw9muwu7oqyfqbikej/68qoi3Ca5w/Ro11MQvsFf0vwpNdafAbVlKRakN6lqPpBZYiB6zlImL1aaBZqMj6FmVLaOU77Mfr/PMxu6vB9VvaIPOfFEmdxMnnVbfxcxvh+eOTHl1KgfqC59CTej4bm96Rf1/D7kWeoWoVQ0pBrYpZ28vGSdIlO6TN+oEK4cP0kXlDuM5sYnOimfwgUVaUrilL6KFuMbFB+HplCZQsORwU8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfC4Cz4jbnChRj77AzLGlNCwKOcwXVbPBerKDlE+nPs=; b=ViTe8I+7Jf0FBKDS0oOc0yadZWN2KqRrtmapF5qXZv4mMXQsqe9PgNggleuTspXwkfBX2hYU7mUhVEWXdGIQskg/HUi55LFNlFCy/yWTTGCooALb8qvMNUWku8WkRH7LE0hmS0Cwr2mhlIaxmtw3edK/MzObiDXNFbO3bVrO/iC+VPteYt0hxDauflIjQKwDxtGA05jr48gJK/vS5r1KKIyxv0oDKjJiQMPKm+JRp1D3gb/LppPXaJeZ6iKVEjPjsI0ZZmOBrrxaAVhtgZ6gS/byxZTVUIx+aIgkLPytwaYq5hFTKMIPr5xAJ18SRgNkEnhcxcep9r5fEHMfPQM0nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfC4Cz4jbnChRj77AzLGlNCwKOcwXVbPBerKDlE+nPs=; b=n0hieR+ld6vsIVU2z4UHOjuvey0qkLw0xbil905NCSQTQwDhzhS8kI0gEkWMc1dYO1SDZ0fBMZwsOqpvLTyJvh8XpT53FbxFEAKJ0k8cBvcw1aOSbXEsnMC2UWhIKeqitwlwabP02rjoDk8jITGCle7G15fY/f5l0XWBAKhzz+k= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 02/10] block: inline bdrv_unallocated_blocks_are_zero() Date: Thu, 28 May 2020 12:43:57 +0300 Message-Id: <20200528094405.145708-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ddb745b0-ac18-4ec2-58b5-08d802ebb2c8 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:334; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CkYbRTSOWI5jb/e2Z8KnSGJ0aBKMQcfr3JzCnz86iATGdoYYRWcHxnqlsUyO8Ja7upufhwRztzf2/i0MvrTlHARkyGaUMe3d4jWVPP+QmxQKn8tOahU4DlV6UGlk6eppYZ6+kagZEnipr/4i5hHFMINhsyygvmzpEQdMVhrgUuPwiosBqYKddTz98lP+NSh/FnJb+iL6rMrdbkRPVTHxKDjL4czW5bp+EEUlszvxczm22UsarPUtK42sAlHU3dxEIp5M8b8dBXSlRIWlsgxY1tL8jXqJ0Yx0fOg+H1jwWv4ePOovoJe/20KxuWnQlm2iRdCaM6DF41dv2kYhppwpCw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: l1ktUWUCL7mgKJ0Xc6k8Hok07mYOGcRGJSJg2HfIHHtNH7i0KNwypAxRQy/JTc2vJbE8iFkbAiRXbDpS9wYWt5LYmB2JugZl6m1L+qWSZf9c5WrJJBCFCJ7Yd0IYUQ73jbRL+5Q8EU4aikV5LOwte+sQHSe/plueY2YZWPyEDSslS6B1cpF9Dtoa/WMQ86vRIsixy2NrP0YMo37mYxeCIzpFuLbekrlx+RyER/cvXqMKX8fqLipEhI3fRvu1BQ94DCscn6p9kMndHG/JVl2XDvnGhheu5LdLqiRUtIo9dldZDMxAjTFUhlJCvZ6WeKvcmyAVuZuK6z93/mKCA0CpOFOHz/2aH2be5Dj5fVV0Rvf/DOFULrtk9NLLrF+AekB8LGYOKd7Gcwt035D58EKEKbGlyIs9qT335PGcbfy++iZ2vqnofEsuP1JODTGDUs2fPmeGQrGeFcgOKiGURPLwGbBFLjC6P/Nvwky1qt7QrSY= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddb745b0-ac18-4ec2-58b5-08d802ebb2c8 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:21.4766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PgOQ55wtGxCGvqRCUgtkFVxkrBMSwtNztr/1tsakpM+o0/WtHKn7re3VThWpche4fSI+ovmj1JgS0LjN2pqthy8NZBkTdnn26NnrX06HATc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function has only one user: bdrv_co_block_status(). Inline it to simplify reviewing of the following patches, which will finally drop unallocated_blocks_are_zero field too. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/block.h | 1 - block.c | 15 --------------- block/io.c | 11 ++++++++--- 3 files changed, 8 insertions(+), 19 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index 25e299605e..68699ebbfa 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -488,7 +488,6 @@ int bdrv_pdiscard(BdrvChild *child, int64_t offset, int= 64_t bytes); int bdrv_co_pdiscard(BdrvChild *child, int64_t offset, int64_t bytes); int bdrv_has_zero_init_1(BlockDriverState *bs); int bdrv_has_zero_init(BlockDriverState *bs); -bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs); bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs); int bdrv_block_status(BlockDriverState *bs, int64_t offset, int64_t bytes, int64_t *pnum, int64_t *map, diff --git a/block.c b/block.c index 8416376c9b..34adf1298f 100644 --- a/block.c +++ b/block.c @@ -5408,21 +5408,6 @@ int bdrv_has_zero_init(BlockDriverState *bs) return 0; } =20 -bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs) -{ - BlockDriverInfo bdi; - - if (bs->backing) { - return false; - } - - if (bdrv_get_info(bs, &bdi) =3D=3D 0) { - return bdi.unallocated_blocks_are_zero; - } - - return false; -} - bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs) { if (!(bs->open_flags & BDRV_O_UNMAP)) { diff --git a/block/io.c b/block/io.c index 121ce17a49..6f9507f718 100644 --- a/block/io.c +++ b/block/io.c @@ -2387,15 +2387,20 @@ static int coroutine_fn bdrv_co_block_status(BlockD= riverState *bs, if (ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO)) { ret |=3D BDRV_BLOCK_ALLOCATED; } else if (want_zero) { - if (bdrv_unallocated_blocks_are_zero(bs)) { - ret |=3D BDRV_BLOCK_ZERO; - } else if (bs->backing) { + if (bs->backing) { BlockDriverState *bs2 =3D bs->backing->bs; int64_t size2 =3D bdrv_getlength(bs2); =20 if (size2 >=3D 0 && offset >=3D size2) { ret |=3D BDRV_BLOCK_ZERO; } + } else { + BlockDriverInfo bdi; + int ret2 =3D bdrv_get_info(bs, &bdi); + + if (ret2 =3D=3D 0 && bdi.unallocated_blocks_are_zero) { + ret |=3D BDRV_BLOCK_ZERO; + } } } =20 --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659316; cv=pass; d=zohomail.com; s=zohoarc; b=Xwp2StDlz83Xklktev6np5kZm+xUUuzasHVH0n8nBwSimCnOin4VP9dfzhSDVgTpdRfmaqc5h/QvX0HYJcZt/epnGYoKjI/vox03PSqd2GZm0nabCNZtVsI906hiR9SsQFhg/3l3VaVpzxTb6//V2s+LGySZIM7R84CNq/7x0vo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659316; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q0AmImOQ33k5aSJq+SXqWhrtj3a5yCp8P+hPQlOK8ZU=; b=El6AVqYzLg02ypgOPGYX7trhGq8xXqa+/mWhNEVP8ZOTjuZFcPBP/cZa+ek9xujGFIDuzeqhOaFsi6JILTvWKpuUkm+0fxQRKwwpFobEXcDwO+32P6FC4bpT/UjkxHYXiTdWrTxhX4QIvwvFYc6Ve81BCJ9pD3905sOgyl0dRrI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659316412783.5822131189253; Thu, 28 May 2020 02:48:36 -0700 (PDT) Received: from localhost ([::1]:53060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF9P-00004r-8T for importer@patchew.org; Thu, 28 May 2020 05:48:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5P-00087v-KR; Thu, 28 May 2020 05:44:27 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5O-0002k0-O7; Thu, 28 May 2020 05:44:27 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:22 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:22 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m3GK4HVAOjqHb2vnltIeU/SMwsFY6nEqlKMqZjYuUHT6Gshnzxm7EL8Yxov5MrIOWvYmSzBJWfQCnj10Chphi8QoGeYZMWUf2SmIFcDLbYjpVG+igz/W1glXY9a0fv5H8lX7WCT6+dffzWm/zvD71oYm/6mC02NG8kDF9Pw1bNwuw8/DBMFUdPY860StQ0WTOYYj8JP7S8tPjGe7Ya0VxYfOX+1HiQUS84cCHI9JYXLHzfTEf0YTmOOdpsIcbnUcR9HnV4rEHFQmaaQJtTrcm5u5Q34Yd5TA7uCFmSbgMWrUFR+VvjxS1e4vSGLPpPo6vSX7xMRW20dWs/68duyKCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0AmImOQ33k5aSJq+SXqWhrtj3a5yCp8P+hPQlOK8ZU=; b=OJ5lc/2G0DhvowTAvCi6V/JDVcOjSH5brnPzFpY6Gfz5I605B7vv9lDs3nyE+pQ28hPfXD2nN7nCK9adob6K3/Vw0zYG/u6mM1x+isT1kA2Vyz7QXcJIx78nsHOK6XpGVlaeTrJNjPfLREPxYIgljamO5WPFsjjKwSoJTxDWJwuQ2K+2by77mPs9RIPlWqSqj4mb6WNbMbNTWLa2qYrSR4D4LY9jo3hilraGU7ZLui1rwlmc23oLFHMDMoLMgahgSsd87+GP9xWvjiR3sMHyI6Yg3CBwrsOnilld/KFdgmv4zP0XrmxPWaapYZkF45c8ZU4kUZYIU30Nb5FzkFockQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q0AmImOQ33k5aSJq+SXqWhrtj3a5yCp8P+hPQlOK8ZU=; b=hynXYIb2IZ4QBH2yq+WY5KL/LeSW4vohFdYEXKyrtQMXnEIq8g0FDL2nrrgriErlY+14Ep5vSuoL8m5s+7TOovDVzKp4BpjU6SkhEJiX4Buf7rww5rnaoRl9ymNzjfYCUT8hltVz3+RnR17BrwRgOgcCIVw9ekiJYy3X3A8VaXY= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 03/10] block/vdi: return ZERO block-status when appropriate Date: Thu, 28 May 2020 12:43:58 +0300 Message-Id: <20200528094405.145708-4-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2383c79-ded5-46bd-f45b-08d802ebb372 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /UWHnLL7tw+ky6OmCkU/PR2R2wR87Exvu2Aa/ozP4moYlbcnsfb+iCat+M1FNwvb+OynpG97oIZZW886AndjlDk//elBojLqBQCU9Ih6f3fw0WKE51/N08cZg/kFFsXw1LtrVbORbXn4nAedWLW3u9XHUPo/OZ2DqNscuNcVixeLbt5zf/u6tCXZueJ9A6F9QELphT0dz+3sqRqFw/HU9LUaFgk4znWpAv4hcmn6J9n49dD8n7/kYIEbRF4uHHaheHUNVbLs0XB+c3WGjUBCl8VoD6mU+sNggBU0al4+it7Asiat+7dRuJilITtMtXxz3LP4HY8FsZ/yKSubQ8ad2g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Sbo3uTzkvk2TE++lgl/ID1O1syqE4ZU+bsUFhsuxuZ9GBF4eDSLXZeQlow/PfIIN0sL1N/UDvXNePu3rjlNnwBBj3Zg+PNff2x7BtAAF2yDk5nADlox13Af+PV9xeqHaPE8Ur0cYVOyH8ADyB12A09CGC+46rvJUsT/pESCRLX90f+wCgV0AOyzyr+W9uzryrFIc9cTnlvuH8BUeV6rBoOuCf6uvy4l1F9Hq0orxO5aCvqOHOw1ofMqDSyyudY0asJ/uo0kEZWZ4/nk9tiHleiEA9n0a47X7Ft1X4dWK+rOksy3UpmQbKdUHI/xOPmipu9i2JzwuQ4QKN9LF7Bxk9C4ZIt/D0S/wDaroOGwYQC4p6q5durtF/qHOSnRUjIv30P7J3QtXQcUYUJifdW68wKIqlAgWL4Ey3nmxQ6cxrnOinAnlIz+MxcxwSn+ixk349yYuXArra0EIRSrf2CIRCICR0eOQ1KrKPwU+BEjVv/s= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2383c79-ded5-46bd-f45b-08d802ebb372 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:22.6460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AvvOMcuPK7aB6jBZqitKsjaAUl4ouAS3XcZfROtfCK4nBK/Pi17v7100s532eoyACzo+O3lQZ+CunHyKfIq6HbMSDuHUI2Tz9DeE6CcvPCY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In case of !VDI_IS_ALLOCATED[], we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. Note that this changes visible output of "qemu-img map --output=3Djson" and "qemu-io -c map" commands. For qemu-img map, the change is obvious: we just mark as zero what is really zero. For qemu-io it's less obvious: what was unallocated now is allocated. There is an inconsistency in understanding of unallocated regions in Qemu: backing-supporting format-drivers return 0 block-status to report go-to-backing logic for this area. Some protocol-drivers (iscsi) return 0 to report fs-unallocated-non-zero status (i.e., don't occupy space on disk, read result is undefined). BDRV_BLOCK_ALLOCATED is defined as something more close to go-to-backing logic. Still it is calculated as ZERO | DATA, so 0 from iscsi is treated as unallocated. It doesn't influence backing-chain behavior, as iscsi can't have backing file. But it does influence "qemu-io -c map". We should solve this inconsistency at some future point. Now, let's just make backing-not-supporting format drivers (vdi at this patch and vpc with the following) to behave more like backing-supporting drivers and not report 0 block-status. More over, returning ZERO status is absolutely valid thing, and again, corresponds to how the other format-drivers (backing-supporting) work. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense (as the only user of it is bdrv_co_block_status and it checks unallocated_blocks_are_zero only for unallocated areas). Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/vdi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 2f506a01ba..c4527a9d8c 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -334,7 +334,6 @@ static int vdi_get_info(BlockDriverState *bs, BlockDriv= erInfo *bdi) logout("\n"); bdi->cluster_size =3D s->block_size; bdi->vm_state_offset =3D 0; - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 @@ -536,7 +535,7 @@ static int coroutine_fn vdi_co_block_status(BlockDriver= State *bs, *pnum =3D MIN(s->block_size - index_in_block, bytes); result =3D VDI_IS_ALLOCATED(bmap_entry); if (!result) { - return 0; + return BDRV_BLOCK_ZERO; } =20 *map =3D s->header.offset_data + (uint64_t)bmap_entry * s->block_size + --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659243; cv=pass; d=zohomail.com; s=zohoarc; b=TSQxgoAX41i4V1/0fS4vf0d4obXnSnnFwLgYxmrlDzUKKLN+YD71AuSduCZsZGSA/JFXrRjv6BdCXNN7S5zZI6Vg2401hqN6wT+qT/CKE1SvCnq0nQOYGeEDhZT1z1T/Xt58b2D/zn1ogdFKa4hWeaBxbh7Ck5Dj4cbcRYyvjX4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659243; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lsB+UkadptRccwjBM947JyuvJ/x1MOKbaYcyytHuDI0=; b=MYnp2DR9ZmNPOH6HTHFl7C71IetsmfJiNe57Aa/q18/EGIrhSmsrVj+mBpjzqSAGTdPI5ZPcrFeZAkjj0zjaBtiYrYxkOmujTE+pyg/DLqSS4Jzs409Tec89Q1e6xGQPEpquatc17i0QkFuIzGar7wZrvvAeTAML1lHiVBrBsTE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659243016480.57314731636427; Thu, 28 May 2020 02:47:23 -0700 (PDT) Received: from localhost ([::1]:45326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF8D-0004p8-SE for importer@patchew.org; Thu, 28 May 2020 05:47:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5R-0008CU-7D; Thu, 28 May 2020 05:44:29 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5Q-0002k0-8s; Thu, 28 May 2020 05:44:28 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:23 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:23 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYTw5/p6XbJB5v0Dczk9GKtGm4pV98mrBRBtEtGdcCIlIvHRkErnqackuOktqdR1tuxXk6GfKXpVhgJGKQdyR5bB0Dk7h8eD/Si9fbFGO7Y4sb1jDRi/qhPB8iZ7epsFQ1f+OL7DdKqQeOqUC+8HP0AsUeeuBJ0kNtEsSs65JUsZnpGULbs+MzWBZm7S2N5+fh4OqX/g3QWuAJBVhQsDm5ulf6yVQ7oi+24MmgupG/p1faKnfKSJP9RVFTZ2KJpbn0naTdJ215tG6Oo44EJcHSUTeNt/SLoj/Ikhd5qvg5WP+mxVXUaFOnc24Lnt0FfhbIyRl+3jeaPZZceg9KzH2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsB+UkadptRccwjBM947JyuvJ/x1MOKbaYcyytHuDI0=; b=kcpaze/zTk9w/DxEbxJi5gEKECplhg+VN1+XYe2vFlYVSyI73c5oBSkP9lvaPiCpMZgl2u2LLg3E0Ox13lUp3Z4XjUFx8g8Mpp43oJQnz4f21Sz5n4TjE5KfTFhdICPqVg014dKxS3x4ejZLIexeI5TybklEYsIWSDf9/t32XOiu3z6SH0x4Fy43RFwFAgkAJ8pW+MZyqh6eTytiydekx9Ewx5dHanygf7bQIn+E+sorrgY0kGp15HVcL1x8xIz5Dr6nD3ddKNlx/NOeTekUfmyGO9M/JaJxbROxNEaFwuyjojUWBJ/2Uvlcc+rJLH9yMSfH0tH6Qu3GGqZT37Vd4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsB+UkadptRccwjBM947JyuvJ/x1MOKbaYcyytHuDI0=; b=JufD2EdaJrxVHu7RU5OjH5cL76FEL+b0fVH+emfTkMOXEUPAqpfkPgpb1iyTDnBqdnF5voDu3Z/m/BvuWrajGOCy4IFbRVUA3YYYXc5GhP+aZ/ywFD3cVHdUtX3pP0sSGWjirXnok+Y79hCeFDyB5VDU58CE9TYi6Gq+odC+W2o= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 04/10] block/vpc: return ZERO block-status when appropriate Date: Thu, 28 May 2020 12:43:59 +0300 Message-Id: <20200528094405.145708-5-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e26ce506-6d1e-4a75-58dc-08d802ebb41c X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQW5GJo2BMK6Cfq0S+3goacyxojkXtduQs2w6vUKp95CzHNMgabNNuLgYjD2SS/svjPiT1Io4NwlOEdPA2ZmNpkM3gfFpPaRQn5G7JtZG4fpRjugKLqnXIviZg9WetF3wluyB/XiBut1dvDQYehGk1zBUpt3wp1FjLitbrvStV62N1uI0k6HDZeCVBxURmC8Tvszf7lLHITtDvnmqRhh6cvPQhqXzjQEQ5DeCIS3xZ1ScqPa2n3kAE9B02yJtCT4JAh3Db0olSvU+LhBjynShFtjynthKVa4o9pZNuEN7SLl8x20F/Xaegl2KSHgY0aJrr1K20uc4OAKB1GWgowbCw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: werFPaNItnWbczyAxlQvU+3zux/eaw1BKZi9vBpkK+pJqbGlJ0XyhKqpyBsE1t7kyjpbdBzFbPkBzHkm+/uNGgRuBcM15ccO4Bj+eXyaGt0Lvs8sACSMdCdDlG7cmsnrHO8Es9zQTgG6G8RtiUkgOt8gtoa1GxCyIZFjoA+iJJbEyK1FwUJgMf0iKsbgSCyBTQjBfv1X5TVudAvbn4k5DUIfZgcDz36ZAISDFPPXO89lWYZQlGLtPJWR0SWBLVCg28ILhajFkFDGxwdEyGblg94TQkZ/od1qIc2xuvkOaMfSvAdbPzV5M3HMNMCl9lCKbO+TjiVcWlv9Hi7hTHfeSfPuJQ662lCFM6B9MCrMu7o18GSBdks6fPg3qHZFZSc6uEH1te/BUE8SKdnpTy6RyR2xv0OLwRbvHnxzg0etgGF/Gsmn26PIQ/12iiyHR4bAF8CXIteogrsjkfcWvCrMwMdqKUafsPmiO9Xtk4ChufI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e26ce506-6d1e-4a75-58dc-08d802ebb41c X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:23.7377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0GSFlnVt3VxmR1tGwUoUHjlTFBBR5aglJMAVUJ4UewX27Ofk5zTJpK9E8Kdd+ZkRQM8HaTYWrqdlY4dUcmtDXGVjl//DlxLXSV4CTMlAjec= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In case when get_image_offset() returns -1, we do zero out the corresponding chunk of qiov. So, this should be reported as ZERO. Note that this changes visible output of "qemu-img map --output=3Djson" and "qemu-io -c map" commands. For qemu-img map, the change is obvious: we just mark as zero what is really zero. For qemu-io it's less obvious: what was unallocated now is allocated. There is an inconsistency in understanding of unallocated regions in Qemu: backing-supporting format-drivers return 0 block-status to report go-to-backing logic for this area. Some protocol-drivers (iscsi) return 0 to report fs-unallocated-non-zero status (i.e., don't occupy space on disk, read result is undefined). BDRV_BLOCK_ALLOCATED is defined as something more close to go-to-backing logic. Still it is calculated as ZERO | DATA, so 0 from iscsi is treated as unallocated. It doesn't influence backing-chain behavior, as iscsi can't have backing file. But it does influence "qemu-io -c map". We should solve this inconsistency at some future point. Now, let's just make backing-not-supporting format drivers (vdi in the previous patch and vpc now) to behave more like backing-supporting drivers and not report 0 block-status. More over, returning ZERO status is absolutely valid thing, and again, corresponds to how the other format-drivers (backing-supporting) work. After block-status update, it never reports 0, so setting unallocated_blocks_are_zero doesn't make sense (as the only user of it is bdrv_co_block_status and it checks unallocated_blocks_are_zero only for unallocated areas). Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/vpc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index c055591641..01fcd37e3c 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -606,7 +606,6 @@ static int vpc_get_info(BlockDriverState *bs, BlockDriv= erInfo *bdi) bdi->cluster_size =3D s->block_size; } =20 - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 @@ -745,7 +744,7 @@ static int coroutine_fn vpc_co_block_status(BlockDriver= State *bs, image_offset =3D get_image_offset(bs, offset, false, NULL); allocated =3D (image_offset !=3D -1); *pnum =3D 0; - ret =3D 0; + ret =3D BDRV_BLOCK_ZERO; =20 do { /* All sectors in a block are contiguous (without using the bitmap= ) */ --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659160; cv=pass; d=zohomail.com; s=zohoarc; b=ILt75jTVzurUKdrvu3rKImF3Grl6dVIPKAoCneph9A0dNVxodpGk3vPETyxgoypqGQ3KaYQj1+JZjZ3mQDp8hnAuWbW52GDG4uSHW35ZUMupMPhhB/eOq2rSAIrHF60VzQ09AhuJ8Ey8i4mZJjjU+hQLO5T2X4MlS6N451+c24c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659160; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=X4eMlGU5HpuoV1iJqDRRgDlmqQEuUDPVBpSQ44ZQuiw=; b=gt+2orfluIa2tRHkNOz1IQ9wArkfzPF5K4/4MoSHswpIXnhVb9e2RFpyuZpXt6oyj3uKVyBysh7i5Frgi/V7e4flFhfGdFI1FOd0JzLuveYEy3glwPzbRW2MiVzjQHpqbs73AfBJ5ldIQRNRJx5Bijz9LJnfMBUqAWJuSTU0HV4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659160800601.6232004416711; Thu, 28 May 2020 02:46:00 -0700 (PDT) Received: from localhost ([::1]:38422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF6t-0001vZ-FU for importer@patchew.org; Thu, 28 May 2020 05:45:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5S-0008GC-Jy; Thu, 28 May 2020 05:44:30 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5R-0002k0-OM; Thu, 28 May 2020 05:44:30 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:24 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:24 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcUT1B8LUL//t+GGlt2ahbY3Ce2bSSJqluYWgUNRxrwloui+TEIN/GEa8jgap7MFGR3aWuF+kODN/X6HgZRubwbmelxlLAEZkpMHoGxpE/gT5ww4p3L09PnUzC6aDW0b9XVgYS+AdX3lmKkIw+8wcptQ42P6pooANaWyyqXdnwqQpPD0JXtpxo66pcKcJFgP17FvODJjGPJa5RspeJqHn3g7CkxLZGRGG4cRsk1O5I4LWV610Qe+qHfibbpfgZH/ccg7mU4wUclKBys8UsJeUbqiZGiSbvG4Z8AOcCdDTH1nni/FIZen5mv2/GiCNQbeVJPZD6T/RtBE9m8Z87UeMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4eMlGU5HpuoV1iJqDRRgDlmqQEuUDPVBpSQ44ZQuiw=; b=WeYNcabdE0N8zOCG2AVWQx4hUOLsSo84i1CNhCPagMuR+4OaTI3iyP8uOOAMWvGajs6Ar0udxCyb6RD5ajgzP5lSFttYEoOsbyK3yObuIdxvoPD919qyiZ/+aLv3ob2+z7wlFr7hoAZbTqQRAVHw6PJdn+MLQlvbjReVbB93+e2jMNNwRENmY2S/DD63rta1pfefJ8DfdrhIvkn2VDcKUnyu800Dxn6h1XddpwPd0irpTeiRjQBgxf7qGgzaE7wPQE+SzDY6+WfCa2lA6L/8pilMO+HbUiiEd394BMAIcfoTvEV/7nTMw32Ll6E87zz1yCG6c8tHOnNtV244UCPB7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X4eMlGU5HpuoV1iJqDRRgDlmqQEuUDPVBpSQ44ZQuiw=; b=a4L5hbuKhK8wQ7cD74FbMMbINbgUENO0HwCOGcvYwsgGxjcPXX7VldEMlrv2QTCyAmUj0LgqNSUpV3AtHCNt85No1vVBac4NbJ6IzG4arUYvnsvoje/aGhwj8qwjgcQvDuqTg+mKmNRkQ0fMmV4aKCiT05uVtvhFktQ1vVciPIE= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 05/10] block/crypto: drop unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:44:00 +0300 Message-Id: <20200528094405.145708-6-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5967e176-1dfa-4fb4-ca22-08d802ebb4c1 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:632; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RjYxe+APaQjRC31LVl1jUy/ACKmFScoLPp2i3WIjqP33wYlTdA1cDh+hpS0NhEw+u5b2oYgjSIG7a3fbF5tmOEDPrn7HOqQ3imwdEr7jUcIBf2nJ9kY7aZ4LW8xdFsuGCMZ1wExrCvfTxJ6rfv+ePrxeq28vGW4QdyYvq4Q2s0zLXbubjxjBMsY/FWCI90hPXpgg57f8OXkdQNvX0L28m/ATgwEO9C9NVEQ/U6m4DEfQ50RHZq0L7ob4IfSzfKdhWvi/6F/MDkqdu72UWFNIWh4urrmisNP1xBARZXdZ2XGgtNcNI6DCw163fJwgAgKaXdnsby/mJZox1cx97qV8eA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(4744005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: gsaGgaEW9RukO+bFQ5PclCnwL1Hqgi9RSm7h4yYLPQyqDsm+xv+jvrnY6NcXBkX8cEr9QsK/15BwjDuecGM7pxCzmBtVpxglXb+qtG8af7vn8+SpGzs9VedkZh2EsUsc8BeV39CxDftDMZJXeGoXS5mzPu+VaPCjjNoyVhWg1u5oSND4ryJwPBgZgghauB29KFjKfl2WBBQ51i5TI8DCA11dDcGKvcuyxr9icjxtW3w1QvbRDH1ivHvIyECuQiRguq3mYJTMoVNVm39Cnu2o2R7y2Qshq92rB3/2XTSWK5J/5Vb39dFesuGN9zIpdTJuRMmEclhFE8ijQG/YRhVmBS6oUQhusWzyhcLW2My525Ieo93uHcHsKRGY/oRdmeenmXpBhxXdK1kB6PPOqBpdSG6JUa5GwRtXQdSB4I9SRHm7S5Re8zvPjRhFF7Vn/fR9zzIJOU+xsfmboEO+eLq9vqCDZU3lNDbB2WVo/0mO7kw= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5967e176-1dfa-4fb4-ca22-08d802ebb4c1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:24.7871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mhKSC8prvqDVEHOrUg5obyPWad+yf+NCoHvgZmNAP2++O3dCuNHDxnwcofXsO++45lhz6aDK9/waaXCSvN98Nc2hy4FIaRaIhZnhECKXUY0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's false by default, no needs to set it. We are going to drop this variable at all, so drop it now here, it doesn't hurt. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/crypto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/crypto.c b/block/crypto.c index b216e12c31..6d930e2d54 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -710,7 +710,6 @@ static int block_crypto_get_info_luks(BlockDriverState = *bs, return ret; } =20 - bdi->unallocated_blocks_are_zero =3D false; bdi->cluster_size =3D subbdi.cluster_size; =20 return 0; --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659256; cv=pass; d=zohomail.com; s=zohoarc; b=XZCX6I8DMypmagPUuFkV1EE062h/7XCBGLNR5PjJ7YdWOG8eT7Aot6knole8gQFVD9fdaYedDef0fgXXDBTwKxQsYSf4TOONXPX7bAG1CjjXIji+AvUy2VJp3tKsfOCKtp++FNIZA+E1NOIfadO6U/3LBzO5+5CZSyR0JdCsWhU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659256; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RHc5XfsGgm9Pnr0ydl/EGCvoHSU1aCHnH5d1IajVg+I=; b=aQG9W29DfpWrfkiG6CXjXDXOcU6Lq1dQS6e/sg2F2C2bcG077c3/agZIx2kV7nroHpu+YrT1lmj7H9TzQDaQGuezt5AcuQXtcQqTdgIdwTNGP+/0Mm9x5gi1gHxYkugETOoquSbuU+w3V/NPTuRXP9Vo6Vu/SpPz/cnhln2CZdg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659256076984.8232631173759; Thu, 28 May 2020 02:47:36 -0700 (PDT) Received: from localhost ([::1]:46658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF8Q-0005N9-R6 for importer@patchew.org; Thu, 28 May 2020 05:47:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5U-0008Ls-Mp; Thu, 28 May 2020 05:44:32 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5T-0002k0-9R; Thu, 28 May 2020 05:44:32 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:25 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:25 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XzHdanKOvIoEfqCfVo/rZF9/GPaHYtOVSGt6/3lVsiXi1JFxyWUkcaTC0SKRiE2BxCY+CwvtyTzYkquENSd+Q9pXnEvrhcDE8seM2YxTxmpl4O/qvKDHaqf5i20R/eRILpaXP10kfiwoh+3Ll3jXxAuYTJ3RSfYm4JkjQIGs6GMD8jKfS6Jtt0teF666KY4TIOjbDYErl7hyNJrQG3ua6EdfaQfgkFz5hrGN+ry56Ol3f9DV4mULmooiUhVfUYkvK+w/MOB+GkIzEskf80FQAiebaC9k82HiiQKEPBiwh2TWjlW4pFfbH9LL6R9Eoulv2WLLt8/c/HSFkevzWVNMAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHc5XfsGgm9Pnr0ydl/EGCvoHSU1aCHnH5d1IajVg+I=; b=IvhGFLEVwr6mvF561/nL6WWYYOs5uMfYRkD74aVEWxtOG+UkgDZQ2wAhB8IJCQSdH8MQUUCN6I8uk4O1Qkm6SBytCjhW6aySIgG1gez8AyWklG5LifkwZUr77AoSEFwYifKcCcs+6GAA6cWrE6McYuwrHYuuXq/R68oCa5RwE6Q3h0UVaL7DIXgfRm7/xLm3ZulodkbjZHYBruArc3/K9pAzBxo9LcEcQejybDZ94buhwQHZjp5y6mm1CHYt6SzhhSkUK6QsprHc7qRU5eD/u6J1GsBQHpwSFblSNKtt4HnJmjt4EOho6Y4/y2dKHWQt6HnVwq9HBMmhKT7AZiZsnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHc5XfsGgm9Pnr0ydl/EGCvoHSU1aCHnH5d1IajVg+I=; b=YdhKv8bCrNeTqmPHNC+YsIurOnZNcuA4esQkflWRykHcXvps9QiBJsr+hPTO1cAlijx+8O+q68+5GvdJndEai6Ko6jCWy27IciE4S5j08pz5k1gN+58Doqlr3MgDnWTzgx4+B6WJ+od1bARcwpTxbz3wD70pVFnqQtJiJkXdazc= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 06/10] block/iscsi: drop unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:44:01 +0300 Message-Id: <20200528094405.145708-7-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db9226ef-d621-415a-0786-08d802ebb565 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:605; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mut6eXP7bTq2HUEjWdfA0isUjjeqw7QqnmSkmepTHzL/na8feVQ1UT7hN/XIhSUj8A90Aj4BUUvE4JthogvWLKTFf79aSaRkHPFhyjm0yd9q2IpEoCbHc1m+9rZYWoqHEzV5DgtFM66zABi3DADIh0bRD7YNNMUGa57lgKFbXtGhhhU9iM8AvaxXBN6G86Ag3JuCgOAvHH3ZDKLXFvKxr4NIXCzAohJ8XbuSRS6w1kwPDxPTIXQd4aZ/9Ldd1BRocZFqYTQTTzAfLwyMeaM+x6a0AlaCfZbMQZaBDlRzfb1b3GlWz3+aa1TZxuxOtRPEfhYgNXOJy4PRBO9mJRHWvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(4744005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: C6D2z1ldNG5zXyHh7dvWGQYgphNaLmCqde5EFmHpOA/LpA2sV5nJ2DSuVfn5lxLtYjq9tlwqgeg9tVZpfD9AC6qafBKosOXdlUeVVhQJvv6ngUhSAurwKAZ6UH9+sGcrA+UoevXUhB740vH1XRaSXRkLi1NQXvM9p8y/k3NVWbjOCCAWUEwqIsTCAu6tk2tGITSrVdGxWz8bKxhYIKxcdWUDn+J9PEsqc/enDFYC2Iy/8Oq8JKeT9IoiidXqaqLev+3u3G4x1S3r5YEGgpRJjw35k4XhCf2y4qIJSLHZuUbmRiuaJ/xKaxmDEoaAtYdeXJwkMTiILsFvmvi2Y3Y+3bqkDgZdKORc07h53tvMs6IULZaesFRSYrK/U5cylb+q1nXesT6sa1qWIZxqPnQBgYa2dGczC16FGlFnDs7WVLLzSg52bDVA6ZnUvoOlgGXzFy62YxLqDCBfmAqEKisWIb6p5wTyR94KQQ9kiaH1fZ0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: db9226ef-d621-415a-0786-08d802ebb565 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:25.8709 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oGhz7qhzZLo2UF2QwrDcJZ5gJ4v9Iu5EE8RCbqot2T0f9rTs9aKdC7d3I/6ReHKluYGOT+QAif+yPfdEQ71tFZV8JUrqDWzOSJ0mbDYtoIk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We set bdi->unallocated_blocks_are_zero =3D iscsilun->lbprz, but iscsi_co_block_status doesn't return 0 in case of iscsilun->lbprz, it returns ZERO when appropriate. So actually unallocated_blocks_are_zero is useless (it doesn't affect the only user of the field: bdrv_co_block_status()). Drop it now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index a8b76979d8..767e3e75fd 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2163,7 +2163,6 @@ static int coroutine_fn iscsi_co_truncate(BlockDriver= State *bs, int64_t offset, static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { IscsiLun *iscsilun =3D bs->opaque; - bdi->unallocated_blocks_are_zero =3D iscsilun->lbprz; bdi->cluster_size =3D iscsilun->cluster_size; return 0; } --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659321; cv=pass; d=zohomail.com; s=zohoarc; b=iY6W31ZcFPdeAmyYTUpMN0bStj3mgPxFjc8XGnD9T9VwqZ7yxBXXfba1jIor4NetYUqN+9SXlh6e7ZOQwZdRhorMWtK4otGRORK5UIy+l6/9HL/0El5X7eFKCO8I6Pw/L0QdsMVw4CxeOL7HrmYonkZeDeCXHUglnbC/LZWLnhM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659321; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6+1x7EXNSbCuGOrfKL4P8zLdvIM/Rf8PKZbdc9UbQGA=; b=R79ZS6EDxDVb98zV6/mp/D8K2eEC9vrps/Pi4WIqQFWj816ClhHG3smgTKoIEPeds4X8aq3wwqtLaTXOUZpEyqX5DKIqyetTuytpmUXyB5xZ5upCJfP0ZA2EbBg6BORjKP7WMug6JMi8gQjxVAlNJk3sqtTdkcGvPB3FzzBVChA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659321076284.9781570146773; Thu, 28 May 2020 02:48:41 -0700 (PDT) Received: from localhost ([::1]:53506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF9T-0000Gc-T7 for importer@patchew.org; Thu, 28 May 2020 05:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5W-0008QK-6l; Thu, 28 May 2020 05:44:34 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5V-0002k0-Bh; Thu, 28 May 2020 05:44:33 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:27 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:27 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJ4UF7MnCnbIweq3zB4Z4NzNfMoj4goPDeJKagHN6pfQISNwRFImhhItMB51MLxq+p2Oi4v+MVxjt3lfn1jsos6NeGccjrzQPbpaaoFHrl2JR7jin/mFrMEJtd/PwdnAImdnJzZiggaoe0deAhCNTsdtRiUJns7mBNcR23nPJUS/r+Sf6nFAUekR1HiqPhtgrhO5Oif9auNJh5L7ASeGKQ8UB8OTUD76JYlMYWY1J8kEFujGfENSE36diuMRkvZQKQiaAsSfHNPG+CWPt0/eClI7DpZrabuDbpotri859SIR9GEOI4eoR0onAA6+xjERpvQLSkwQZgg2Y3wP/G9zSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+1x7EXNSbCuGOrfKL4P8zLdvIM/Rf8PKZbdc9UbQGA=; b=IwK6KYBL36nvRY6VhpWCPrCrbmi/+Wb1vDrCvrZuj9LdmNoeEX+cbyI7N1xvUbUmOaZnYUX1aa0kdTFMxsb2NTUAD8vhNBQDHXA1R/dywjHds8KGicJJPm8r+mJyhUMajt0tNMu3ksqQ/EXpdoure5FwUWh+ayGurk7u+XgAdXCsx1JYvsOQNw1JCYJbIz4GUMb41h74JTiJry0kpPtw3DZN7dezG0PG5lypMCHoU+y9+KQU2aGkkM2VXvLh+KlajR2PkcitFyuqZ6TGm2RlKjTE06awdSlAqX8kVeK48tK0lEaMryasZKUIhgg+bV7fx6LsIfH/Ki7wPqO/XvXyPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+1x7EXNSbCuGOrfKL4P8zLdvIM/Rf8PKZbdc9UbQGA=; b=Ne1jb0sY1K5pGT+EgRvHrdSQ2L+Wg2Jthtnx5fQ+FyqfyF5sSNAUlTnaARzhB/aCR4N9zUhVRGV0/jl64UzuhUBLcPKPgaixGZDjGL4cElsT9dfv3+ROmLo3t6ifSP6gOFWLh0zED0AgFtx9blU2O8bJyLAzIzxq/YMxEexmsek= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 07/10] block/file-posix: drop unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:44:02 +0300 Message-Id: <20200528094405.145708-8-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64531379-329e-4536-659d-08d802ebb610 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:83; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NXqbzKCz+o1n8HAot9vLWjk/m0P3rdeosP6NLLM3twKewLqEOPzkRisEaY0TGECWQo73RsypGKpFg+QzMa9ju0J17/PvCjPMCLhPS4MF2zDM+iQIU1Fqk4cn9ZDQEUZ/wqMN3QVPC5Db3hBdmm4O5ziOGd+iO1TcAKxflqcarnjxNRIyZvU/ahXPQvzLJdAwLpMbe6iKXCz09R6prnfOJmDH1JxP2dbMAsf9ByO/yZMk6Mb0rbvuJRFdLANVCVGwAZNtAh+v0HyTtL7D5DVFgpYVWitL9ktyS8a9D3d8FKEna2HftoSamZVIKW2Q6GhDD3TROUE/0BB2ixZx6OqwMQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(4744005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: aRbezgcIiKW9Qa3ZjbhrbS7Y9piYeEQfVqbELUplCJRfIPuAE8Mbz3l7QmDWNjGr/cI+sFs/mIdXp9z7or63UjpbAOo3xwzrS4w7aXjlW8jnejxY5K1Y2aT5OVqFtJAivf5buJ/LIYtl9oW1MAxRXUbiMHbje5N5qAh9KgOd1Hkjm+ni7Y47YnuLcgRmWn/nQipUDVQSiCQBB8kH9iFKvHyzqAywJGLO6HoGGxk70JrKpRb6t5EIPhH4oSwFO0DYF96puSGqtkk1HfaGoU0rsdDYug3+yfEuaN8lkiJkGcalGGJQFTLVzWfQXRzTGa/l9sApIL22FB3EVdtGg3IrmwHz6H3r+ArBxgsa1ug4n5yNEF/L09udRNBj1WA2gXhfwk+pwuvcumF4X12090c7U9BGTTcClPo2usLSVskZK/Jh0VcF1taCT71VGEFb5k7U9uJyWsZVHL8omwbnpEMlVhQgVlpNSu8Pn5R/HQ9IGV0= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64531379-329e-4536-659d-08d802ebb610 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:26.9705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C7GHuNFJpX4wrm36BOniuvsmm76SA34xVS80fW7c8nkrzyjo4sDoGqpC/u1HUP6vuwTXUZJL2kOlCSL46vtJoqPSN5bGTLMUZdkzntWXHNI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" raw_co_block_status() in block/file-posix.c never returns 0, so unallocated_blocks_are_zero is useless (it doesn't affect the only user of the field: bdrv_co_block_status()). Drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/file-posix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 3ab8f5a0fa..d86ea57769 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2878,9 +2878,6 @@ static int coroutine_fn raw_co_pwrite_zeroes( =20 static int raw_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { - BDRVRawState *s =3D bs->opaque; - - bdi->unallocated_blocks_are_zero =3D s->discard_zeroes; return 0; } =20 --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659338; cv=pass; d=zohomail.com; s=zohoarc; b=YgFgEqvJq47qXvx54YhqtxDfJ3NMIDpq47OED5HYY/vS68ypAzXaAq57WGQZvmtBK+vefDbt/seUTLuHtYi3po4JTRgOZBLx5LiBjtYp0dQyNqnhJuQwGD9mLfnuD4ALXjvVlg2vCb8rOwLbwulOT04OoYTUvsnchVll/oBx3XY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659338; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sRnHMeD2MW2hH0F3F96FcK8yHt50+xxCKvFJzvOyi8I=; b=TrpfSPWQr8sk8/8GFJsFVhCpt1+wOKyojY3t8RJShdCr7C1HzilnjL9LLs4/u7uIQ2or4aZOpZUTJdwubMcljAiPb9xuY5qvOOhfsWJ63XUv9xb6E9eSP9yw8S9Dnty6uPw3QOcS1hYYcoIDans84sD59u1yVY9JCCHLl1iqIPw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659338993331.09902948187835; Thu, 28 May 2020 02:48:58 -0700 (PDT) Received: from localhost ([::1]:55066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF9l-000148-OM for importer@patchew.org; Thu, 28 May 2020 05:48:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37678) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5Z-0008TY-1Z; Thu, 28 May 2020 05:44:38 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5W-0002k0-PW; Thu, 28 May 2020 05:44:36 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:28 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:28 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAz1+pKE/lY4zyL9YOrR9vX6cAric8NPUA5oQtTLrDTDpOnF/Joh8Lx3VNajoQixA8IVXmU84Zwz/J7uP0d77te4+95n4aDjH2ry+J0AMS06jVQt4Qn9P7OWCbU6clJOrS7GsGe84wINySAutInK5F6QR3by+i0c4xPdsJNzevRD/D+WgJDV7j+cLd5/wlWvGg8AHM/fUiivh7SfkIS4RSGsDqMWYjT412YJW5JcypxFF/jIkNZ2psyDPrYL0gWohl7XKUdwcVwp2Zg287PYEbPnrl3Q8kVh4uhbsx45y4RglQwLqmgGi116wC+8wwdw3BEE+hdL7DpulnH3JYqQ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sRnHMeD2MW2hH0F3F96FcK8yHt50+xxCKvFJzvOyi8I=; b=aRnqYUn0jPY8vS5Zkjp/87ZoAlIl+s/DV85knfpVV9/Qn1Qs+QRqW3aq9kEQD2NTK1CRDFsPBvvhZamooZlWcrj6F49b4MFlGOZhgefu5kuThSmxtqHsmf4N9gnrZWCQFIWdYJMGHxiy4Ni5a9pmnqGFRv2b5GqvF0FO9gi1o2oLyngKkZjPTClxRTZJgUoHYPcuVA5botp0QVAS2UtRjcBICzUFhT0a6G8Abm6TpwbKNmb/qrAEnmqMp7i89Xug0UmLqvjaHZMVlKlLXe7zO1fdli+UWlHTit2m+e1H60Eu2fUgvz0XuHeTRfI01rUJiNQY2leaomEqA1G6f+Aa4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sRnHMeD2MW2hH0F3F96FcK8yHt50+xxCKvFJzvOyi8I=; b=a9FwwMs565M011cjy0iIETFPoOXmOrStfR3g2Et8m8V0zgOXqIUJuHAmjrukhbnaFstMcceU5s+WGpg/IxaFwgsEvk8QDVQulo4qyoTAw/Vj6oivXDbEU3X7baiKBnNNF9rzF5LElcD5wkxB3Og0JHD59AWMG5dq0Ek2vmVcGNo= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 08/10] block/vhdx: drop unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:44:03 +0300 Message-Id: <20200528094405.145708-9-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ac82830-3999-4962-1104-08d802ebb6b0 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:85; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CBcXqhD4gp0s88nBJ213dsrB8Jg8AXozmMGA+WoYeBbxwjQ7fIeShGA9LBFIGZrHH7p2vbj78zYqodPhqek+yp+MCodh72ox9ay98qTfOu5ES8V+sg2USOObZlKg7/BXIMT7kUspe2YjWN/pNqEkPTIUzXXONDGWr5jLKUquEabhMcCogvwe32/fJX90pjzK1VCnWC77RYpDd9Uz4iXhKy6LJQyEeHfUD0VJ3KVpLXTvNBEJwGxJDPTNL8wqeYNzECb4QcR0u8qF305CiTteDXiG50keQTKJUJ9+4DDzsVfAjh13K08lGpC3DviEA6Q5wbGVpgthuTJz5wOUJcL0cA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(4744005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: Wo8T3eoYz3uYY4m+ScIvNZsAKvEpa2ADBLJ2HAWRBKhWknqU7vsn70iJZcql1Q4n6dg+LfwTEvglCUCcpDT8b4giR8HEwoNK7CpBcIaO7Z6BPc9F4k2oijmd6c12HLmWD6HJGB3bbTIQJckBCmkWtktMP/dZ1L8DxQE7zVFwL/a/PH0iTcPr+gOeBfUdJM5ybfR3UO/N82sLt6lLAeYYlQaP/PEf/JswIahwMN5mHih2Zt2Ko0h9gRjj943MctKzhF5zz2zbr0IylyoJBZLQdIbjrUmXCKM/5NjkxEOXm2ZKo/vvKnVCG67FYxb8Iwv7jNh7Rl1PQN4jfaiS5foQihg3jVvBIefpVw7HgJKyEQGQV/Xu9ZzMuJZxvfWmHgQV41f7HBNaIbbeZLQeDdWSD3a8kokJGQhKr5RuhMDXTd6BDN6mR/IEsVhZ78pxxLoajw3xXVsLGpB0dAXLiOyC9tEwdPV4E+vTQbhZl810GYg= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ac82830-3999-4962-1104-08d802ebb6b0 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:28.0244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aJ6NWCrXM6iryhMCvPrUfKi8kars33rCzNC87DsP/R8ajp+/QWOys8ba5r1MFTpWxAIFJ8L9Rkwyx5zwP1T5bPkD2rimxGx8PnUrzMPifNs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is always assumed for it in bdrv_co_block_status(). unallocated_blocks_are_zero is useless (it doesn't affect the only user of the field: bdrv_co_block_status()), drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/vhdx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/vhdx.c b/block/vhdx.c index fa9e544a5e..645dc4b4f4 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1164,9 +1164,6 @@ static int vhdx_get_info(BlockDriverState *bs, BlockD= riverInfo *bdi) =20 bdi->cluster_size =3D s->block_size; =20 - bdi->unallocated_blocks_are_zero =3D - (s->params.data_bits & VHDX_PARAMS_HAS_PARENT) =3D=3D 0; - return 0; } =20 --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659270; cv=pass; d=zohomail.com; s=zohoarc; b=baH9qcUdCWHL9UIZ+9D3l/m25d8L0JfaH/Y9qTybUptiH1DPU0L9A/pbA7qRu9R2+u62iBFJLIIUHn0W2BBbQVXlFP/gvdxj6PQrxSGAU+o1pnt/uHzQmb4Q7dcvDIEgE2NDl4Y9zhtLeCh3S21YAiaWgjyC9+RCnYhEJ0+jZQ8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659270; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yccz3O5k943jonAMowBmqTccPbxV/xryPKKT4XoPbaY=; b=Jn26+0lW8D/iybBsEb/64ZuvugpsaaGgBuwgoQo2OfMi8vEGCDvltgfkY5AHo/nzWcvx0ZnCuvYLbiYBNpCFAkqGi01pwfjCUVqVgoTwI3W3O5WwvI54nQJ14lRenQzGiWoGvwDwWi9P2r16har9rqGyshcwCYXCw8KYZXeVr3Y= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1590659270132461.49857390354043; Thu, 28 May 2020 02:47:50 -0700 (PDT) Received: from localhost ([::1]:48146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeF8e-00063T-Qn for importer@patchew.org; Thu, 28 May 2020 05:47:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5a-0008UY-Vk; Thu, 28 May 2020 05:44:40 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5Z-0002k0-LJ; Thu, 28 May 2020 05:44:38 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:29 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:29 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haJXJc8jSVN/Ctlguio6DhXdv9VVtyLok5iFPft/ywFP+gvAYC4J3tC4kHMHn7fxsh0BSC0rIpEGlmRCnPo4gQzur6h+spjMnL4wOWi/OFjJgYE45XJ5o2Xm9DI9+XxQZkiY+ELf5B+6uwSB7wp/027jvD0TeBTHC7lvl5ral/BHLtZsKI12iB1XYuzGLEtJG0T05y//GyVsHOxaETzvP/I+p7o0vbak1KjsNkHw5rt1d/LaPqmyjIcT83MJ9uN5CVytzwLKuVoP6oOXwqFsMq/jG+nXGOcaBzMS3fuLdZdhY7U2/zPHNcY7jyWxPncz3EfcVjfSEIe+T58y/FbwHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yccz3O5k943jonAMowBmqTccPbxV/xryPKKT4XoPbaY=; b=lrd9Lt6xb2euoYoUh+mRmLUShsCC9paeDrR5xBdd0PnaNF5yCYXQ8B384vsMPaPsK9V/wysX5lw9m4uYxzHbN7Ol4rkI/9tKzT9bf7bjMQEUdSTYI1txybZXN/9ZbXsDhRuBFqVQIJKaG17swbQ1Msu7geZRR3xGFAKCvWfeGv+KRx/Sa4p6+u1gigN69Z3X+ntn5biOqr9Q6pC31HAgtDNY+uo9Iwobxpz78lId54Op3uRwhpgigJrtjU3fzxmCOnn3NcHaxuxsVjIIHQXajCx1ocWwLdA5qBdtmkE19zXnx0SZXGkMKI9E6kabNu7XZRgkJkPcMDpQl17PDUU0Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yccz3O5k943jonAMowBmqTccPbxV/xryPKKT4XoPbaY=; b=Jj5SbT4A7PG7y1y7elPaGaXu954aSMDpBarJXIQTstuIgpWtwjydJEj+z/fnUvlotjeP5LBFrOkMRfM+0qORCU9A+UxUUn2KtzGSFT2Wo3Eao3IJDbQYqzT7KTS/K5gA96L+u+5jylpXVPZrYOZRb6tAY/fmzd6AwgGMlAc4MTU= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 09/10] block: drop unallocated_blocks_are_zero Date: Thu, 28 May 2020 12:44:04 +0300 Message-Id: <20200528094405.145708-10-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ddd06205-4a63-46ac-9f62-08d802ebb752 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TQ1QOpeI47QD+EF9w6gv1wG1AelhRY8xZ52b8M0Oem6uXHP4O9D+1+wjrWXRpRc0DIqXVMsgBMya1/nsX5IHJT+938utuPlRIPELzcifROVWQqOZBoyA4TlSvzX54MFTwUuU6i/Xxr3kacff+mnYAD887fIu3P4QukT1r0Jnr8uPyOgwsbUoznUwW1AX9nnin2KGSaPFvb7XvGI108rSZGUKsdHHJR0pr+2K7lFlOf7AqsHdCHPn8Tw8BuihRSkODR37tREgG9TivmMG7MN7G+i+wS33ishYsEfay8OxQK6by3xnadV7TIW6uzZLWoFGf4Mc2Lc5hqXY6IT6askXkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 7ZRYpJXKPLYWe1wQQicoLKlMkdd/Tk7BdPCWB9RW5m8JB2ieuJO6xKnz3Se1Dpka675/bZBh6MH1CpR9zVJ5RVPX0cxRt+K07Qb5Bjroq7Qo+3nhZQ/XSN8u9RDTx8hRQKbeL9gpY8lHy9amhPdP1sqHIvr3mgXraXE4Ek2Fa11TSsS2nPMlTa+WsDGUIaSPGp3+C+R/j7BaCDF3/VwTn30qef/dJ5cdn640oQY07ZKQVnpwldjf915cJdJ3VtXhIBZ23H4tV2x9hDRutox6VFM/o8r6E5g2tnlqxy4C2n4M9+Drs/JMkpwexG0Uj40zbJsJDKofFr3dhTZNadqH2srxtT6iHkmeQkmkjCCuOsKlVCYE6WpnNH1JrPuOi8WZXhMt8AeWS51LgBpHMrg6xxecz2dAIEgIsw82JZv7aBacDdEX+ptQ43x8WAoJntBPzsQpITCI/fZnp7iusNzv2bvwxznskNbJINhl7t66kcY= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddd06205-4a63-46ac-9f62-08d802ebb752 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:29.1291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: baXAGN4W8RX/9PuptongtuzDCdDYzTnMTH6q15+suQxGhr2SdcWQfHDwm43CKwo9O2bJIzanGm5ucm5WdeLsZwlZSYriWvVm5W5p39bqhGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently this field only set by qed and qcow2. But in fact, all backing-supporting formats (parallels, qcow, qcow2, qed, vmdk) share these semantics: on unallocated blocks, if there is no backing file they just memset the buffer with zeroes. So, document this behavior for .supports_backing and drop .unallocated_blocks_are_zero Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/block.h | 5 ----- include/block/block_int.h | 12 +++++++++++- block/io.c | 9 ++------- block/qcow2.c | 1 - block/qed.c | 1 - 5 files changed, 13 insertions(+), 15 deletions(-) diff --git a/include/block/block.h b/include/block/block.h index 68699ebbfa..ceb9defb58 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -21,11 +21,6 @@ typedef struct BlockDriverInfo { /* offset at which the VM state can be saved (0 if not possible) */ int64_t vm_state_offset; bool is_dirty; - /* - * True if unallocated blocks read back as zeroes. This is equivalent - * to the LBPRZ flag in the SCSI logical block provisioning page. - */ - bool unallocated_blocks_are_zero; /* * True if this block driver only supports compressed writes */ diff --git a/include/block/block_int.h b/include/block/block_int.h index 791de6a59c..faeeef1706 100644 --- a/include/block/block_int.h +++ b/include/block/block_int.h @@ -123,7 +123,17 @@ struct BlockDriver { */ bool bdrv_needs_filename; =20 - /* Set if a driver can support backing files */ + /* + * Set if a driver can support backing files. This also implies the + * following semantics: + * + * - Return status 0 of .bdrv_co_block_status means that corresponding + * blocks are not allocated in this layer of backing-chain + * - For such (unallocated) blocks, read will: + * - fill buffer with zeros if there is no backing file + * - read from the backing file otherwise, where the block layer + * takes care of reading zeros beyond EOF if backing file is short + */ bool supports_backing; =20 /* For handling image reopen for split or non-split files */ diff --git a/block/io.c b/block/io.c index 6f9507f718..ddcd533c5d 100644 --- a/block/io.c +++ b/block/io.c @@ -2386,7 +2386,7 @@ static int coroutine_fn bdrv_co_block_status(BlockDri= verState *bs, =20 if (ret & (BDRV_BLOCK_DATA | BDRV_BLOCK_ZERO)) { ret |=3D BDRV_BLOCK_ALLOCATED; - } else if (want_zero) { + } else if (want_zero && bs->drv->supports_backing) { if (bs->backing) { BlockDriverState *bs2 =3D bs->backing->bs; int64_t size2 =3D bdrv_getlength(bs2); @@ -2395,12 +2395,7 @@ static int coroutine_fn bdrv_co_block_status(BlockDr= iverState *bs, ret |=3D BDRV_BLOCK_ZERO; } } else { - BlockDriverInfo bdi; - int ret2 =3D bdrv_get_info(bs, &bdi); - - if (ret2 =3D=3D 0 && bdi.unallocated_blocks_are_zero) { - ret |=3D BDRV_BLOCK_ZERO; - } + ret |=3D BDRV_BLOCK_ZERO; } } =20 diff --git a/block/qcow2.c b/block/qcow2.c index dfab8d2f6c..72ed3bf305 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -4973,7 +4973,6 @@ err: static int qcow2_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { BDRVQcow2State *s =3D bs->opaque; - bdi->unallocated_blocks_are_zero =3D true; bdi->cluster_size =3D s->cluster_size; bdi->vm_state_offset =3D qcow2_vm_state_offset(s); return 0; diff --git a/block/qed.c b/block/qed.c index c0c65015c7..a2dd952699 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1514,7 +1514,6 @@ static int bdrv_qed_get_info(BlockDriverState *bs, Bl= ockDriverInfo *bdi) memset(bdi, 0, sizeof(*bdi)); bdi->cluster_size =3D s->header.cluster_size; bdi->is_dirty =3D s->header.features & QED_F_NEED_CHECK; - bdi->unallocated_blocks_are_zero =3D true; return 0; } =20 --=20 2.18.0 From nobody Mon Feb 9 01:32:23 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=none dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1590659427; cv=pass; d=zohomail.com; s=zohoarc; b=OQ9UHlV2rJPJDkZYFj6V4viZtzLuYMmIcEa7szEUIqT8CZiWh50xrw67RKNE5/mHC4T9hoTahv+XrmgkGtrS7vZPRh20cvyeTgkhVaZJN+W8ckBg5GGSrihylPB6cz7waapj+lX89WYGTG7ZQ+EqLI3Lf8eASk8zT7a1X/q1sPc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590659427; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+aE2yYUwYV4BpjdOm1rjPDIEmnj2o3YLrx3WA1dK4PE=; b=izKyofd2hCq3jBLCQswCOKYxy4BdI8krIinaxCZ9bNKaffMyDVERYNceca+79rkOjYC2QcLflYKm5kWIJ1BQoKl/dgV8cLUxG8MYc9tFZrbQ1y+hhGAmFSbweTtb1yaK6uJyYaJ7eDaarn9omllEW2WYL3gVseIlChwoyv0Ygg8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 159065942755740.298743716695185; Thu, 28 May 2020 02:50:27 -0700 (PDT) Received: from localhost ([::1]:59262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeFBB-0003AM-37 for importer@patchew.org; Thu, 28 May 2020 05:50:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5h-00006Z-4C; Thu, 28 May 2020 05:44:45 -0400 Received: from mail-eopbgr80134.outbound.protection.outlook.com ([40.107.8.134]:2978 helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeF5b-0002k0-Ho; Thu, 28 May 2020 05:44:44 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM7PR08MB5366.eurprd08.prod.outlook.com (2603:10a6:20b:10b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.17; Thu, 28 May 2020 09:44:30 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::a408:2f0f:bc6c:d312%4]) with mapi id 15.20.3045.018; Thu, 28 May 2020 09:44:30 +0000 Received: from kvm.localdomain (185.215.60.178) by AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19 via Frontend Transport; Thu, 28 May 2020 09:44:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HeR7UTkYyWqWZ3Gmnl3TFMto+r1gRYnhp5vFmaUksVWsYHIH8G9bMd1fGbh375d/jkZRvoJyh1vBtdodmquG4yRF/B74M8vE9zOu1dpEiVruAtSi3eEB5QhOQ952POwOvR9flioQwmSX1nuDuhGZxWBrY45gyAg6lCK/elIaaFrhg/rHKORvNl2wnXctdbKHsp5960NawfHREnexvT1+EHRIYSJMPSY9yVZ9yYIvj4NkQ/cjLuTzLPt6Yb68KDxU+26Kt9koX8WaYbGQ4Cz6W42tz47GKvjMT9CpIvS2+LzbkaJRz8S3TIUF32r93+5HNzA5qr2gljykoeOTHkT/pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aE2yYUwYV4BpjdOm1rjPDIEmnj2o3YLrx3WA1dK4PE=; b=YrqujVMVlAasfIMzgk1+wQKC/B2DXRFpvvCwzZnApNb0QrVqDL3ozQLzwT00EkDx6UpdfBaDY+N9TDft7/3UM1acK13JIDaS1Ua6sCqD0P7I8NkZYbjrgL/hgdMIL9/yeYy887ZYvONiJxxOtwzIrOp+uQsZ3/mW5etfUvxU0RfTOPN1+N0gE7wiWgsSHh29VYtgY5A4DVsJh7bG0p9UaDzZXyhA5+1qQROiC+tcs4Z0Nc1RgeVZPKGMjuIcgckt6g03QQMQLpw0Hp88fhu4EOK/Ru2xuJiIquu7unR9wPXjjYwmmvD76OqyPcfWQNsP9gg/mrC4q2YQOms5jFr74A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+aE2yYUwYV4BpjdOm1rjPDIEmnj2o3YLrx3WA1dK4PE=; b=sxJpWk7iROFvDBkDenal8Sgq6ELSOP/kIOPFd3DozHe7dX8h8FNl4I0F7uB36jUO+HuR+Sp15keKfOkHgWqlZntzppRzigSl7OjUKG7IhVUTPaA9K5xEy0BILK8Y0Z/sz5mflSwe6jlk2GfkwrcCyPJ6jr2TA2kCxfchCmq8RAw= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Subject: [PATCH v3 10/10] qed: Simplify backing reads Date: Thu, 28 May 2020 12:44:05 +0300 Message-Id: <20200528094405.145708-11-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20200528094405.145708-1-vsementsov@virtuozzo.com> References: <20200528094405.145708-1-vsementsov@virtuozzo.com> X-ClientProxiedBy: AM3PR05CA0089.eurprd05.prod.outlook.com (2603:10a6:207:1::15) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Mailer: git-send-email 2.18.0 X-Originating-IP: [185.215.60.178] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 892a2302-1733-48fc-1df0-08d802ebb800 X-MS-TrafficTypeDiagnostic: AM7PR08MB5366: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-Forefront-PRVS: 0417A3FFD2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I+P5QLGL4jdEFRvEPUZWI7xbkXaI7X2XlR5BqQ7VCY2OOjdLhFK4sPEmTKfx+VJ6S/gVHILv/Qyk+3bQLwlDn5pvf8ISK2gHETb6hzFkJoxRtxbNXYhZ2sUTkIvRlk09oD/w2OZDEKOMcf+EumydWjA0H25tkgPeGpzbwbBg5qFg48NjmQ/2hTglsTiT19SukBWqWBbVKTD8x81kgHmmJMxtoPi5t+RLBsN5lQTDr35mVH0rrPUq2BQnQfzuKPPZt3wdHrItjVcb5seYVzoTCfpjWrEP5lYU9eAXLhQbAuFt3xldJx7FMB/2qaqMtzdOd2J4uWmnFWUSd+Vp7/G9Lw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39850400004)(366004)(136003)(346002)(376002)(396003)(2616005)(86362001)(316002)(5660300002)(7416002)(956004)(1076003)(6916009)(66946007)(83380400001)(6666004)(66476007)(66556008)(8936002)(4326008)(6512007)(36756003)(478600001)(8676002)(26005)(186003)(16526019)(2906002)(52116002)(6486002)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: eInFMrdpYytw5fJ+ODj9Woun7XulAFQuJjL0PIlh4QiJbxJTL64SwK39scoUqF0HO8ywLiEWxa8+03ERSesYVK6h2WWwzDUtkjudLg7PWf5gAQlkYCLtN7xTvd4B5u/kDAYHE0S5X7cRY72mvz00rApJswGCK3SlTIEN9szYl+aBLo7FRn6Vwt1POiJMH7B6/ylguqf9ckcMT6Tw2ioVW97niA4oJSpol0UxN/9JyB4N2ZH9DHPAiA1dMUDxe1193tnwKEOM2ymkG7fCySydgDIfzKKt7+JbyWujX9ad+C02ED/vi9eCormAG/2rgyTH8SvAtWwNiFSSrlPiboKqXsDGDGbxg+putB1WKcR5O6d4zkHqWMY5D9GnHQOBhEEA2pUUI5wng4xiR8qYtFsnWvOobUeZZpiwDSmi41K39X+YSmVm32ET3gs91CQEspfTx+79Zo0PBUdsN1achZVE6GVWwqi8/jurH4Mi0xTj+Tk= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 892a2302-1733-48fc-1df0-08d802ebb800 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2020 09:44:30.2800 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K8mattUKXvaxPiLuPhG0zbNcVy6A5YTov8tV3y3s/1k93c/NN1qgOf2a0j3xBGQ4YY8xtosL6HSyD9GAidxc0JRzI6piYRw0iQh9YvLmeVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5366 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.134; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/28 05:44:18 X-ACL-Warn: Detected OS = Windows NT kernel [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, fam@euphon.net, vsementsov@virtuozzo.com, ronniesahlberg@gmail.com, codyprime@gmail.com, sw@weilnetz.de, pl@kamp.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, den@openvz.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Eric Blake The other four drivers that support backing files (qcow, qcow2, parallels, vmdk) all rely on the block layer to populate zeroes when reading beyond EOF of a short backing file. We can simplify the qed code by doing likewise. Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/qed.h | 1 - block/qed.c | 64 +++++------------------------------------------------ 2 files changed, 6 insertions(+), 59 deletions(-) diff --git a/block/qed.h b/block/qed.h index 42c115d822..3d12bf78d4 100644 --- a/block/qed.h +++ b/block/qed.h @@ -140,7 +140,6 @@ typedef struct QEDAIOCB { =20 /* Current cluster scatter-gather list */ QEMUIOVector cur_qiov; - QEMUIOVector *backing_qiov; uint64_t cur_pos; /* position on block device, in bytes = */ uint64_t cur_cluster; /* cluster offset in image file */ unsigned int cur_nclusters; /* number of clusters being accessed */ diff --git a/block/qed.c b/block/qed.c index a2dd952699..ece8b9bb60 100644 --- a/block/qed.c +++ b/block/qed.c @@ -849,56 +849,18 @@ static BDRVQEDState *acb_to_s(QEDAIOCB *acb) * @s: QED state * @pos: Byte position in device * @qiov: Destination I/O vector - * @backing_qiov: Possibly shortened copy of qiov, to be allocated here - * @cb: Completion function - * @opaque: User data for completion function * * This function reads qiov->size bytes starting at pos from the backing f= ile. * If there is no backing file then zeroes are read. */ static int coroutine_fn qed_read_backing_file(BDRVQEDState *s, uint64_t po= s, - QEMUIOVector *qiov, - QEMUIOVector **backing_qiov) + QEMUIOVector *qiov) { - uint64_t backing_length =3D 0; - size_t size; - int ret; - - /* If there is a backing file, get its length. Treat the absence of a - * backing file like a zero length backing file. - */ if (s->bs->backing) { - int64_t l =3D bdrv_getlength(s->bs->backing->bs); - if (l < 0) { - return l; - } - backing_length =3D l; - } - - /* Zero all sectors if reading beyond the end of the backing file */ - if (pos >=3D backing_length || - pos + qiov->size > backing_length) { - qemu_iovec_memset(qiov, 0, 0, qiov->size); - } - - /* Complete now if there are no backing file sectors to read */ - if (pos >=3D backing_length) { - return 0; - } - - /* If the read straddles the end of the backing file, shorten it */ - size =3D MIN((uint64_t)backing_length - pos, qiov->size); - - assert(*backing_qiov =3D=3D NULL); - *backing_qiov =3D g_new(QEMUIOVector, 1); - qemu_iovec_init(*backing_qiov, qiov->niov); - qemu_iovec_concat(*backing_qiov, qiov, 0, size); - - BLKDBG_EVENT(s->bs->file, BLKDBG_READ_BACKING_AIO); - ret =3D bdrv_co_preadv(s->bs->backing, pos, size, *backing_qiov, 0); - if (ret < 0) { - return ret; + BLKDBG_EVENT(s->bs->file, BLKDBG_READ_BACKING_AIO); + return bdrv_co_preadv(s->bs->backing, pos, qiov->size, qiov, 0); } + qemu_iovec_memset(qiov, 0, 0, qiov->size); return 0; } =20 @@ -915,7 +877,6 @@ static int coroutine_fn qed_copy_from_backing_file(BDRV= QEDState *s, uint64_t offset) { QEMUIOVector qiov; - QEMUIOVector *backing_qiov =3D NULL; int ret; =20 /* Skip copy entirely if there is no work to do */ @@ -925,13 +886,7 @@ static int coroutine_fn qed_copy_from_backing_file(BDR= VQEDState *s, =20 qemu_iovec_init_buf(&qiov, qemu_blockalign(s->bs, len), len); =20 - ret =3D qed_read_backing_file(s, pos, &qiov, &backing_qiov); - - if (backing_qiov) { - qemu_iovec_destroy(backing_qiov); - g_free(backing_qiov); - backing_qiov =3D NULL; - } + ret =3D qed_read_backing_file(s, pos, &qiov); =20 if (ret) { goto out; @@ -1339,8 +1294,7 @@ static int coroutine_fn qed_aio_read_data(void *opaqu= e, int ret, qemu_iovec_memset(&acb->cur_qiov, 0, 0, acb->cur_qiov.size); r =3D 0; } else if (ret !=3D QED_CLUSTER_FOUND) { - r =3D qed_read_backing_file(s, acb->cur_pos, &acb->cur_qiov, - &acb->backing_qiov); + r =3D qed_read_backing_file(s, acb->cur_pos, &acb->cur_qiov); } else { BLKDBG_EVENT(bs->file, BLKDBG_READ_AIO); r =3D bdrv_co_preadv(bs->file, offset, acb->cur_qiov.size, @@ -1365,12 +1319,6 @@ static int coroutine_fn qed_aio_next_io(QEDAIOCB *ac= b) while (1) { trace_qed_aio_next_io(s, acb, 0, acb->cur_pos + acb->cur_qiov.size= ); =20 - if (acb->backing_qiov) { - qemu_iovec_destroy(acb->backing_qiov); - g_free(acb->backing_qiov); - acb->backing_qiov =3D NULL; - } - acb->qiov_offset +=3D acb->cur_qiov.size; acb->cur_pos +=3D acb->cur_qiov.size; qemu_iovec_reset(&acb->cur_qiov); --=20 2.18.0