This is a grab-bag collection of cleanups, at least one of which
have been on the to-do list since day we abandoned compatibility
with upstream softfloat.

The compare changes have near-zero effect for float32/float64, since
that's the way they are implemented now.  For float128, it simply
removes unneeded complexity.

For floatx80, this fixes bugs vs pseudo-denormals which were only
fixed in floatx80_compare_internal.  We could just remove them, as
these interfaces are not used by x87.  But I thought it'd be best
to keep the interface compatibility for now.


r~


Richard Henderson (10):
  softfloat: Use post test for floatN_mul
  softfloat: Replace flag with bool
  softfloat: Change tininess_before_rounding to bool
  softfloat: Name rounding mode enum
  softfloat: Name compare relation enum
  softfloat: Inline float32 compare specializations
  softfloat: Inline float64 compare specializations
  softfloat: Inline float128 compare specializations
  softfloat: Inline floatx80 compare specializations
  softfloat: Return bool from all classification predicates

 include/fpu/softfloat-helpers.h |   27 +-
 include/fpu/softfloat-macros.h  |   24 +-
 include/fpu/softfloat-types.h   |   28 +-
 include/fpu/softfloat.h         |  336 +++++---
 target/i386/ops_sse.h           |    8 +-
 fpu/softfloat-specialize.inc.c  |   32 +-
 fpu/softfloat.c                 | 1305 ++++---------------------------
 target/arm/sve_helper.c         |    8 +-
 target/arm/vfp_helper.c         |   14 +-
 target/hppa/op_helper.c         |    7 +-
 target/i386/fpu_helper.c        |    8 +-
 target/m68k/fpu_helper.c        |    6 +-
 target/m68k/softfloat.c         |   70 +-
 target/mips/msa_helper.c        |   10 +-
 target/openrisc/fpu_helper.c    |    4 +-
 target/ppc/int_helper.c         |   13 +-
 target/s390x/fpu_helper.c       |   22 +-
 target/s390x/vec_fpu_helper.c   |    2 +-
 target/sparc/fop_helper.c       |    4 +-
 target/unicore32/ucf64_helper.c |    6 +-
 target/xtensa/fpu_helper.c      |    6 +-
 tests/fp/fp-test.c              |    2 +-
 22 files changed, 547 insertions(+), 1395 deletions(-)

-- 
2.20.1

Patchew URL: https://patchew.org/QEMU/20200515190153.6017-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200515190153.6017-1-richard.henderson@linaro.org
Subject: [PATCH 00/10] softfloat: misc cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d6c1572 softfloat: Return bool from all classification predicates
d5219e0 softfloat: Inline floatx80 compare specializations
174c114 softfloat: Inline float128 compare specializations
5359fcf softfloat: Inline float64 compare specializations
dfbd82c softfloat: Inline float32 compare specializations
4800e27 softfloat: Name compare relation enum
7fa3297 softfloat: Name rounding mode enum
7cd2649 softfloat: Change tininess_before_rounding to bool
e7c55dd softfloat: Replace flag with bool
a611c6d softfloat: Use post test for floatN_mul

=== OUTPUT BEGIN ===
1/10 Checking commit a611c6d2a057 (softfloat: Use post test for floatN_mul)
2/10 Checking commit e7c55dd7e0d5 (softfloat: Replace flag with bool)
3/10 Checking commit 7cd2649f0ce0 (softfloat: Change tininess_before_rounding to bool)
ERROR: space prohibited before that close parenthesis ')'
#67: FILE: fpu/softfloat.c:3877:
+                  || (zExp < 0 )

total: 1 errors, 0 warnings, 143 lines checked

Patch 3/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/10 Checking commit 7fa3297e0cfe (softfloat: Name rounding mode enum)
5/10 Checking commit 4800e2753ad9 (softfloat: Name compare relation enum)
6/10 Checking commit dfbd82cf4b75 (softfloat: Inline float32 compare specializations)
7/10 Checking commit 5359fcfe6a48 (softfloat: Inline float64 compare specializations)
8/10 Checking commit 174c1143cfd1 (softfloat: Inline float128 compare specializations)
9/10 Checking commit d5219e08fe69 (softfloat: Inline floatx80 compare specializations)
10/10 Checking commit d6c1572c791c (softfloat: Return bool from all classification predicates)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200515190153.6017-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com