[v1] ramfb: a bunch of reverts and fixes

[PATCH 0/5] ramfb: a bunch of reverts and fixes

Gerd Hoffmann posted 5 patches 4 years ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200422100211.30614-1-kraxel@redhat.com

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch failed

Test FreeBSD passed

Test asan passed

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Alex Williamson <alex.williamson@redhat.com>

There is a newer version of this series

include/hw/display/ramfb.h    |  2 +-
hw/display/ramfb-standalone.c | 12 +------
hw/display/ramfb.c            | 59 +++++++++++------------------------
hw/vfio/display.c             |  4 +--
stubs/ramfb.c                 |  2 +-
5 files changed, 24 insertions(+), 55 deletions(-)

Expand all Fold all

[PATCH 0/5] ramfb: a bunch of reverts and fixes

Posted by Gerd Hoffmann 4 years ago

Even though these are bugfixes this is probably 5.1 material
at this point ...

Gerd Hoffmann (5):
  Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"
  Revert "hw/display/ramfb: lock guest resolution after it's set"
  ramfb: don't update RAMFBState on errors
  ramfb: add sanity checks to ramfb_create_display_surface
  ramfb: drop leftover debug message

 include/hw/display/ramfb.h    |  2 +-
 hw/display/ramfb-standalone.c | 12 +------
 hw/display/ramfb.c            | 59 +++++++++++------------------------
 hw/vfio/display.c             |  4 +--
 stubs/ramfb.c                 |  2 +-
 5 files changed, 24 insertions(+), 55 deletions(-)

-- 
2.18.2

Re: [PATCH 0/5] ramfb: a bunch of reverts and fixes

Posted by no-reply@patchew.org 4 years ago

Patchew URL: https://patchew.org/QEMU/20200422100211.30614-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/5] ramfb: a bunch of reverts and fixes
Message-id: 20200422100211.30614-1-kraxel@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200422011722.13287-1-richard.henderson@linaro.org -> patchew/20200422011722.13287-1-richard.henderson@linaro.org
 - [tag update]      patchew/20200422100211.30614-1-kraxel@redhat.com -> patchew/20200422100211.30614-1-kraxel@redhat.com
Switched to a new branch 'test'
9cc0b6a ramfb: drop leftover debug message
b28e041 ramfb: add sanity checks to ramfb_create_display_surface
29a55a8 ramfb: don't update RAMFBState on errors
0ff0dd8 Revert "hw/display/ramfb: lock guest resolution after it's set"
db523e5 Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"

=== OUTPUT BEGIN ===
1/5 Checking commit db523e55cde0 (Revert "hw/display/ramfb: initialize fw-config space with xres/ yres")
2/5 Checking commit 0ff0dd8955d3 (Revert "hw/display/ramfb: lock guest resolution after it's set")
3/5 Checking commit 29a55a84e498 (ramfb: don't update RAMFBState on errors)
ERROR: braces {} are necessary for all arms of this statement
#46: FILE: hw/display/ramfb.c:89:
+    if (!surface)
[...]

total: 1 errors, 0 warnings, 36 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit b28e041cc318 (ramfb: add sanity checks to ramfb_create_display_surface)
5/5 Checking commit 9cc0b6a2ea69 (ramfb: drop leftover debug message)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200422100211.30614-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com