[v2] ramfb: a bunch of reverts and fixes

[PATCH v2 0/6] ramfb: a bunch of reverts and fixes

Gerd Hoffmann posted 6 patches 4 years ago

Diff against v1
Download series mbox

Test docker-mingw@fedora passed

Test checkpatch failed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200429115236.28709-1-kraxel@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>

include/hw/display/ramfb.h    |  2 +-
hw/display/ramfb-standalone.c | 12 +-----
hw/display/ramfb.c            | 78 +++++++++++++----------------------
hw/vfio/display.c             |  4 +-
stubs/ramfb.c                 |  2 +-
5 files changed, 34 insertions(+), 64 deletions(-)

Expand all Fold all

[PATCH v2 0/6] ramfb: a bunch of reverts and fixes

Posted by Gerd Hoffmann 4 years ago

Even though these are bugfixes this is probably 5.1 material
at this point ...

v2: reorder patches, add patch #6, pick up acks & reviews.

Gerd Hoffmann (6):
  Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"
  Revert "hw/display/ramfb: lock guest resolution after it's set"
  ramfb: drop leftover debug message
  ramfb: don't update RAMFBState on errors
  ramfb: add sanity checks to ramfb_create_display_surface
  ramfb: fix size calculation

 include/hw/display/ramfb.h    |  2 +-
 hw/display/ramfb-standalone.c | 12 +-----
 hw/display/ramfb.c            | 78 +++++++++++++----------------------
 hw/vfio/display.c             |  4 +-
 stubs/ramfb.c                 |  2 +-
 5 files changed, 34 insertions(+), 64 deletions(-)

-- 
2.18.2

Re: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes

Posted by no-reply@patchew.org 4 years ago

Patchew URL: https://patchew.org/QEMU/20200429115236.28709-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200429115236.28709-1-kraxel@redhat.com
Subject: [PATCH v2 0/6] ramfb: a bunch of reverts and fixes
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
606207c ramfb: fix size calculation
3503c7b ramfb: add sanity checks to ramfb_create_display_surface
78b6e20 ramfb: don't update RAMFBState on errors
96648223 ramfb: drop leftover debug message
329fe4e Revert "hw/display/ramfb: lock guest resolution after it's set"
9fed95d Revert "hw/display/ramfb: initialize fw-config space with xres/ yres"

=== OUTPUT BEGIN ===
1/6 Checking commit 9fed95ded1c1 (Revert "hw/display/ramfb: initialize fw-config space with xres/ yres")
2/6 Checking commit 329fe4e6f68d (Revert "hw/display/ramfb: lock guest resolution after it's set")
3/6 Checking commit 96648223c33a (ramfb: drop leftover debug message)
4/6 Checking commit 78b6e20dc09f (ramfb: don't update RAMFBState on errors)
ERROR: braces {} are necessary for all arms of this statement
#46: FILE: hw/display/ramfb.c:87:
+    if (!surface)
[...]

total: 1 errors, 0 warnings, 34 lines checked

Patch 4/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/6 Checking commit 3503c7b9d778 (ramfb: add sanity checks to ramfb_create_display_surface)
6/6 Checking commit 606207c60d25 (ramfb: fix size calculation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200429115236.28709-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com