[v1] misc: Trivial static code analyzer fixes

[PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

Philippe Mathieu-Daudé posted 11 patches 4 years ago

Diff against v2 v3
Download series mbox

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200321114615.5360-1-philmd@redhat.com

Maintainers: Andrew Jeffery <andrew@aj.id.au>, David Gibson <david@gibson.dropbear.id.au>, Alistair Francis <alistair@alistair23.me>, "Cédric Le Goater" <clg@kaod.org>, Andrzej Zaborowski <balrogg@gmail.com>, Fam Zheng <fam@euphon.net>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, John Snow <jsnow@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Joel Stanley <joel@jms.id.au>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Markus Armbruster <armbru@redhat.com>, BALATON Zoltan <balaton@eik.bme.hu>, Peter Maydell <peter.maydell@linaro.org>, "Hervé Poussineau" <hpoussin@reactos.org>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

block.c                    | 2 +-
blockdev.c                 | 2 +-
hw/gpio/aspeed_gpio.c      | 4 ++--
hw/i2c/pm_smbus.c          | 1 -
hw/ide/sii3112.c           | 2 +-
hw/input/adb-kbd.c         | 1 -
hw/isa/i82378.c            | 8 ++++----
hw/scsi/esp-pci.c          | 1 -
hw/timer/exynos4210_mct.c  | 3 ---
hw/timer/pxa2xx_timer.c    | 1 +
hw/timer/stm32f2xx_timer.c | 1 -
11 files changed, 10 insertions(+), 16 deletions(-)

Expand all Fold all

[PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

Posted by Philippe Mathieu-Daudé 4 years ago

Fix trivial warnings reported by the Clang static code analyzer.

Philippe Mathieu-Daudé (11):
  block: Remove dead assignment
  blockdev: Remove dead assignment
  hw/i2c/pm_smbus: Remove dead assignment
  hw/input/adb-kbd: Remove dead assignment
  hw/ide/sii3112: Remove dead assignment
  hw/isa/i82378: Remove dead assignment
  hw/gpio/aspeed_gpio: Remove dead assignment
  hw/timer/exynos4210_mct: Remove dead assignments
  hw/timer/stm32f2xx_timer: Remove dead assignment
  hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
  hw/scsi/esp-pci: Remove dead assignment

 block.c                    | 2 +-
 blockdev.c                 | 2 +-
 hw/gpio/aspeed_gpio.c      | 4 ++--
 hw/i2c/pm_smbus.c          | 1 -
 hw/ide/sii3112.c           | 2 +-
 hw/input/adb-kbd.c         | 1 -
 hw/isa/i82378.c            | 8 ++++----
 hw/scsi/esp-pci.c          | 1 -
 hw/timer/exynos4210_mct.c  | 3 ---
 hw/timer/pxa2xx_timer.c    | 1 +
 hw/timer/stm32f2xx_timer.c | 1 -
 11 files changed, 10 insertions(+), 16 deletions(-)

-- 
2.21.1

Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

Posted by Aleksandar Markovic 4 years ago

12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé <philmd@redhat.com> је
написао/ла:
>
> Fix trivial warnings reported by the Clang static code analyzer.
>

Philippe,

It would be useful and customary for this type of fixes to provide here the
environment you used for obtaining the warnings (clang version, configure
parameters, and all needed elenents to repro the warnings).

Regards,
Aleksandar

> Philippe Mathieu-Daudé (11):
>   block: Remove dead assignment
>   blockdev: Remove dead assignment
>   hw/i2c/pm_smbus: Remove dead assignment
>   hw/input/adb-kbd: Remove dead assignment
>   hw/ide/sii3112: Remove dead assignment
>   hw/isa/i82378: Remove dead assignment
>   hw/gpio/aspeed_gpio: Remove dead assignment
>   hw/timer/exynos4210_mct: Remove dead assignments
>   hw/timer/stm32f2xx_timer: Remove dead assignment
>   hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
>   hw/scsi/esp-pci: Remove dead assignment
>
>  block.c                    | 2 +-
>  blockdev.c                 | 2 +-
>  hw/gpio/aspeed_gpio.c      | 4 ++--
>  hw/i2c/pm_smbus.c          | 1 -
>  hw/ide/sii3112.c           | 2 +-
>  hw/input/adb-kbd.c         | 1 -
>  hw/isa/i82378.c            | 8 ++++----
>  hw/scsi/esp-pci.c          | 1 -
>  hw/timer/exynos4210_mct.c  | 3 ---
>  hw/timer/pxa2xx_timer.c    | 1 +
>  hw/timer/stm32f2xx_timer.c | 1 -
>  11 files changed, 10 insertions(+), 16 deletions(-)
>
> --
> 2.21.1
>
>

Re: [PATCH-for-5.0 00/11] misc: Trivial static code analyzer fixes

Posted by Philippe Mathieu-Daudé 4 years ago

On 3/21/20 1:01 PM, Aleksandar Markovic wrote:
> 12:47 PM Sub, 21.03.2020. Philippe Mathieu-Daudé <philmd@redhat.com 
> <mailto:philmd@redhat.com>> је написао/ла:
>  >
>  > Fix trivial warnings reported by the Clang static code analyzer.
>  >
> 
> Philippe,
> 
> It would be useful and customary for this type of fixes to provide here 
> the environment you used for obtaining the warnings (clang version, 
> configure parameters, and all needed elenents to repro the warnings).

https://clang-analyzer.llvm.org/

$ sudo dnf install clang-analyzer
$ ../configure
$ scan-build make

> 
> Regards,
> Aleksandar
> 
>  > Philippe Mathieu-Daudé (11):
>  >   block: Remove dead assignment
>  >   blockdev: Remove dead assignment
>  >   hw/i2c/pm_smbus: Remove dead assignment
>  >   hw/input/adb-kbd: Remove dead assignment
>  >   hw/ide/sii3112: Remove dead assignment
>  >   hw/isa/i82378: Remove dead assignment
>  >   hw/gpio/aspeed_gpio: Remove dead assignment
>  >   hw/timer/exynos4210_mct: Remove dead assignments
>  >   hw/timer/stm32f2xx_timer: Remove dead assignment
>  >   hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning
>  >   hw/scsi/esp-pci: Remove dead assignment
>  >
>  >  block.c                    | 2 +-
>  >  blockdev.c                 | 2 +-
>  >  hw/gpio/aspeed_gpio.c      | 4 ++--
>  >  hw/i2c/pm_smbus.c          | 1 -
>  >  hw/ide/sii3112.c           | 2 +-
>  >  hw/input/adb-kbd.c         | 1 -
>  >  hw/isa/i82378.c            | 8 ++++----
>  >  hw/scsi/esp-pci.c          | 1 -
>  >  hw/timer/exynos4210_mct.c  | 3 ---
>  >  hw/timer/pxa2xx_timer.c    | 1 +
>  >  hw/timer/stm32f2xx_timer.c | 1 -
>  >  11 files changed, 10 insertions(+), 16 deletions(-)
>  >
>  > --
>  > 2.21.1
>  >
>  >
>