From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791388; cv=none; d=zohomail.com; s=zohoarc; b=VqtMvYNXKgGyxXpb0ff0d+U1Xc2INwarzN0dyUaQOImF42LMNmpXmYOem+PXAvQpXPeujsK80VdDSYofLUZQ5gqmwurS7D6K/olwXK8h5HEtA+7QWlQkATENFQXBWIBWnXroopd83FFeQXkb0ZCY/HmQcy3TBYregcj/zAQ9C1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791388; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eMQ8dVIZnYJPrg4MRf01ROr1UWOuRMuavJ9h1G8fyNE=; b=TJmOs2c4kulMam2GaGxkAutJ9drPGwYyNPj2lURyfidIkJZnq+mpIKbt7rAPIN0LMSeCC6E121PznmaKxPID2RgZ6+egdCnUU+20SCuUg4GYBEHVyUCepsOMfuUTnUxV2eeWBP+JRxgRPi3uU7ZlHV5l4+v4Cid2SRXewpFO9zA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791388635575.390466918264; Sat, 21 Mar 2020 04:49:48 -0700 (PDT) Received: from localhost ([::1]:35588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcdP-0006d6-Ef for importer@patchew.org; Sat, 21 Mar 2020 07:49:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34523) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcaK-0000Pj-6H for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcaJ-0006JM-6U for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:36 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:52668) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcaJ-0006J4-3N for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:35 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-p52w7N_xNnq_aS2t7NQ9Ag-1; Sat, 21 Mar 2020 07:46:33 -0400 Received: by mail-wr1-f70.google.com with SMTP id l17so3771852wro.3 for ; Sat, 21 Mar 2020 04:46:32 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id d5sm2667163wrh.40.2020.03.21.04.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eMQ8dVIZnYJPrg4MRf01ROr1UWOuRMuavJ9h1G8fyNE=; b=OMfDhfGBrTPSZDPZ4Nl3XO6mYEV3Jrt7wwV5TCeZ+x/9mcmvnOl3S9mDiI3gFXGEasxOtI 2OKm0MQyWlCNueHVHDb8DNbZmznUcNuVTy09RkDq7zIXR4cjlecwchWfEA25IvCSAIZl51 FWjIqfMW/VBcspyTY5xM2r9TAdBMGas= X-MC-Unique: p52w7N_xNnq_aS2t7NQ9Ag-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kX8C0eEcHvhI8rcexY79cvumv+xMMYTkKA4klDytxcc=; b=MlWXlhqwC4Hbe4Wrz4ihkn6Tam3e4nLMZp1LGyY6kRhXF++lLX+d670Y6NFqCBtvKX F/ezyxNouIYJpu7V24Bt0I2HYB3x3l3psJ3VpBt80v+1U7c4xDpM5Owya3Z31xHxTwk0 uySwJZX0R1IMgOhwYOG4Sov2qEqLknTSFcVYSe7H8wGC6MZISq/USlHxt6zGLmJs4bBz ZLKWxBwIPgFlPYHIDGrexaF0bHFdg9yGwlZhINv46KxTx0UtgkfzTcHvjWEs5vHND2Ag NiT0xA9oO54yWCMQozzOp8T3B0Qc4XBszAtqtIE1E6wmJk0qCINDAgZi92/3qgpxl9Fe ihIg== X-Gm-Message-State: ANhLgQ2/p3P0CY04awKHFfKxmWK/rSfMelSN3GBiEq2/wcmK5Oat7E6Y 6+9WKXaJj3k3uksDjeI47TgV4eIbJRPnXRcPtYEo+DMptlXB5Oe1VCbt/DUR/9JJaZsQzCpcIoJ CkISgQyu+05bm0xQ= X-Received: by 2002:adf:c44c:: with SMTP id a12mr17986423wrg.172.1584791191385; Sat, 21 Mar 2020 04:46:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuT3XdAAValv75OTSe0ODvom2WIFeUB+FFeo0vbikqEyZ6JXGrJZ1M3aU7NlUmOl7P+zQMFFA== X-Received: by 2002:adf:c44c:: with SMTP id a12mr17986387wrg.172.1584791191199; Sat, 21 Mar 2020 04:46:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 01/11] block: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:05 +0100 Message-Id: <20200321114615.5360-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: block.c:3167:5: warning: Value stored to 'ret' is never read ret =3D bdrv_fill_options(&options, filename, &flags, &local_err); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index a2542c977b..908c109a8c 100644 --- a/block.c +++ b/block.c @@ -3164,7 +3164,7 @@ static BlockDriverState *bdrv_open_inherit(const char= *filename, parent->open_flags, parent->options); } =20 - ret =3D bdrv_fill_options(&options, filename, &flags, &local_err); + bdrv_fill_options(&options, filename, &flags, &local_err); if (local_err) { goto fail; } --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791313; cv=none; d=zohomail.com; s=zohoarc; b=YUJ8JwZBxo+mLKmk7KtADggLQOznrhUC5+MrvPI/3kwSxDNGStSzqgfk+95jy5wkl7meqxWxumGV1H/oeo9tdGhYJM6QL/9a88WlPmBaSk7XrCmLPRsy6kAE2v0V92gJXxNGALDFwCx6eTX/gpA7ZKe0r60tt0vwrbMNMrj4Pgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791313; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2U6ARuvMvLKS+fqGTEoijz7r0B3fBwOwTnOOBFQNRAw=; b=EwmoEd3WHI6k28/VUo/mCVZg0RZ/TE6bA3lVzLuMMYYSrAX8Wt6mBtkA36k5E7s95om9pieVhyAkGYjjXmCOr2VGkPzinkP28dqcoS7q/J67nyEeKFBYkNU2c5Xke56QlOz2/9tNq4dMzOeQLu2UonYTVN1tg9cOCc9n3RlhDi4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791313799217.83021355194182; Sat, 21 Mar 2020 04:48:33 -0700 (PDT) Received: from localhost ([::1]:35560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFccC-0003n3-KM for importer@patchew.org; Sat, 21 Mar 2020 07:48:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34629) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcaQ-0000fN-AI for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcaP-0006MT-8t for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:42 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:33854) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcaP-0006M2-4o for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:41 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-ejGea2KcNeS8ugV50Xp4-g-1; Sat, 21 Mar 2020 07:46:39 -0400 Received: by mail-wr1-f70.google.com with SMTP id e10so2409633wru.6 for ; Sat, 21 Mar 2020 04:46:38 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id c5sm15737698wma.3.2020.03.21.04.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:46:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791200; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2U6ARuvMvLKS+fqGTEoijz7r0B3fBwOwTnOOBFQNRAw=; b=hG0rl2bjnZjvxE4P50y5Ax9avstqt+14e6VKPuifVfdsJmMbHwnwA8mnytOUZ8uCHC0XF6 AuC3kiLod4yzLfr5p9ID183qnCizLkHOUUXufosbiP/VT7j7DaOuTnTJ1rFSE9jQ18yXH0 RyNxrcSnUmn9azrARJnwHwPW5nlGTeQ= X-MC-Unique: ejGea2KcNeS8ugV50Xp4-g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ez+E9s5mwrT8B9y8nVUYgFPf3iN6ckUcWWVa90evmD4=; b=h1HXJq6o/kWdlm1TUOUYqbKYW84Eu6HeARjkBCrMoQO0JDUX0RWk96GvsvyFWW6cJy 6yfbi/eI7opMcaFW7/oeogLVK4codu/a0wTjokedRNQ1zj/1cPfZ9bSWyzsOiCk0J/Y+ p6hq8jutRJP7LEPcXOmOxSPYIk9XMVsmlmAWY6+xVjNHUFXAyfchc2CR6vi9k7Qxngmn j9d9+ZcbcpreCwN/mAlhNc4VbibXtMlIPG5aW48mfkq+BiquHuiFNVyWNla8I0mIrpLS Olya3+c2LFzun+cCRKj1c1n/HiUfNk9nDP5U4hvjed6GUBFuNZZywyCxOddwC8P9kQ77 idDw== X-Gm-Message-State: ANhLgQ1OBrY97SqE3VA92y+QDjn01ViQnpcYOWZl0TR6gE7BhzowFVHf e9z886qMbX8zeaGRWIkwohYFts2hqAN6RMJ29seLmebrwEX8D3sbnpjNjEGKW59AewydEdELyja DmWIdlrFZzAejg8o= X-Received: by 2002:adf:fe4c:: with SMTP id m12mr17443690wrs.96.1584791197954; Sat, 21 Mar 2020 04:46:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vve8rRdAc9j+mXkmu1X1eacNa+hVewhm4BXzBkCSSJNfv/v/it6Xfe4h3p5TbOBoIKzQ44UBQ== X-Received: by 2002:adf:fe4c:: with SMTP id m12mr17443653wrs.96.1584791197777; Sat, 21 Mar 2020 04:46:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 02/11] blockdev: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:06 +0100 Message-Id: <20200321114615.5360-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC blockdev.o blockdev.c:2744:5: warning: Value stored to 'ret' is never read ret =3D blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index fa8630cb41..6effd5afaa 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2741,7 +2741,7 @@ void qmp_block_resize(bool has_device, const char *de= vice, } =20 bdrv_drained_begin(bs); - ret =3D blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); + blk_truncate(blk, size, false, PREALLOC_MODE_OFF, errp); bdrv_drained_end(bs); =20 out: --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791404; cv=none; d=zohomail.com; s=zohoarc; b=KwisXKXj+4n3/Z8ReMrvIbsUb8Bm/GnFwhrWduLRitYPkTvzQHa7lB/9L90yFBQTErhPltR+02LUmyrrY8aQhcPmc8H++/kCSnF+vWUn1a5WM8003j08ZzaqoUjwW3tOO/krdmrfaQC3Nj+w80DRLsKi8JrXl2UTvRoNQbJ+lx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791404; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kQDd9EbUfb0uuK6iIsTzZMSp5qbZytglJrEh2QYroHU=; b=Q5wzL1NgJFID6xTiQwf/eFqpeqGx+x3xQS4IgvIhErOhqjZvuoNwh/NleJ5yv46vl83yDKrDJi9ObokU4u/K74trozQAwclv3lVeH8cw3fQkjKaD+IOujWQFstacm/ouxXZDq7wUKMY8fFr7uzSQ+Qm/Du55lhKNHrEmkJPZmok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791404847118.1933565290816; Sat, 21 Mar 2020 04:50:04 -0700 (PDT) Received: from localhost ([::1]:35592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcdf-0007DM-Jd for importer@patchew.org; Sat, 21 Mar 2020 07:50:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34675) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcaW-0000zE-RS for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcaV-0006RQ-SE for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:48 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:33888) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcaV-0006R4-Ns for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:47 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-9XMnFl3QMz24FJrC1AOHUQ-1; Sat, 21 Mar 2020 07:46:45 -0400 Received: by mail-wr1-f70.google.com with SMTP id b12so4215754wro.4 for ; Sat, 21 Mar 2020 04:46:45 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id i67sm13424296wri.50.2020.03.21.04.46.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kQDd9EbUfb0uuK6iIsTzZMSp5qbZytglJrEh2QYroHU=; b=LhhPvsHqd+9gdTRral+5RxEjZBb55LkoxKF+M+4woFoWlVl+baD2C8ezh9bEWIunzAXSje O/orR9E5XjJosjOliB1f/hibVjX1f6VjNcsja31nVJ4ebaoLz4XzBg6dbHAM1v0SM7fqVZ KMeqTee5qLPCkZE4k7fTRcyuGG0l7OM= X-MC-Unique: 9XMnFl3QMz24FJrC1AOHUQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7jHPzgLUxabSngeicFYbktzokTE6KbRJJJ5XQsCuGXA=; b=fFSjHh4f0tzltGK6FCynw8xMGYrJyqFIsBgy9zrOkgaibK6PmpxJBCw2qyDEaQOqno XXyM6siefXXfM7JdplhjLAXZXlCdHDaLRG8hNJy4WDvKOz6aeoFgOb8jATMqY2AtTUKv PZ+2BmHUy8XxtHefjwcOWkOcjI2vbBUzzMczw+BYx3paNhguMfd2rxiYSolc+Sqt6Pma yw6RZKZGAJA5PbA/YkHw+XmkTAnUJXcrDesVX3Pqay0bXUJVce5NuhfU9gC20s6RyXHO FvKQE7EyL9fpxN63FoGL235H3z7VXRT9rNBjTGmYTE1uz+xs+p5/HuYdzzBZlZ8eQID/ GlWA== X-Gm-Message-State: ANhLgQ0NON0Dl0x+4r0Y87OyDGiyuhEO6QeafGPrHEgGRlj0zaVGFFQS hSOL37MjtYdosEHgBfnVBjqqzJGrd+rxfwiJMfUjmmjy+dSap3QVW6/SX1fl0pEyyQ7+e1OTuQG fbcK0pKDmPz2dYCs= X-Received: by 2002:a5d:66c2:: with SMTP id k2mr16786078wrw.408.1584791204442; Sat, 21 Mar 2020 04:46:44 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuFSW+CXcA6YfLipptcKR9ABiJniuj3MZjBTWYLGZb0p+0Bf/8+S0d9XoeCUTxe7T9qj4FMdg== X-Received: by 2002:a5d:66c2:: with SMTP id k2mr16786051wrw.408.1584791204274; Sat, 21 Mar 2020 04:46:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 03/11] hw/i2c/pm_smbus: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:07 +0100 Message-Id: <20200321114615.5360-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC hw/i2c/pm_smbus.o hw/i2c/pm_smbus.c:187:17: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/pm_smbus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 36994ff585..4728540c37 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -184,7 +184,6 @@ static void smb_transaction(PMSMBus *s) s->smb_stat |=3D STS_HOST_BUSY | STS_BYTE_DONE; s->smb_data[0] =3D s->smb_blkdata; s->smb_index =3D 0; - ret =3D 0; } goto out; } --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791514; cv=none; d=zohomail.com; s=zohoarc; b=i/7m388Ow339BSpzBSvtDeoEqWQU492dO8zD35OEWMb3Ggr9Sdow3sPyaZSsZV9NXNapyyIPx8RJ49QIakZUL6wLES35VWAFa1xdU+Jkucp//J6roZlNAXxQAcY1DonJhkKw1qsS+HfLoqTG7s5fx+LSuAGUfC9Ow0VibAAANA4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791514; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=c4GCDGuXxVBz+Q5fzhTo9pG6tPh9hgrqUC7e1TLGPOU=; b=YTij1BDBKvDMFyiQ7666IdaUCyF7s6ZtC5VC/V2XPSEa6f+Jg0svI2mUpEFhyWN8zP59RPYNKHmDnjictaYhKesBEv5o09WjLf8ZPXDnDx/D9x8b8prMTbxunSlG0SWoL025rzkJxYDM1MIsfKp2rp4SCDaBlzJk507l57bb7lE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791514578181.70779147667668; Sat, 21 Mar 2020 04:51:54 -0700 (PDT) Received: from localhost ([::1]:35668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcfR-0002VT-73 for importer@patchew.org; Sat, 21 Mar 2020 07:51:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34813) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcai-0001Le-7U for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcah-0006ae-50 for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:00 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:21483) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcah-0006aG-1l for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:46:59 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485--yLcort2PHGRixcSt5MazA-1; Sat, 21 Mar 2020 07:46:57 -0400 Received: by mail-wr1-f70.google.com with SMTP id o18so767824wrx.9 for ; Sat, 21 Mar 2020 04:46:56 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id y189sm12549500wmb.26.2020.03.21.04.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4GCDGuXxVBz+Q5fzhTo9pG6tPh9hgrqUC7e1TLGPOU=; b=hPY3AvL/rn5OmGMQn6XFbJUp9MOxmkHpe7cJH4dzYGQ0j30UQCT443H7iOlLVP6qsCc8AU oPW0bOxhRvOcRSxWgNGUECuXa2dXc2Mu2Gtt9Anlwqrn9lwmIOcLkbDVa5dYnGQodgl7ht tSXOXFv5v2fBmet2IGzIrJYZWs6emZc= X-MC-Unique: -yLcort2PHGRixcSt5MazA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EI7aeJF1EJiZnbf/LHlroG4oQCKwaeGXEJr4kT4GssI=; b=OJzs3Ak+bznNkJUhuKVOoJ4T/TKfubwRcdDgvlUOAu7utbnV/Ju8D0OsrVcQ3cWezO Yon2d1dF4JjK73rKwwyHszisVv8zoPVauH74Gj8CWXFg+TanUFyIs/n6b31yVI4u/FQ7 mR4TIV2KVcl5hwQnHJvTLvIjFk43XA9qRYuWD6054k52+qzJZX18ynnVllIQOTjQmiD0 /WPD85dAKcWAWs+ybjKGJGhzIeyYIrumm8fQLtoNyIsKwLESR/5+PwPdDOyS03ZxlnJT jsswP7vqm/96d2Stdd1W0pgnhGpFtusmzfPIKn5S3qtvClVnhhz3NPXVfcqgFBKIHhbY Vahw== X-Gm-Message-State: ANhLgQ3nXWf24Irp6+PiBlGv4nC1E7dyRQ1+hdiyFvEV06umKcx5CCTw /PKBvFQZNXd3su3ZYbSsZga3e49rMMPdo+DOiT78RzaBLyXFx2W+kwJSqWekKILZHBPVAeYDtnt Lx5A8cQBUdI5mBh8= X-Received: by 2002:a1c:a950:: with SMTP id s77mr15599448wme.176.1584791215862; Sat, 21 Mar 2020 04:46:55 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvfQ4vrBm8KBgyUaD+hLChCbh5Ae2/d75e8M+xeE+5T8Oik5ZY2x5rINBu/X0yrYPRPHas5yw== X-Received: by 2002:a1c:a950:: with SMTP id s77mr15599432wme.176.1584791215666; Sat, 21 Mar 2020 04:46:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 04/11] hw/input/adb-kbd: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:08 +0100 Message-Id: <20200321114615.5360-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC hw/input/adb-kbd.o hw/input/adb-kbd.c:200:5: warning: Value stored to 'olen' is never read olen =3D 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/input/adb-kbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/input/adb-kbd.c b/hw/input/adb-kbd.c index 0ba8207589..b0565be21b 100644 --- a/hw/input/adb-kbd.c +++ b/hw/input/adb-kbd.c @@ -197,7 +197,6 @@ static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) int keycode; int olen; =20 - olen =3D 0; if (s->count =3D=3D 0) { return 0; } --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791329; cv=none; d=zohomail.com; s=zohoarc; b=Nzv4QoyfU3hGLjKfTMu1iTDYmCQ4oZuh7K6nBHfuGMrHI8LGJQjLlBpzMP1dDNS7ClYx8fKGg/v/Nk2e0FkxkG3HCPT3HYHyTmYWcSQdeZz0mJBwV7hNLI7r/xT3YEWaWEWXVOC1XnmT5jr2D72c3uzNMO/LxrZz9kZ05jYsbEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791329; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s1bdYGQbWSZ25NCXl0o2KnO8CKQKA2aULoROOMscDe4=; b=ZwaeSlvzYDzTwJP6caVlk9IaMlgFtK8JMpgZBPfgiQkLucmJfz3Tz8jbFwDplczYGSV4+WwOUXnDBV1Rf923gTRF9nhcr/IONdZnQ3qh8KwfBdcJFqMOsIUuigkOm3AGqmobaX9b4JxQmr1eZqsgKX+sv1rMSZCIy8YYzbxZmJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791329267774.9713933086621; Sat, 21 Mar 2020 04:48:49 -0700 (PDT) Received: from localhost ([::1]:35564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFccS-0004MX-29 for importer@patchew.org; Sat, 21 Mar 2020 07:48:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34885) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcao-0001fR-UE for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcan-0006fm-T0 for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:06 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:22165) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcan-0006fV-Pc for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:05 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-ddXbYuH5PSuwnYC3VSHbwA-1; Sat, 21 Mar 2020 07:47:04 -0400 Received: by mail-wr1-f70.google.com with SMTP id p2so4174504wrw.8 for ; Sat, 21 Mar 2020 04:47:03 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id r16sm2136019wrv.33.2020.03.21.04.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s1bdYGQbWSZ25NCXl0o2KnO8CKQKA2aULoROOMscDe4=; b=c5NOgfR5zJb/C4n2uoTRrL5ETE/i5wJXzsjqTb6l7hhsoL3CKJvDAgTz/bRUHjJfqDN9ry bS+huaPGr0zFFK1Dhu75ddAKKPmk0K3hicu+0z1Y2Ga23ZuSdGPG2h/jPlw/W+AdAbc6cb Kf5Ie+36WPfLHoaiNWKRTCYEwQhnsko= X-MC-Unique: ddXbYuH5PSuwnYC3VSHbwA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dMq7n4VIHa1l961sBoHohhv0FobQ6UHjUiSLB6JZ4j0=; b=S+rI8wV/lyiiO5aCVmEPrIImr3rIGmTSD3OnGgwt1wjU+vMHaKa8RT5LlMjClyqG9T GLCy7uyrMiFD2Yxp8JMhOGlAf++SSFcswPU9c3/zK3nb7UpoS8HFT2k/YLs7RserLFC0 Q2D0UM7Bj1jnGnNlz69ECfUsMR6687IHc/d4SDPBUieeDrmoDGauY5qoyOdPerPnBwBw Go20UHetgne1WVqDVhppAJ4PyQGNPVFzPFBSIE5q3ixw9RJC80WyoR2JJfwBe0J17sov Ygy6IjNiueSXXI8qsbASAUzoWAZhYbdsPavTAjVzZZO/iBbswCK1lpwwO/IMJyzzwiy3 yMlg== X-Gm-Message-State: ANhLgQ1FQPyUbBGpp2kHpOJOhzfURHz5Z9i05MIkeo/zvJRHIm8dkm2L PFrkZVEYxvoAorDAORWg7xVsZJn0JyYF1mqfDiwjcDgpGg/pAshY4njcPDxXrjvFcxj5VYx1xa2 Ckeen9ztS2Ew7x2A= X-Received: by 2002:a5d:628f:: with SMTP id k15mr10381935wru.404.1584791222591; Sat, 21 Mar 2020 04:47:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2RVU0hT38/VJsO9a/eu91+kjlougjMKfQ/gz0+1oWL8bmhhm7at7naNrtjfseEuRTaRxs0A== X-Received: by 2002:a5d:628f:: with SMTP id k15mr10381909wru.404.1584791222291; Sat, 21 Mar 2020 04:47:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 05/11] hw/ide/sii3112: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:09 +0100 Message-Id: <20200321114615.5360-6-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC hw/ide/sii3112.o hw/ide/sii3112.c:204:9: warning: Value stored to 'val' is never read val =3D 0; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by stands (even if apparently not much use). Thanks for=20 Reviewed-by: BALATON Zoltan --- hw/ide/sii3112.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/sii3112.c b/hw/ide/sii3112.c index 06605d7af2..36f1905ddb 100644 --- a/hw/ide/sii3112.c +++ b/hw/ide/sii3112.c @@ -125,7 +125,7 @@ static uint64_t sii3112_reg_read(void *opaque, hwaddr a= ddr, val =3D (uint32_t)d->regs[1].sien << 16; break; default: - val =3D 0; + break; } trace_sii3112_read(size, addr, val); return val; --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791440; cv=none; d=zohomail.com; s=zohoarc; b=X/Nq45EwZNsimp7j3fFt1ZywC3VP2KNxmER3pCqL0S+D0WtG9EeeQO4gpDk9rsRLQXTvL/rJMH/nW2QbmdE6k4r86mg6znYuldJbjJ8Cplt2kYIFisAmbM+xgAYUIAHEkhb8GbFMrk7rw1bIBAIW28k6mnSA5ESwJ9zhpVRWu+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791440; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aNR2u2S6oJHTNfAafS+3cPQs0kK7tiu5/JdDcxGLqd4=; b=ctQv9DMOnFvZsvICJ9pJ4Jrw+rLhPz07yzWtJHbsjyXOA6lQCydw1SoGVyHOb8jT2kM0V8GrUW5KSrFBLQZZHw5ZwZwROU/b6pRj0rzpVJQEP9HZLGLbdaslD+hzvIh8ziCPhhH1nQutXPm/tiolhoPZIEqyi6qDEjCWaY9+0xQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791440754199.11104015612887; Sat, 21 Mar 2020 04:50:40 -0700 (PDT) Received: from localhost ([::1]:35602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFceF-0008K8-JN for importer@patchew.org; Sat, 21 Mar 2020 07:50:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34949) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcav-0001oi-FR for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcau-0006mI-Cu for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:13 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:32827) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcau-0006lv-8k for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:12 -0400 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-zayRbczbPfm3hldlPf6teQ-1; Sat, 21 Mar 2020 07:47:10 -0400 Received: by mail-wr1-f72.google.com with SMTP id t4so4194608wrr.1 for ; Sat, 21 Mar 2020 04:47:10 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id v7sm12822140wml.18.2020.03.21.04.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNR2u2S6oJHTNfAafS+3cPQs0kK7tiu5/JdDcxGLqd4=; b=Tq/L3856aXpuuOxtrB+E6F7Q221K6zc0EbsoHat46j6Ucl+Gd/3yZkf/gNx8OxjctnD4xz /Y1k5nHNztKxizYd5uFYMYsC6gWIUoAnM2a3YGInzN/+IvWIhTlQpLVqu2L7PZZzWRZlN9 1aWfvnjYXZasJbsQE1OXBP0PBKK8pAk= X-MC-Unique: zayRbczbPfm3hldlPf6teQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=10vzrd1KB4hBe4ZZMwH09166mQI1VXUjkd4JvuSfJzs=; b=uGLxLXLXQs9BxQ2G++p2u87OKLQCqldLa7lB6dIlIN1MGb0xTc5UwKHoZVsbufvhqx SL++kbGjjPB16AjhtGnSiqz+ujebXI7odfBJU6HtauRYwQJZBKED1JNqvtVaJmsoYZIb pwN+TUFKiMJCwzCG+kLJuaP0ohNzWJjWE32O1OULbx71yco3gI8xVB53rsHiyDV7tgHh ExGGmiGT08oWBE72XdQ9FCzGa4X9zPozJ45UmN+KKEI8d1kmu+lPxlubAUpxmKtXkf0Y rJRNT/pDlB0vM775xURiNyTvkpSq7sssd1DfB6PHLeZ09C1y3SwveVMFe7WtjkLo7gYf t6Qg== X-Gm-Message-State: ANhLgQ0fwLCCQmJ4dwXRvk3uxXMxjRP8OqzDspqa3sHX/T/kSctPom+7 lxvl7KNbL8ACBy9GG0wePowg6QL5IY+cG64zXJ/Vt8yFDoWQv2RMxeps89ieVtugYoHvszRLHv0 FyfUBegCMIxPRbXY= X-Received: by 2002:a1c:acc8:: with SMTP id v191mr16571800wme.185.1584791229021; Sat, 21 Mar 2020 04:47:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuEZgHJ9R2CzOVD7FrVhKwfAt4ODRiXCw3f347rqB1NUIjLfREWV9rK0W33q2PNc68qUhcXew== X-Received: by 2002:a1c:acc8:: with SMTP id v191mr16571770wme.185.1584791228755; Sat, 21 Mar 2020 04:47:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 06/11] hw/isa/i82378: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:10 +0100 Message-Id: <20200321114615.5360-7-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Rename the unique variable assigned as 'pit' which better represents what it holds, to fix a warning reported by the Clang static code analyzer: CC hw/isa/i82378.o hw/isa/i82378.c:108:5: warning: Value stored to 'isa' is never read isa =3D isa_create_simple(isabus, "i82374"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/i82378.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index dcb6b479ea..d9e6c7fa00 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -67,7 +67,7 @@ static void i82378_realize(PCIDevice *pci, Error **errp) I82378State *s =3D I82378(dev); uint8_t *pci_conf; ISABus *isabus; - ISADevice *isa; + ISADevice *pit; =20 pci_conf =3D pci->config; pci_set_word(pci_conf + PCI_COMMAND, @@ -99,13 +99,13 @@ static void i82378_realize(PCIDevice *pci, Error **errp) isa_bus_irqs(isabus, s->i8259); =20 /* 1 82C54 (pit) */ - isa =3D i8254_pit_init(isabus, 0x40, 0, NULL); + pit =3D i8254_pit_init(isabus, 0x40, 0, NULL); =20 /* speaker */ - pcspk_init(isabus, isa); + pcspk_init(isabus, pit); =20 /* 2 82C37 (dma) */ - isa =3D isa_create_simple(isabus, "i82374"); + isa_create_simple(isabus, "i82374"); } =20 static void i82378_init(Object *obj) --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791542; cv=none; d=zohomail.com; s=zohoarc; b=Ywpdxe4g443QfdDszwWPUyaw0y1FRYlHTckcnBPSVK2lo9AKBx8Y1tcQjqxZ4FBXFCxt3u0Zl48c5Xr2p2dCR8odatfCptBfK3rqgto+JFb2/3e4PJlnd9yePPwYqqgq+mg9Sj3I3OIsRQF1SAsmJXBJvePHs2+rSGH9OO91/mI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791542; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Yg/uPhRkx9OjPcaTO9vlYALUXN3pIoYxovXY5zX2+JQ=; b=FD4AAAcLwwVDZq62j8YPAMBLSlmROxUCJNq1C1+LmDt1H6OJ7sZJg5AMntvw0hw9cn58vZoAhXW0ZgeySuwG9R6IHQeMQKdsg0ERS0siNCvg/FHFI+hvhVXBAdKuDW9ONBbjbTW5pMfxbHQZqi0V7TbXWhFWQukYHJ0B5Ft6qQQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158479154284158.15284819023623; Sat, 21 Mar 2020 04:52:22 -0700 (PDT) Received: from localhost ([::1]:35672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcft-0003TY-MB for importer@patchew.org; Sat, 21 Mar 2020 07:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35029) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcb1-00021y-Te for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcb0-0006rJ-Oz for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:19 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:20347) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcb0-0006qs-KS for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:18 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-qAmtlP0ZNf2O8sk9dlfF5g-1; Sat, 21 Mar 2020 07:47:16 -0400 Received: by mail-wr1-f70.google.com with SMTP id q18so4181114wrw.5 for ; Sat, 21 Mar 2020 04:47:16 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id y187sm2407206wmd.0.2020.03.21.04.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yg/uPhRkx9OjPcaTO9vlYALUXN3pIoYxovXY5zX2+JQ=; b=ANdBkhE71Ysnxc3IpXx1C31x3TUFRrWyb5W/vYjjlLg/lnLmm154AzmAU2OSfDBsVLIcw1 AcRYKl9fXXczbM+VhuUorGKSZDjOASbmptmkxdXAAFHmWgDyVq3GNeOMCxVLNuYW1cHAMs K41Xy1Afg49MQv+FbcPpDnyKjN0GQnw= X-MC-Unique: qAmtlP0ZNf2O8sk9dlfF5g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8CJ+9lz/G6rwsxDBjnubfjrbrfbpIvcJrGa1k2G4+/Y=; b=rYNrtugX3Kob5TXb4dF78sACYjI5NkKoScMMM4VtcU5cGzE9nLbtqGJz7StkeWmHh3 ZPu1bsmfd46DsYEESRrfvKFFA8xeC3zEEFiVFnx06u3zMyYPtXQXPWJ4yP1VVPgghw4Z 9J2LpyXlFwo5bzrwydV6A38rdFXJ0Vng6KIpynMaof4w/v3fcZzxbjITnkGv9fgwweNv KFJLRPxVqc9MtkDOLdtfCKWPyGWfwjx4yLJnzNdMcyaPzmgKOF2GfwSpPHvlTckFf57N LhKiiuFGKgNpBd5K5Q0TxwUrNDpgIgN+l+A93ooOft7/ZNU0VP3IcP2K+p45yQe2pSnr 7aqQ== X-Gm-Message-State: ANhLgQ2Bf/V20588RoKc7V6S0PocEI6BphW0I6ukMwbC/9l5BO0/oyd0 aOzM/NiCGmk9jfd4DTxeu6EwpRyujJ3O8POybFXn46M5R6NR0GVgZTTYSxXRzDbwpwkiEDewv+Z xO183FvwIK2SMdNU= X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr576577wmd.161.1584791235498; Sat, 21 Mar 2020 04:47:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv3kYG0GXzyCiOia7dq8AGBTEPkdgA9K0YR3lk8tgmzZM3dgpvC+FSCqi8gMIeK6PeKsjCiPg== X-Received: by 2002:a05:600c:10ce:: with SMTP id l14mr576530wmd.161.1584791235271; Sat, 21 Mar 2020 04:47:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 07/11] hw/gpio/aspeed_gpio: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:11 +0100 Message-Id: <20200321114615.5360-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: hw/gpio/aspeed_gpio.c:717:18: warning: Value stored to 'g_idx' during its= initialization is never read int set_idx, g_idx =3D *group_idx; ^~~~~ ~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/gpio/aspeed_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 41e11ea9b0..cc07ab9866 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -714,11 +714,11 @@ static void aspeed_gpio_write(void *opaque, hwaddr of= fset, uint64_t data, static int get_set_idx(AspeedGPIOState *s, const char *group, int *group_i= dx) { AspeedGPIOClass *agc =3D ASPEED_GPIO_GET_CLASS(s); - int set_idx, g_idx =3D *group_idx; + int set_idx; =20 for (set_idx =3D 0; set_idx < agc->nr_gpio_sets; set_idx++) { const GPIOSetProperties *set_props =3D &agc->props[set_idx]; - for (g_idx =3D 0; g_idx < ASPEED_GROUPS_PER_SET; g_idx++) { + for (int g_idx =3D 0; g_idx < ASPEED_GROUPS_PER_SET; g_idx++) { if (!strncmp(group, set_props->group_label[g_idx], strlen(grou= p))) { *group_idx =3D g_idx; return set_idx; --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791677; cv=none; d=zohomail.com; s=zohoarc; b=m5JcHr8oO92BLFxdxXZgXfbB+pnTkDlDR0wJWV7dBptBRry+4szfYAFn9vg480CcXYpyo+oVkJRjUAizM+pXnmPIobkiL6Ah6hsxnrcGsEsz+AZtEM8L5CXMvF1YnTNbO1E/vJEqF8TPVBTNtf72aWoLRwq9KH2kAGwpJPIhfhQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791677; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9RrFXtWXIAKlsNCj4fxVkxendU8386lJ6GdPQwHKuZc=; b=aCTkKtQ9oBUZjdEtL1717iZ5/AM866yjxeBkvQGnvXgPcCbMHDdyiH1Y119ix/1jX7rGH5395zv+a0Q/TmKJalrFUhYGQlTOgP2cJ4WNHNKVUhZ/ex2/xbZXD30P5BBNlVPI0dd+s4EK7Vfcg8EeZnQod+Fj5MHsZjNAyO2CUhI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791677757551.7376360253612; Sat, 21 Mar 2020 04:54:37 -0700 (PDT) Received: from localhost ([::1]:35736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFci4-00076Y-Ga for importer@patchew.org; Sat, 21 Mar 2020 07:54:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35095) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcbB-0002C6-Jg for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcb7-0006uk-Pt for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:28 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:42166) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcb7-0006u6-MA for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:25 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-BytY6CUWPaSXVzA9m0jOJg-1; Sat, 21 Mar 2020 07:47:23 -0400 Received: by mail-ed1-f72.google.com with SMTP id b12so4477643edy.7 for ; Sat, 21 Mar 2020 04:47:23 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id d23sm540531ejk.26.2020.03.21.04.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9RrFXtWXIAKlsNCj4fxVkxendU8386lJ6GdPQwHKuZc=; b=D1TWMwEX9ZHUpzrk/NhxEu5k+MrtcM9xQ6Pu4xlInSC1X0JQ0k6Wbeu2TV+wBD7sT6Gcsl 0VCEVP5T8e/wasSjaaS6Q1H+0zkcCKh+GamgyGabQV1GUkQXlGIwL4IW2O3W2QjpZ6bKWU 8syQvxUyBBT59aM/l3WH7L+GCdhbFko= X-MC-Unique: BytY6CUWPaSXVzA9m0jOJg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9gGzKQU/hca0N/HfH89YEyKKEwjuVATrynJmMDBqHuA=; b=XavToNS5ZtIRJHzVJCVkOpzgsoSneYJGpBWgkSnY4kzA/+WUbcuWMt2/Uejj4O10Wk ONUyc9x9LdMuYZseW//dugfvysDvTvA4StmdDQgrjlXFkiPpcqn5rbg02TCrF2tjYHW8 dlBJnhR5qAGZaAG7tGhy8GyfOn6LBPVMSTWYdtRldTr8BTuE9ZE3FJbpSaj8RnWn/yhX M5RDG6HWzLxXZtQ4uFvAX5v/Cw5MxsYQHf1Mev4NYnidMtI/nO3KJ0cmfoiDObId/dts EGAg8d+ee9EpE1/uaStFiofSH9f5CstUdCEMeRQIehEmxfSaruc+PSOLmt5SI6S2v2Ro Ry1w== X-Gm-Message-State: ANhLgQ0C76IYf28Ki1V3nBc2IlTAG9K0deS7riRd2o7g9gv0LMVY056v +MiK7xIkPhSUHthlgTP37LTlQujpsNu/h1VPXD7b558k4e2iWlypvtPrG90QXL5a+mIfHiGKm9O 0ATjQbtbCI8B2tXo= X-Received: by 2002:aa7:c0cd:: with SMTP id j13mr12145112edp.287.1584791242059; Sat, 21 Mar 2020 04:47:22 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsNje2ZBWZggIXMm+1aJu4RAQiqKLCRY2id164eUSg0Un6tqRjsI5Yaw3McsVqiA0SKAsuv3g== X-Received: by 2002:aa7:c0cd:: with SMTP id j13mr12145088edp.287.1584791241814; Sat, 21 Mar 2020 04:47:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 08/11] hw/timer/exynos4210_mct: Remove dead assignments Date: Sat, 21 Mar 2020 12:46:12 +0100 Message-Id: <20200321114615.5360-9-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warnings reported by Clang static code analyzer: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is nev= er read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is nev= er read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is nev= er read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/exynos4210_mct.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..c0a25e71ec 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,7 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791538; cv=none; d=zohomail.com; s=zohoarc; b=YOsNfD5smgpt3N1LkEl1EbH3TX87LNJ190Y6y3HXsvkAZ4tNIhSmwLttulNQysVdrMyTHWpmPG0Ue3wwBYUXVEBU33O9PPrBBZPM43NQW5mwuOR++lhs6K34yf9ucDAPG89iqDn+T9aCvXmjFEVq30J44gFBKGjPyz1SOzN+evs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791538; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=H2ZxNlM8IiHu0dxI+a0SAXUIREttoqtshJPpfqAJ9kA=; b=Hv4uVjrwSqUWJyr/T+ZeY/Mizkb/OnT9O400NqwWHFsEzpkow+gJcf32O+JIYyqnrfnOtQa80Dts5e7C5vwJrAgXdQIPrajFvPuH6Rb4p6IuHKi6Kt9NVJculnzC0fDlR0+F7iDTfr6XoZbh9JieI0iHQIVkyl2pTfZZd6ydlAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791538350647.7407702359372; Sat, 21 Mar 2020 04:52:18 -0700 (PDT) Received: from localhost ([::1]:35670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcfp-0003Kc-4d for importer@patchew.org; Sat, 21 Mar 2020 07:52:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35197) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcbG-0002K5-V9 for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcbF-00071e-VA for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:34 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:51915) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcbF-00071A-PS for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:33 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-kEFY3LONPUWlafTG-11sCA-1; Sat, 21 Mar 2020 07:47:29 -0400 Received: by mail-wr1-f70.google.com with SMTP id v6so4137819wrg.22 for ; Sat, 21 Mar 2020 04:47:29 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id s22sm11269798wmc.16.2020.03.21.04.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2ZxNlM8IiHu0dxI+a0SAXUIREttoqtshJPpfqAJ9kA=; b=bH35ds0DMoZduKLgjBHWO9f4IJp1Ixr6/U+vBxA8umgGbczJIih/Mel+U6PAYq4D1c6Xo7 VCPcuPUHJ1LiJijEUyNr7X9d79IhgEAwCkA+ME46Gq4VFXFENfEVhMD6CGMHVXigXjaeYP ABThzzCkxrdwxfeD/UxE3Ah855agx14= X-MC-Unique: kEFY3LONPUWlafTG-11sCA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=860B2IkAp+GSKWrMYmt9BxqMmpnco8VZzzV9xEgKT/A=; b=VJ0npswumx3uZdgl2HFGdN5r1qSSBhBWq/+FcFNS4t/g63hbQyms6Kk4cTBjNhMLW2 mfqudRWxIDsnf7uZ8yWQ/1nS2V8yiyfoy8s3iSLoVEwEVKcV1gosrC82hhAMdMTmg9nu dHzG/uj+/UjkoRoQQ+nJXiNaDnoiASnBbnrxOULGuqmw+tSzAk+l9YNNhbLQ89mR2Inw 7ivyF993oqgoUb666lCdrLUOTTzk7sfvaN8h9FnAmH02Flu69L6JCeAh7AXG5qyCO7+N qd1VRysIUJZiC4OdnTjJEi0rjoMyualHCB7weHp2qF+zwn+Gr/1sD+yXyU3wJNAb4e8U LlCw== X-Gm-Message-State: ANhLgQ3uHHQUzYo4NUFL2JAHIi7yL06JU/QSGbBUUogWLOp18ysY38lr l4BReQ54+SR94W76+eoOEkJWkodL0tLPqwwLlTZ6HnPF+E2XCt26WPv4POFdTCr2tlKBc+ZZkLM E+rDXIngtaAMtfrw= X-Received: by 2002:a5d:6082:: with SMTP id w2mr17078556wrt.300.1584791248577; Sat, 21 Mar 2020 04:47:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsvu5wfvhRuM6jVgboSn3IbxzjQxhFrW0gmXdleJclIAtsXaDBlpnQ+JjoWQKg5OAX+ODoNhA== X-Received: by 2002:a5d:6082:: with SMTP id w2mr17078523wrt.300.1584791248363; Sat, 21 Mar 2020 04:47:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 09/11] hw/timer/stm32f2xx_timer: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:13 +0100 Message-Id: <20200321114615.5360-10-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC hw/timer/stm32f2xx_timer.o hw/timer/stm32f2xx_timer.c:225:9: warning: Value stored to 'value' is nev= er read value =3D timer_val; ^ ~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/stm32f2xx_timer.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/timer/stm32f2xx_timer.c b/hw/timer/stm32f2xx_timer.c index 06ec8a02c2..ba8694dcd3 100644 --- a/hw/timer/stm32f2xx_timer.c +++ b/hw/timer/stm32f2xx_timer.c @@ -222,7 +222,6 @@ static void stm32f2xx_timer_write(void *opaque, hwaddr = offset, case TIM_PSC: timer_val =3D stm32f2xx_ns_to_ticks(s, now) - s->tick_offset; s->tim_psc =3D value & 0xFFFF; - value =3D timer_val; break; case TIM_CNT: timer_val =3D value; --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791759; cv=none; d=zohomail.com; s=zohoarc; b=eHs1N1jBeifKLxwMonaHsuEnc0Li5MujYJ6Ca5J3JRvokfek226eIoVjPL7VkshNakklvyUzVukD4rTvzdPOAsrmc6u3qhBjj4rHtCW9Ug6IfND5yacP8EviWWabx7rKQIWfHNDQpKA2eWo44/bQT3+1H7PoE6BecXip5TmDCYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791759; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TG3vD6dCJich6pAeWRU+T1xBswh8CnNUpTlBwJ1yiQM=; b=NQkNiU+wB049qHJ5EM6kFKFn4noVF2GFicUsCAox+hBQbSJJBXmX8bjbwE35M2vxsiDDeQc68lgsw4BS5iTmVOpH9g2/u2ZP2vtCT5ctVH9zTrc9PDp/erxadlIZJ5SXYyYcSWxx9dkwH6W6XT+UGAP7oXIT1OcJ1ue+OG++ZSY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584791759229409.7527000159828; Sat, 21 Mar 2020 04:55:59 -0700 (PDT) Received: from localhost ([::1]:35774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcjO-0000Wv-2s for importer@patchew.org; Sat, 21 Mar 2020 07:55:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35258) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcbN-0002UU-OD for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcbL-00075l-LG for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:41 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:53047) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcbK-00074l-QP for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:38 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-SXinkYuBMxq6LSNOlwq-4A-1; Sat, 21 Mar 2020 07:47:37 -0400 Received: by mail-wr1-f69.google.com with SMTP id g4so4176999wrv.12 for ; Sat, 21 Mar 2020 04:47:36 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id q13sm12849850wrs.91.2020.03.21.04.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TG3vD6dCJich6pAeWRU+T1xBswh8CnNUpTlBwJ1yiQM=; b=IIsiUhjIIPDOHbDbXlsn8XNlj4D/zh+WPObtHyVu7N9yLNl03wjZR46B+/E7O9RLD7af4a 3GYwK+BmhSRkUTLogWHk6VVwsPydCej2/ya5YCtlqZyQcVUH3Gx4D4x4pPxQKvbzcxRf16 3AQENERAc5wJ4yIg47j1CVdgTISTaI8= X-MC-Unique: SXinkYuBMxq6LSNOlwq-4A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zAAolWyXSH1ZCqRxa+9EfzNPi+VU6uagizFc7cEyMYQ=; b=RUQs/+PMTSfhcmnQfPScAkY3umfgUyAqdYqyCqcVnVXYhg0J0GwuxBEQXVotV81wjM 5VGqP7MtCaXV0TrBehC+rkCm6sVLEFO0cwPlnpwRyrTPJX2Ygh7LCKoLNnPzxO35K6GM F5C7GKYlq6T6Baq2l8jfMQYiuPh5MVuk0iYSnSdTf9Z0yWXExr86ODA1iskxBjtuxtL3 ozJgyMIVZeJfcQAmIYy8K6jCL7t4i6brbRCs78Fjsr50l0KWbub0K60cZc6WROLZ5BQ8 FnrfJ94EH8Bt5cIzxC7eozzGAscyQ+IUMLlJMxHwTThZ3LmdhOcd3YMSmSahRwtybb0j jZ4g== X-Gm-Message-State: ANhLgQ0IRmO7Czwsh322vSTnbuveTJGHpRWeRX6j7ZgCOQxcYG9Sds3T HTzJdm002OMXC26mNe04qojJnRmhk1xHWExetCrqHMD76kYTngmdpnBtF7Es7JoNjdffMIreXfc wu4vwjyhOsOafSLI= X-Received: by 2002:a5d:628f:: with SMTP id k15mr10384655wru.404.1584791254910; Sat, 21 Mar 2020 04:47:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vunMup0EkhHY5Z4VqmUt/VLtiE0tE9EtlCM6177KdVJaaGEx8Tohte6eaOFXmY60+p5L/3iMQ== X-Received: by 2002:a5d:628f:: with SMTP id k15mr10384613wru.404.1584791254676; Sat, 21 Mar 2020 04:47:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 10/11] hw/timer/pxa2xx_timer: Add assertion to silent static analyzer warning Date: Sat, 21 Mar 2020 12:46:14 +0100 Message-Id: <20200321114615.5360-11-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" pxa2xx_timer_tick4() takes an opaque pointer, then calls pxa2xx_timer_update4(), so the static analyzer can not verify that the 'n < 8': 425 static void pxa2xx_timer_tick4(void *opaque) 426 { 427 PXA2xxTimer4 *t =3D (PXA2xxTimer4 *) opaque; 428 PXA2xxTimerInfo *i =3D (PXA2xxTimerInfo *) t->tm.info; 429 430 pxa2xx_timer_tick(&t->tm); 433 if (t->control & (1 << 6)) 434 pxa2xx_timer_update4(i, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL)= , t->tm.num - 4); 135 static void pxa2xx_timer_update4(void *opaque, uint64_t now_qemu, int= n) 136 { 137 PXA2xxTimerInfo *s =3D (PXA2xxTimerInfo *) opaque; 140 static const int counters[8] =3D { 0, 0, 0, 0, 4, 4, 6, 6 }; 142 143 if (s->tm4[n].control & (1 << 7)) 144 counter =3D n; 145 else 146 counter =3D counters[n]; Add an assert() to give the static analyzer a hint, this fixes a warning reported by Clang static code analyzer: CC hw/timer/pxa2xx_timer.o hw/timer/pxa2xx_timer.c:146:17: warning: Assigned value is garbage or und= efined counter =3D counters[n]; ^ ~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/timer/pxa2xx_timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/pxa2xx_timer.c b/hw/timer/pxa2xx_timer.c index cd172cc1e9..944c165889 100644 --- a/hw/timer/pxa2xx_timer.c +++ b/hw/timer/pxa2xx_timer.c @@ -140,6 +140,7 @@ static void pxa2xx_timer_update4(void *opaque, uint64_t= now_qemu, int n) static const int counters[8] =3D { 0, 0, 0, 0, 4, 4, 6, 6 }; int counter; =20 + assert(n < ARRAY_SIZE(counters)); if (s->tm4[n].control & (1 << 7)) counter =3D n; else --=20 2.21.1 From nobody Thu May 2 07:45:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584791381; cv=none; d=zohomail.com; s=zohoarc; b=QwvaapmVaRFH7hYOaAMKtvKiZLQurO/UEVV87pTQzqXgh6dSY6ww9B17dRZ2F47C5zd2ZwuYW8k9toeQWooFooiN75UeLw1LuC+11cbMH6ZwsZQU5XDSFWa7huFu2PqtAF/EJQy3pulXy65ojI7e2a9Y/AwuJ/Ugu+iGThRyhQY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584791381; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GEdgbG/luCssALBIqG8TygafayDXTkEa0M3aN0ohCNI=; b=b5r/N0Y3MlPi/sCnKcafFFFoz92LfEMi43EpHl8LwkMIVYUW5ovnU0JRd/0jbh1Lv/a6IskHGw17BEOx7moJKRjjQj5iaqt8xnoItf/p3EvVbZDH4EJNoM75nivS87Qxs73Jmz8ztZOfGTF9xyRrEfUzDUtNNGJoGfvziRs4EoI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158479138105991.02663363461363; Sat, 21 Mar 2020 04:49:41 -0700 (PDT) Received: from localhost ([::1]:35586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcdH-0006T6-Pk for importer@patchew.org; Sat, 21 Mar 2020 07:49:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35295) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFcbS-0002gC-4s for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFcbR-00079m-0u for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:46 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:31367) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jFcbQ-00079Q-Td for qemu-devel@nongnu.org; Sat, 21 Mar 2020 07:47:44 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-fcAJNDnGOVC85t8A2lqXXw-1; Sat, 21 Mar 2020 07:47:42 -0400 Received: by mail-wr1-f70.google.com with SMTP id b12so4216770wro.4 for ; Sat, 21 Mar 2020 04:47:42 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id a11sm13098686wrx.54.2020.03.21.04.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2020 04:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584791264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GEdgbG/luCssALBIqG8TygafayDXTkEa0M3aN0ohCNI=; b=Aeljr/TqdJrW03xZZM4tOGzYDFf5As6//+5Re/GwqhLvD5Cgv3jid2fyazmOmVyB/nVB60 xGZtFcaR+E99CtezBFa7GZbTHPw8g1t8PZjFnLwvjVM4+ZCws6mcUNbQWsFccZxM0Op5M5 q7Yrze7/IACBLVJN6nlycx2OSeItuJA= X-MC-Unique: fcAJNDnGOVC85t8A2lqXXw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RNYtNktAqDdDAs+EFJozo/fN2JmmaPRaAB7IeiBu7pw=; b=XCXIVJFKvlqgByKspJcVE2JU3nVTV6GMtpAPH1VxOr0SVXcjK0WsbvF1j2fRlChC0S Zpb3Wlsfo1nfuYfXqBdnbqR4b8+LxCQ3xRWMImG2JLYSDTugvYNjl3/TVfqRvE///Ou+ xYzjomCBLl6bB1uWaZEbHepjcko5dlcQsFRucwS4C1+jjCzyXkF9szw0Rb4bwqVS/n3A +4YSaB1d6lrXC7t9FU6sckeSs6VrIvHgtWA5BkoedchiDFPJ3CmCaSTAsvlzMiLsaogN KQE+n4++ok38PBq9/Bsmo9HLq6vdiPj/wZsUKIY/dRtlVPWn/CDokG0K5+ExuGbHjb07 Au6Q== X-Gm-Message-State: ANhLgQ0ESlNsyr7Dj2tYxaRWgSnEVD+KDn11Lw1Dgxvo7k1XX1Pjws2l 6gp2wJOQe75RJqPHzL9v6AeQO1kqYCQPQsVqA165stKeLSM71ncCydhInwFtqjdMZ8Xi8u/m6O2 IrAbCwXo0mc5tTm0= X-Received: by 2002:adf:82f7:: with SMTP id 110mr16733195wrc.373.1584791261269; Sat, 21 Mar 2020 04:47:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vubbmq/qIpJmOqmMG8os2wSMw39sfHglC6xWNohsFGnLp3+N7OMkezA8fRZyCRCUVesI83LnA== X-Received: by 2002:adf:82f7:: with SMTP id 110mr16733166wrc.373.1584791261035; Sat, 21 Mar 2020 04:47:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0 11/11] hw/scsi/esp-pci: Remove dead assignment Date: Sat, 21 Mar 2020 12:46:15 +0100 Message-Id: <20200321114615.5360-12-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200321114615.5360-1-philmd@redhat.com> References: <20200321114615.5360-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , "Michael S. Tsirkin" , Michael Tokarev , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , Mark Cave-Ayland , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , John Snow , David Gibson , Kevin Wolf , Andrew Jeffery , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Max Reitz , Igor Mitsyanko , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Fix warning reported by Clang static code analyzer: CC hw/scsi/esp-pci.o hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..2e6cc07d4e 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, val <<=3D shift; val |=3D current & ~(mask << shift); addr &=3D ~3; - size =3D 4; } =20 if (addr < 0x40) { --=20 2.21.1