[v3] misc: Improve error reporting on Windows

[PATCH v3 0/4] misc: Improve error reporting on Windows

Philippe Mathieu-Daudé posted 4 patches 5 years, 8 months ago

Diff against v1 v2
Download series mbox

Test checkpatch failed

Test docker-quick@centos7 failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200228100726.8414-1-philmd@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

chardev/char-pipe.c  | 2 +-
chardev/char-win.c   | 2 +-
qga/channel-win32.c  | 7 ++++---
qga/commands-win32.c | 8 +++++---
util/osdep.c         | 4 ++--
5 files changed, 13 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH v3 0/4] misc: Improve error reporting on Windows

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

Few patches to improve bug reports on Windows.
(i.e. https://bugs.launchpad.net/qemu/+bug/1657841)

Since v2:
- Remove changes in functions using fprintf()
  (util/oslib-win32.c is no more modified)
- Do not remove slog() call in qmp_guest_shutdown()

Since v1:
- Rebase an old patch from Alistair to use error_report()
  as suggested by Markus
- Fix other uses in util/osdep.c and QEMU guest-agent

Philippe Mathieu-Daudé (4):
  chardev: Improve error report by calling error_setg_win32()
  util/osdep: Improve error report by calling error_setg_win32()
  qga: Improve error report by calling error_setg_win32()
  qga: Fix a memory leak

 chardev/char-pipe.c  | 2 +-
 chardev/char-win.c   | 2 +-
 qga/channel-win32.c  | 7 ++++---
 qga/commands-win32.c | 8 +++++---
 util/osdep.c         | 4 ++--
 5 files changed, 13 insertions(+), 10 deletions(-)

-- 
2.21.1

Re: [PATCH v3 0/4] misc: Improve error reporting on Windows

Posted by Markus Armbruster 5 years, 8 months ago

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Few patches to improve bug reports on Windows.
> (i.e. https://bugs.launchpad.net/qemu/+bug/1657841)

Queued, thanks!