From nobody Thu Nov 13 20:39:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582884535; cv=none; d=zohomail.com; s=zohoarc; b=JLczUeZErGjDmMq1QP572572T3cbGJ/7ljUxg8bmacwbLAeiAj0vwfW9BvNK6xXCxVXweWBMTU+2zF72m0WZeoniysARVszjnTEAXqGVnxNkmZb6wva/dP2u+/7t/dkkRzG4mNl8Z/A25TzvDPjtE8mqEMB6a7Sh2iKlvS9+8U4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582884535; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yT/3v5xc8MjkoVGOOK8X+qbWZgR0VaRsSfKEBOzcIOk=; b=A1VQryG+aPzzj36t19fixJZSyewo9IbKYmKogHm/m3bO86QlRBYBF5Q4NaQLOgHXhMy6jef4XQo7U0AKF+czkYVSS7c4vzcXrh9j3QofU0N2I13bRQf1RSCNubaXf47I5zXig+SfvbXQ0fVYeDapBWCsAn+aXafsmnPLJjvFPBM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582884535618831.3048431169203; Fri, 28 Feb 2020 02:08:55 -0800 (PST) Received: from localhost ([::1]:44740 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cZi-0001Gn-2s for importer@patchew.org; Fri, 28 Feb 2020 05:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56874) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cYZ-00082u-7O for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7cYW-0002nr-TB for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:39592 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7cYV-0002n8-BU for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:40 -0500 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-XeInchFfMPO_Zanjp80BIQ-1; Fri, 28 Feb 2020 05:07:36 -0500 Received: by mail-wr1-f70.google.com with SMTP id l1so1139706wrt.4 for ; Fri, 28 Feb 2020 02:07:36 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q12sm12534994wrg.71.2020.02.28.02.07.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582884458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yT/3v5xc8MjkoVGOOK8X+qbWZgR0VaRsSfKEBOzcIOk=; b=OcCEypLabApr9YDj1fvtNnrprcLSHa/Ka/E3AH0V2qjGQr4MbwUEs6K06SN0DznLEHyHk+ dJkhJPRtu8vmDoOkYCiDilspcO+PencJFYRm1qkp6UevkAQR5SduYh83VDuwLqTAQFY6lY Y6vEUP3I9z8RTmYQ2tavMhF7sFdgQ/k= X-MC-Unique: XeInchFfMPO_Zanjp80BIQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mNKMO5ywnwZ72jtmICWss1IwQtrRtnxkxKMLAjdrhEg=; b=TfiI5s3vZvbMLeGNlAq7FalhhmxGvwMpkiCmexDdi5/8URBFAKg1l6UESCDL0BJUHA lT7jpbHX9HkBOZqVMk/jIcKkqaZU1vu6W3uNbGaU61O93WZc7f23ccZZ55PYTXmXVKsq J+wdRFfUGdlRcH+ySkIzqivvWTvVJNfB9IgCYmmqSrgLTHm4BkKql9ruLLGnvD81QIfV D7ZNi8JT2dSwifG8pcEA/aeScHrLQFU6HvOtOteuUHZXLMeX4VOmKxusE49Lq7UBSDZL /kZYttWhfet2Kx8TuZP0QMjbMVPBej8aVILj8XAiz5T/ez7kVKxywR/eFXtuzJqMEijP CqcQ== X-Gm-Message-State: APjAAAUVpJnz3PMKDVpfyf+905QQ2YJdUW/xE+hS6mY0We3hVTqDK3Dn zbTPc3Atl3hlqwQ0Zqz/eTBO+3IoO9nohEp4mCrX2IAm3xgsUz/8dno+lvSQFnIIWT+Z1y5G/Qc X6OqYVpgIS8R7nE8= X-Received: by 2002:a05:600c:2c48:: with SMTP id r8mr3913746wmg.183.1582884455025; Fri, 28 Feb 2020 02:07:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxaTbwxBB3CiiIc8cGwQ1E0+Uwe5ZsliLS91QylzRWejPwfXJT61xnXmEs1xgnStcAuAK74zQ== X-Received: by 2002:a05:600c:2c48:: with SMTP id r8mr3913733wmg.183.1582884454831; Fri, 28 Feb 2020 02:07:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 1/4] chardev: Improve error report by calling error_setg_win32() Date: Fri, 28 Feb 2020 11:07:23 +0100 Message-Id: <20200228100726.8414-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228100726.8414-1-philmd@redhat.com> References: <20200228100726.8414-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Michael Roth , Markus Armbruster , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- chardev/char-pipe.c | 2 +- chardev/char-win.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c index 94d714ffcd..fd12c9e63b 100644 --- a/chardev/char-pipe.c +++ b/chardev/char-pipe.c @@ -70,7 +70,7 @@ static int win_chr_pipe_init(Chardev *chr, const char *fi= lename, MAXCONNECT, NSENDBUF, NRECVBUF, NTIMEOUT, NU= LL); g_free(openname); if (s->file =3D=3D INVALID_HANDLE_VALUE) { - error_setg(errp, "Failed CreateNamedPipe (%lu)", GetLastError()); + error_setg_win32(errp, GetLastError(), "Failed CreateNamedPipe"); s->file =3D NULL; goto fail; } diff --git a/chardev/char-win.c b/chardev/char-win.c index 34825f683d..d4fb44c4dc 100644 --- a/chardev/char-win.c +++ b/chardev/char-win.c @@ -96,7 +96,7 @@ int win_chr_serial_init(Chardev *chr, const char *filenam= e, Error **errp) s->file =3D CreateFile(filename, GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, 0); if (s->file =3D=3D INVALID_HANDLE_VALUE) { - error_setg(errp, "Failed CreateFile (%lu)", GetLastError()); + error_setg_win32(errp, GetLastError(), "Failed CreateFile"); s->file =3D NULL; goto fail; } --=20 2.21.1 From nobody Thu Nov 13 20:39:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582884540; cv=none; d=zohomail.com; s=zohoarc; b=RJQMjXB/rPbZqBL8RwEFSYmZuXVsDcvjmegX5Cydf8EzAdJSsZKqMBUBKad41pYWDEiB3kVyQMWT5EBbheYEvSknvraeOTebQ/5Wvf6EP9RYeOX/cQ0TCnG7f846hk+4v6cXfmhvB1tgo5sFf3nCbw99mWatGAyF8Z6QdrbRBpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582884540; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U596dy96rfJ3roF0dAsD+G3kCp1P/QwUVt7AH1P41lY=; b=KwhTk+lzE3AkyqDjoRT+smeK4lfsJCrTPKIKciIR12nozH6eMTJxIKI2gJbTmbiMhN0cv+rhRUvcwHu174FEwdT9PonswVuUfWQShIYvajEBswdna+3YGPKyJPler57FMEnXzYQXHrHlzOtQqThfAx1WPAMYbj4ry/nCaO9KRT8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582884540463723.479796965763; Fri, 28 Feb 2020 02:09:00 -0800 (PST) Received: from localhost ([::1]:44742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cZn-0001RV-5X for importer@patchew.org; Fri, 28 Feb 2020 05:08:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56902) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cYa-00086L-Ef for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7cYY-0002p3-RO for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:44 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57341 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7cYY-0002ny-NT for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:42 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-fSezLjP2ML6-hzFuqQ3OUA-1; Fri, 28 Feb 2020 05:07:39 -0500 Received: by mail-wm1-f69.google.com with SMTP id o24so515809wmh.0 for ; Fri, 28 Feb 2020 02:07:38 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q12sm12534994wrg.71.2020.02.28.02.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582884461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U596dy96rfJ3roF0dAsD+G3kCp1P/QwUVt7AH1P41lY=; b=KZjqIDyrEJXlTUvoX9+atX7Yrf6tMpJFvYUEUHdMDpBIWGGvTOc5wPl4sMV0ARdxoiM5UR 64SZIqmlHaoL6WiyopJKIBKaG0fY5RHLt2Gsf6ZFtY9nR/rDmqt9r230rfXw8REeVfdUpn YZcB64HJJ2yIvF9i624/aQ9ykgxMCGg= X-MC-Unique: fSezLjP2ML6-hzFuqQ3OUA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DWgR+ky/bIZD4jaLET2vS/CCvPR/BzPRfuBiP4EJRxQ=; b=nh+o+ttbgAHco0xUXeKk4SbubGYiqXxB/vaIcJl0xkEA4JjZcled0eRM/itWp0lD88 6WGPzCz+x0IkDsfLL+tp+GKaijCCA2YuFXzHGUldRKBL8DFig6zUQkY07XkmCa0eObmk 1dRQdOZIjsrh2kD6BlC3tbmxzkbjJMGziH5upJF+Eq502MKdBQV7ZIJ/CdYYJk936K3K QeqA8JWQmMrr2Dg3Gr8f64ofTwfODbFdlYZ6APv7EZaD5QL/ilYbOux+VbcAwSCJL0cv 8KwB4WLwVYBMjvJ1ZsRuLhYxr3FmgQBx5MoznNxoEBYY6wqWVZjH6ix3P8nCPstD+Vf1 n3vA== X-Gm-Message-State: APjAAAVkTebjeg7XsZY8XXM339e3qo7t/4jT7DBHojw6Fd5YnsOGWs+8 yWFkYnRTUnORKS7dfa2SnDDb2AKk5qVXQrxmqMT/NGrsOGVnDRlFBVKcuUQBJTK7TKCCLVtecDp o1Dlu6NeeYIz5M/g= X-Received: by 2002:adf:e542:: with SMTP id z2mr4350644wrm.150.1582884457739; Fri, 28 Feb 2020 02:07:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwULmwotSEjywX/qiez5ZDXHUGhw5pTBYSJWK7rCZfDpnXJBy56nZN7tyRJWtHOm2tMT20ysw== X-Received: by 2002:adf:e542:: with SMTP id z2mr4350627wrm.150.1582884457555; Fri, 28 Feb 2020 02:07:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/4] util/osdep: Improve error report by calling error_setg_win32() Date: Fri, 28 Feb 2020 11:07:24 +0100 Message-Id: <20200228100726.8414-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228100726.8414-1-philmd@redhat.com> References: <20200228100726.8414-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Markus Armbruster , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: Remove change in socket_init() which uses fprintf() --- util/osdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index f7d06050f7..4829c07ff6 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -82,8 +82,8 @@ static int qemu_mprotect__osdep(void *addr, size_t size, = int prot) DWORD old_protect; =20 if (!VirtualProtect(addr, size, prot, &old_protect)) { - error_report("%s: VirtualProtect failed with error code %ld", - __func__, GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + error_report("%s: VirtualProtect failed: %s", __func__, emsg); return -1; } return 0; --=20 2.21.1 From nobody Thu Nov 13 20:39:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582884625; cv=none; d=zohomail.com; s=zohoarc; b=MGNVcsb3LJ+6NFfKhukv2hquIrC4GWsyi6k6uuyVm0ZFIC9+hOpRRKpvHx2infH0wV03jT96F5hLtvrqjieJF1OSSzUZiMbQReStHi+ftt38+VK5zNiU/5+IG1aRueGwGnWMIbWtPpbSaFpIHHSNTlkoseOjQGaDT8FW+7nbRpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582884625; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b+Y/QfuCfGOT8OFWnwdeMDHf5mbsAA0KxAt6Vz43+uE=; b=Y0ccng5CTd8JcBfGOlBjPA3qE1fmw7TpevySIEQ6SVna12FrOhzyg92Fg+OUJJUZoHXRBDFU2EoxtX8r5tOeRe8Yhe8BeMcSwmgKt+a5y3aUbGJRSGUn3aAC+1a7be6equDK+YzuNv+efUmUUqCm4mtAiPo+2GuipWDMOIp8yXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582884625821466.68380272600007; Fri, 28 Feb 2020 02:10:25 -0800 (PST) Received: from localhost ([::1]:44776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cbA-0004eX-Ku for importer@patchew.org; Fri, 28 Feb 2020 05:10:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56927) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cYc-00087i-23 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7cYa-0002r0-LR for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:45 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29881 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7cYa-0002pV-Dh for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:44 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-aCVb7y8DO7ac-5LHXNpqbQ-1; Fri, 28 Feb 2020 05:07:41 -0500 Received: by mail-wm1-f71.google.com with SMTP id y7so956407wmd.4 for ; Fri, 28 Feb 2020 02:07:41 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q12sm12534994wrg.71.2020.02.28.02.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582884463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b+Y/QfuCfGOT8OFWnwdeMDHf5mbsAA0KxAt6Vz43+uE=; b=EW1gWX2ub89eoX6uAEjFOSLrDgclQKQz/cX2PiDC42oBPGeJsJgC+IkGYi6yEQoO+lKmnn U1FPGi3i3o7qiHRqUJXWOUFBhcaZweBS+zpPGxVYeOO986z3zfjIYgVpklvmxiuITT0GO+ 2wJUTTGrzR+ILZF4ThUXJrgVdz5sOuM= X-MC-Unique: aCVb7y8DO7ac-5LHXNpqbQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8ivB6NFsawkEJ23lsit2ccjwYbZtdL4c8SRQrAt/UNI=; b=O/jZE2D23lXjkk/5NADT0itpMqRqDZJr6+NFtRaNpBQI5MRBav6RotRzVnDS2hCwee Yp/YR23HszcFfRGSiCgT3z4lyHVZl71qBPfFEPX6+CnyUadTrIat8TPHJvKQSsV62Q79 O9UxO/b7qQq92dp6TY0yREqILyTfGU/mTP3sJWDJfBlV0kG6s4CvwqC+x1K+oICGeOYj 2aUuTiD61n8BTuJV8c4WtEEaZRf+IocNg2q7lfqq/i4BZ4uTdfCjqGdAtri6CBfrZRas XGQufNWntbQH2QoWB6T8/pIPuj2QrKzxvLLlrvIowU+nMbKI2UIlIZYVMA0rBmTjmdBC 9yqA== X-Gm-Message-State: APjAAAUZmg8yihrARIvTMy0DYoChP85llQSUS5MQLM8+QnjWGsdTt8Im G+vDMUo4nV2p/3xUf0Zsg+03l45Ue3VGMJ1ImtnMBwGbnMdDADgg+R2Db1ZcKMXNTf4L4Z2ihjJ xXOICV/IJMU451F4= X-Received: by 2002:a1c:5419:: with SMTP id i25mr4186710wmb.150.1582884460219; Fri, 28 Feb 2020 02:07:40 -0800 (PST) X-Google-Smtp-Source: APXvYqyuPS3SD+QrMDDw+u6lBZzjcYZq/o6Tql+HW9lgXkiGVs8LMZCCgZUzKPrUkkLyuBqzkx7cow== X-Received: by 2002:a1c:5419:: with SMTP id i25mr4186690wmb.150.1582884460005; Fri, 28 Feb 2020 02:07:40 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 3/4] qga: Improve error report by calling error_setg_win32() Date: Fri, 28 Feb 2020 11:07:25 +0100 Message-Id: <20200228100726.8414-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228100726.8414-1-philmd@redhat.com> References: <20200228100726.8414-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Markus Armbruster , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Use error_setg_win32() which adds a hint similar to strerror(errno)). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- v3: Keep slog() in qmp_guest_shutdown() (Marc-Andr=C3=A9) --- qga/channel-win32.c | 3 ++- qga/commands-win32.c | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index c86f4388db..99648c95b6 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -308,7 +308,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, } =20 if (method =3D=3D GA_CHANNEL_ISA_SERIAL && !SetCommTimeouts(c->handle,= &comTimeOut)) { - g_critical("error setting timeout for com port: %lu",GetLastError(= )); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error setting timeout for com port: %s", emsg); CloseHandle(c->handle); return false; } diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 2461fd19bf..9c744d6405 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -315,8 +315,9 @@ void qmp_guest_shutdown(bool has_mode, const char *mode= , Error **errp) } =20 if (!ExitWindowsEx(shutdown_flag, SHTDN_REASON_FLAG_PLANNED)) { - slog("guest-shutdown failed: %lu", GetLastError()); - error_setg(errp, QERR_UNDEFINED_ERROR); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("guest-shutdown failed: %s", emsg); + error_setg_win32(errp, GetLastError(), "guest-shutdown failed"); } } =20 @@ -1319,7 +1320,8 @@ static DWORD WINAPI do_suspend(LPVOID opaque) DWORD ret =3D 0; =20 if (!SetSuspendState(*mode =3D=3D GUEST_SUSPEND_MODE_DISK, TRUE, TRUE)= ) { - slog("failed to suspend guest, %lu", GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("failed to suspend guest: %s", emsg); ret =3D -1; } g_free(mode); --=20 2.21.1 From nobody Thu Nov 13 20:39:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582884561; cv=none; d=zohomail.com; s=zohoarc; b=QOSN51tiGzW+STce9aPkNkSW9h/0f2N9Rl9hUANaG3Z4lVOZ9muYsIyUcfOgXf7mZIfHIb7op7J138JQXYHc+N+GiF71nzbYD5IAPeTX1DYmr+sOMwdy2JguJjKbMw9hDDVJ28MsLYXrrAxjTkO+eefbkCtGv7lbOVSa7MY21mI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582884561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v1sXycKIkWp3uFFy1E/L4Gl4aKbgtNtM+sQ4x6MFe2I=; b=fAj6a3ce9roi5PJM7TJLnQBwbLJdsUY+EZRdHsCLTCS1osXg5Yr4h6KVCJ6twe4z4Fk+MMoKNgUOah4E8rUsl52hXoQPOHNu+utOArPEXXJ4ylMQxe+FVKqzQwUAe7E0iNL+GXwQ5bJ5mcIuh+xfET9sCB89LtyY6JCVbQcYT9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582884561492628.317093167505; Fri, 28 Feb 2020 02:09:21 -0800 (PST) Received: from localhost ([::1]:44748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7ca8-0002FY-2C for importer@patchew.org; Fri, 28 Feb 2020 05:09:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56941) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cYd-00087y-Ez for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7cYc-0002uM-Gq for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:47 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24923 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7cYc-0002tH-Db for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:46 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-TIYQ0ZlsPaW_XWxpRe0cqg-1; Fri, 28 Feb 2020 05:07:43 -0500 Received: by mail-wm1-f69.google.com with SMTP id t17so503431wmi.7 for ; Fri, 28 Feb 2020 02:07:43 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q12sm12534994wrg.71.2020.02.28.02.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:07:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582884465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v1sXycKIkWp3uFFy1E/L4Gl4aKbgtNtM+sQ4x6MFe2I=; b=MUTtDYQHdl6cvb0LV3/+VBIiqqdqHoGk80rWnw/XZwI10//E6ze1Kz+sZ1ARfOYOfqWWKn qdQY47VOHz74xFCw2UY6/1fekntLmAqR78ZomcTzO8F9DAwQEfzvO4pK1Ul9pWADm+MHgM 9tI39Oh4Qml8/kwowTZCA+p8hDC4yI8= X-MC-Unique: TIYQ0ZlsPaW_XWxpRe0cqg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NSBWokNagTRqOLujr0F42DwTB/RF25rKRtdXhADrMHU=; b=fxHJgL1OtleBki5W0k2VLbCxJ/117wRdIuD7IpGVJiBao5YN/VitcdS8sPyrXgFOlP eUOlEnZixOJmTIDR7C3CipecuisaKOGumdnu4DavyHt8p5jeMTPcqqXTsMTG1YIXouHf jWj6X3MyLnqMM7De9KzIcPH68zq/heR4W7SE0LQhaf3lqWZEj6Q2x5yyyRY2UKlDQhkn i68vzX701BZ28bq1KXliA7RDA23kxicz+8PTBH5sDSK+stLXUaoMVf9R0VhRaxE3LXpw QvFGibKetl38nLr88vDuqG9ymRtAIDW3P7ALqFmfEigL4uw8LthDNE3g2JKJw5wkVNcd ShBQ== X-Gm-Message-State: APjAAAUAWpVKAot8G2cEf8HKJ/H7Ms0hc+EWOshVo26IUomHPgrcP46+ Ggaqgd6clxt6rziHCnnRKaHGYWFxAgumxh07mQsiqX3gGyflY9DUyxHcJj1hXbHVM4dPqxNrj21 Y0AaEnXtLf6s8Fuk= X-Received: by 2002:a1c:5f54:: with SMTP id t81mr4216147wmb.155.1582884462641; Fri, 28 Feb 2020 02:07:42 -0800 (PST) X-Google-Smtp-Source: APXvYqznwXOijaM3XWDUE08+GdGPxG2UU4KGsStw8IoSm82XwfRKLg3py6OLJStLtwckN8iCikNHIg== X-Received: by 2002:a1c:5f54:: with SMTP id t81mr4216130wmb.155.1582884462482; Fri, 28 Feb 2020 02:07:42 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 4/4] qga: Fix a memory leak Date: Fri, 28 Feb 2020 11:07:26 +0100 Message-Id: <20200228100726.8414-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228100726.8414-1-philmd@redhat.com> References: <20200228100726.8414-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Markus Armbruster , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" The string returned by g_win32_error_message() has to be deallocated with g_free(). Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- qga/channel-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 99648c95b6..4f04868a76 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -302,8 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, OPEN_EXISTING, FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, = NULL); if (c->handle =3D=3D INVALID_HANDLE_VALUE) { - g_critical("error opening path %s: %s", newpath, - g_win32_error_message(GetLastError())); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error opening path %s: %s", newpath, emsg); return false; } =20 --=20 2.21.1