[v2] redundant code: Fix warnings reported by Clang static code analyzer

[PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer

kuhn.chenqun@huawei.com posted 13 patches 5 years, 8 months ago

Diff against v1 v3 v3 v4 v5
Download series mbox

Test docker-quick@centos7 failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200226084647.20636-1-kuhn.chenqun@huawei.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Max Reitz <mreitz@redhat.com>, Ronnie Sahlberg <ronniesahlberg@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Andrzej Zaborowski <balrogg@gmail.com>, Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Peter Lieven <pl@kamp.de>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Fam Zheng <fam@euphon.net>, Alistair Francis <alistair@alistair23.me>

There is a newer version of this series

block/file-posix.c           |  1 -
block/iscsi.c                |  1 -
block/stream.c               |  1 -
hw/display/blizzard.c        |  1 -
hw/display/exynos4210_fimd.c |  1 -
hw/display/pxa2xx_lcd.c      |  1 -
hw/dma/xlnx-zdma.c           | 10 +++++-----
hw/scsi/esp-pci.c            |  1 -
hw/scsi/scsi-disk.c          |  1 -
hw/timer/exynos4210_mct.c    |  4 ----
hw/usb/hcd-ehci.c            |  3 ---
migration/vmstate.c          |  1 -
monitor/hmp-cmds.c           |  5 +----
13 files changed, 6 insertions(+), 25 deletions(-)

Expand all Fold all

[PATCH v2 00/13] redundant code: Fix warnings reported by Clang static code analyzer

Posted by kuhn.chenqun@huawei.com 5 years, 8 months ago

From: Chen Qun <kuhn.chenqun@huawei.com>

Since v1:
- Patch1: Addressed John Snow review comment.
- Patch12：Addressed Philippe Mathieu-Daudé review comment.
- Patch9: Move the 'dst_type' declaration to while() statement.
- Patch13: Move the 'set' declaration to the for() statement.

Chen Qun (13):
  block/stream: Remove redundant statement in stream_run()
  block/iscsi:Remove redundant statement in iscsi_open()
  block/file-posix: Remove redundant statement in raw_handle_perm_lock()
  scsi/esp-pci: Remove redundant statement in esp_pci_io_write()
  scsi/scsi-disk: Remove redundant statement in
    scsi_disk_emulate_command()
  display/pxa2xx_lcd: Remove redundant statement in
    pxa2xx_palette_parse()
  display/exynos4210_fimd: Remove redundant statement in
    exynos4210_fimd_update()
  display/blizzard: Remove redundant statement in
    blizzard_draw_line16_32()
  dma/xlnx-zdma: Remove redundant statement in zdma_write_dst()
  migration/vmstate: Remove redundant statement in
    vmstate_save_state_v()
  timer/exynos4210_mct: Remove redundant statement in
    exynos4210_mct_write()
  usb/hcd-ehci: Remove redundant statements
  monitor/hmp-cmds: Remove redundant statement in
    hmp_rocker_of_dpa_groups()

 block/file-posix.c           |  1 -
 block/iscsi.c                |  1 -
 block/stream.c               |  1 -
 hw/display/blizzard.c        |  1 -
 hw/display/exynos4210_fimd.c |  1 -
 hw/display/pxa2xx_lcd.c      |  1 -
 hw/dma/xlnx-zdma.c           | 10 +++++-----
 hw/scsi/esp-pci.c            |  1 -
 hw/scsi/scsi-disk.c          |  1 -
 hw/timer/exynos4210_mct.c    |  4 ----
 hw/usb/hcd-ehci.c            |  3 ---
 migration/vmstate.c          |  1 -
 monitor/hmp-cmds.c           |  5 +----
 13 files changed, 6 insertions(+), 25 deletions(-)

-- 
2.23.0