From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582706962; cv=none; d=zohomail.com; s=zohoarc; b=KiWzJYEXh3+9KkoBOaTyWvLZuJBjTopPgMyoAcBXyLEhkZ+d6hs0kUVBMl+SrL9TtgoqFyLgkLB4fMFo5iKORpdvOvsvaC0QHOU5v91hFgF3qJT7VunfNqyGlaV5aWeO1umT6Jo7TwUJQYb2lMIxO9GQ/XAH6NI55uh3EkOXPnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582706962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xlKun7mJ4Spok0wJXhpUCB2+ruhMGU8jsvEDsnq9wp4=; b=OhDVwDBHXuYszPGQhmFqKy9yxb9epFKFGplBI9jDbEGvhhP1t/FNKgU1hwrzyrihddiFDEoiRun6uR35cfnwN4dSC0Tj5Bmo7nVUT7Ef2GDslYj6fb6bAPMwVP74NzlDcYU5bZVUOVgEidNEvKBk4WmGu0NArHzaY4ReqmuHpE8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582706962728192.223615217334; Wed, 26 Feb 2020 00:49:22 -0800 (PST) Received: from localhost ([::1]:40018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sNd-00028n-DT for importer@patchew.org; Wed, 26 Feb 2020 03:49:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44462) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM3-0000OZ-Ms for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM2-0007Lh-Lz for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58664 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM2-00075o-AO; Wed, 26 Feb 2020 03:47:42 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 755008786A96DFFF0423; Wed, 26 Feb 2020 16:47:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:30 +0800 From: To: , Subject: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() Date: Wed, 26 Feb 2020 16:46:35 +0800 Message-ID: <20200226084647.20636-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Max Reitz , Euler Robot , Chen Qun , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: John Snow Reviewed-by: Kevin Wolf --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz --- block/stream.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/stream.c b/block/stream.c index 5562ccbf57..d78074ac80 100644 --- a/block/stream.c +++ b/block/stream.c @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) break; } } - ret =3D 0; =20 /* Publish progress */ job_progress_update(&s->common.job, n); --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582706961; cv=none; d=zohomail.com; s=zohoarc; b=ClvH1fbK1jJ8flVMw5yH4sPyBYa8i9Hzm04QGpN2rEqptuiKSskG0O9Rl6rukN+TSorgNd9MWxXwuyas6sZo6wns06HiGOVk4fPLeY2nNiZ8HjoZ87vbit2BeVoqz3VuDXM8zrndckLtzjIuVvrCElPs7IAG7cLjT8EuDtjHhIo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582706961; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dhVF9YuHDuJVzHGHzICw/aLsBUnmbY6zetHJUwr8cqU=; b=KHfP42YSIVyELopsLLdL8hrDk5lDt3Fwp0eAaDDtwn9IkQMLRSEcmLAwlVjg56btLvRBDZx+f6U00MFrrYld+9EjDvJKEqc2B4vV4Z2Ba8BD+RkZwVUn0M5z5l9idUP+E1NYsr8PkErTQ54c+swzYFGIWIZJyR6ujoKqPLp3ndA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582706961581637.2256852546981; Wed, 26 Feb 2020 00:49:21 -0800 (PST) Received: from localhost ([::1]:40016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sNc-000281-6z for importer@patchew.org; Wed, 26 Feb 2020 03:49:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44455) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM3-0000OX-Fa for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM2-0007Ka-GI for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:43 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58666 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM2-00075r-44; Wed, 26 Feb 2020 03:47:42 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 7AAE71286B2955C92B63; Wed, 26 Feb 2020 16:47:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:31 +0800 From: To: , Subject: [PATCH v2 02/13] block/iscsi:Remove redundant statement in iscsi_open() Date: Wed, 26 Feb 2020 16:46:36 +0800 Message-ID: <20200226084647.20636-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Peter Lieven , Max Reitz , Ronnie Sahlberg , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read flags &=3D ~BDRV_O_RDWR; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Kevin Wolf Cc: Max Reitz --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..ed88479ede 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *op= tions, int flags, if (ret < 0) { goto out; } - flags &=3D ~BDRV_O_RDWR; } =20 iscsi_readcapacity_sync(iscsilun, &local_err); --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707084; cv=none; d=zohomail.com; s=zohoarc; b=A7oFz3c7MywX2pXf5uvaXRO+0rynCcATSNkIkapfxFCQ5eFe9vyCEHdT06WZHZfE8I3O9Nj4dqaeDzKtQlL4QcJEHasGQ2zHR3c3If+OSmxuhp/UtOChziylKwpKj6+wdnLgmSwnHr5uOE/h9PCOb+MESu9w+BBkD2Wn7OgzJaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707084; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TO4aVO7M0GYgMERAA9F3bnHxjVIxk894Jjm0VsBtnXA=; b=geODcVt86t0UEpHlqDsSKeEpHaRfm/Puz3Prr8Pownv9N4j4i9toThc7f4PSMPRx2O5i1pqIzhPgQu6B/6JhZ2wLvxO6Fbo7PgshjmyniVr3rI1hQIZjzU1YVqvS48gxQqQ6hCTSgFi5AtZC1WOW/pLTz1N1wW7hEeA6Mp51uF8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707084471445.02059579735214; Wed, 26 Feb 2020 00:51:24 -0800 (PST) Received: from localhost ([::1]:40064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sPb-00067U-CG for importer@patchew.org; Wed, 26 Feb 2020 03:51:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44566) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM6-0000Ot-0Y for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM4-0007U5-T6 for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:45 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58922 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM4-0007Mg-G3; Wed, 26 Feb 2020 03:47:44 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 619DE51D9CD8B5E24CD; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:31 +0800 From: To: , Subject: [PATCH v2 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Date: Wed, 26 Feb 2020 16:46:37 +0800 Message-ID: <20200226084647.20636-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Max Reitz , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/file-posix.c:891:9: warning: Value stored to 'op' is never read op =3D RAW_PL_ABORT; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Kevin Wolf --- Cc: Kevin Wolf Cc: Max Reitz --- block/file-posix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 6345477112..0f77447a25 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs, "Is another process using the image [%s]?\n", bs->filename); } - op =3D RAW_PL_ABORT; /* fall through to unlock bytes. */ case RAW_PL_ABORT: raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm, --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707190; cv=none; d=zohomail.com; s=zohoarc; b=kgn+7CHmjEQAQ+VDeFSAth502BD5t5QS3aTQu8J9hBENplZ0WCMQcPPdbxioKMcuWfzoFmdb5yIhr4w/Neo6A/feQubyCC7DV2SijuOYQuVmRh0rtbSEU4Je3obqL4Q/Q4LPNnUYAYVJNIj848lblSEsNnkKzlCxLgjhMpjmPF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707190; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=efs65X/CeHX2YIRz4lUUfQwbZfYq3qi3qbFkebXmTpw=; b=LoQ+9y5lBtOm2DsO+uwy9cZOy+rHIFy5oWQwEGrKjmCouqpTLpKWqEijR+b20q6FGG7ucggmLOFlAEnBf7Vv0UJkblHIEZDcTH44taxsUlXzzdIJhY0KcGDCBj0+I5qF/mSmPmDUaZkrOXzgXbiOeBPcwEXnrSnyOP271DL8wh8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707190766494.47509903416983; Wed, 26 Feb 2020 00:53:10 -0800 (PST) Received: from localhost ([::1]:40104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sRJ-00016L-K7 for importer@patchew.org; Wed, 26 Feb 2020 03:53:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44696) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM8-0000St-9U for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM5-0007ZG-W1 for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:48 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3168 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM5-0007Nq-Io; Wed, 26 Feb 2020 03:47:45 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8E58772E53651F266B31; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:32 +0800 From: To: , Subject: [PATCH v2 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() Date: Wed, 26 Feb 2020 16:46:38 +0800 Message-ID: <20200226084647.20636-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Paolo Bonzini , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc:Fam Zheng --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..2e6cc07d4e 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, val <<=3D shift; val |=3D current & ~(mask << shift); addr &=3D ~3; - size =3D 4; } =20 if (addr < 0x40) { --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707192; cv=none; d=zohomail.com; s=zohoarc; b=AT2S7CAzvPU9cDRWpFL3dFu4Kk5breybqOq42vLQwFdI4SERG9nZ0KYg7UnGefsnZF2diAPgF1OhbNVEo/L469l7TH6Fvx0gN3A6E2YNqzTIIeQRDnbydWtFrNAAMZgaR5aSdi86BsNZ8Yir9xTNqCP0jQ9uoEvGuM1tsyqABmk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707192; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I9ao/MFX0Zi2nYHkNH00MFCzo6mpXZ4uFBdZ7i2uL6A=; b=gG7v963q8++WSeMX7fB65746bKyJk0VNVy4SwZMjmfL7JbnBLdFQtQ57p4dgrVQLDHwlqLaqjtfwxxEDwDnSaw2fB2ySsNKqWOSG8xcnWnn5WnNyjAOqf2T7smTuLdENpjReoZWJZOH7ETyZvogrVP3yBW12RNl1BPxRQa73Gi4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707192770375.1409717748767; Wed, 26 Feb 2020 00:53:12 -0800 (PST) Received: from localhost ([::1]:40108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sRL-0001A6-Ba for importer@patchew.org; Wed, 26 Feb 2020 03:53:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44633) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM7-0000Po-2e for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM5-0007Z6-Vz for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3166 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM5-0007Ng-Hs; Wed, 26 Feb 2020 03:47:45 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8414DBC3328692CDDA27; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:33 +0800 From: To: , Subject: [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Wed, 26 Feb 2020 16:46:39 +0800 Message-ID: <20200226084647.20636-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen =3D req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) r->iov.iov_base =3D blk_blockalign(s->qdev.conf.blk, r->buflen); } =20 - buflen =3D req->cmd.xfer; outbuf =3D r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) { --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707079; cv=none; d=zohomail.com; s=zohoarc; b=ILLRvvmqUPA+t8bz9YHsxxH1pMZyeDpiPu4ODqzZCthRjhrlr1eozTK0arw31rrEGbhrHi7hz17GhqtCSxhFBNKF8Io2zBEs8E884+p/NIB+dxGxjiksd01Mj8k6F2NhztDQOzzvMfvsdy/VqZ7XoZK6HK6NIsOfvh842ER3vLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707079; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u6NjPD6Vj01p/IEp8jRbvoxkJbbqMA7rJdsDft51Z/Q=; b=EFuHrtMXyNn22qli8VmwNquOrEbRbVTG4HlZWVVGrRl2mnsQ0KUn2+xms4WZUtFzHVlf2bDOaSn3GOaSYMEXtQI7enhrMhCjrw9QRTYm3mHYCiXnwj4LkdKYmO5TEI5NQJ0eBKBBRQM7Q8KdViaqdeYZlBHJxZtARxeaeUnG0Ac= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707079188913.420260577493; Wed, 26 Feb 2020 00:51:19 -0800 (PST) Received: from localhost ([::1]:40060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sPV-00064F-V5 for importer@patchew.org; Wed, 26 Feb 2020 03:51:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44638) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM7-0000Q3-5r for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM6-0007ZW-0a for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3167 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM5-0007Nh-KP; Wed, 26 Feb 2020 03:47:45 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 890FFA42264ED9080070; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:33 +0800 From: To: , Subject: [PATCH v2 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Date: Wed, 26 Feb 2020 16:46:40 +0800 Message-ID: <20200226084647.20636-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never r= ead format =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/pxa2xx_lcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index 05f5f84671..464e93161a 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/display/pxa2xx_lcd.c @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int= ch, int bpp) n =3D 256; break; default: - format =3D 0; return; } =20 --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582706964; cv=none; d=zohomail.com; s=zohoarc; b=hA1Z/8gT7Q2/sRYsZETSU9RDXSP2hsmvkynU7G6ikhSqliCb3uLEeDwtZ3NT8gS3qJxZNEwcEDoasNIuVn4F8jjybOfk+XlgkUMnenodhDFAcjELbMWKlaXBLOkXmZRvtIf0h132yMJPne6+vp+KY7tcWuPxUqAIb5hg9Nygk+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582706964; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EEm/qukW1OywU4v3RGp38VNHl6i+g1o3wDUHGTzcPRU=; b=lIbODAQv3HhEW8j+KopTMFxHLkuY4/uZ/Acgmy9gvx5DdGl+8MG5EXxeYKsdFsS142Ioiiucu4fx6dueX93wMst0tl6MiIs53tx8Yoy4R4lRlOqw8zgyE1fc5zRCyyYXX5Jqbps0h5mIft1C0+D4wMVo5lbbTDIkbTzY0eFNvGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582706964158833.6622596699985; Wed, 26 Feb 2020 00:49:24 -0800 (PST) Received: from localhost ([::1]:40022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sNf-0002EQ-2h for importer@patchew.org; Wed, 26 Feb 2020 03:49:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44563) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM5-0000Os-Vi for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM4-0007Tq-SK for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:45 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58948 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM4-0007Mf-Fd; Wed, 26 Feb 2020 03:47:44 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 65F9A855B94B2C5D2408; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:34 +0800 From: To: , Subject: [PATCH v2 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Date: Wed, 26 Feb 2020 16:46:41 +0800 Message-ID: <20200226084647.20636-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' i= s never read is_dirty =3D false; Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/display/exynos4210_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index c1071ecd46..05d3265b76 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exynos4210_fimd.c @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) } host_fb_addr +=3D inc_size; fb_line_addr +=3D inc_size; - is_dirty =3D false; } g_free(snap); blend =3D true; --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707068; cv=none; d=zohomail.com; s=zohoarc; b=JzRNQYS//62A4SSfuyCJNSSAxT96RFwrb9hiJKb/euSN11TERMJDa/hMiMSU0RcSZCYwf7dk2MfMJUguW1UiRRA9lyAdgHv3gpf9nFUtlNToLXOB97fiRyUGUcGbQBPg5uOfjiihbe4zRHEHU37SV+MN/iboVPEVh9sfcAxmbxk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707068; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=AAJ2NdxbohotXj8dzpJvMy11P1MJQ2qIprXzLQ/JzJg=; b=YQa1pfSF+ajx7l2WhKouGWXJcYwetgE0ZbGJkMnBCZjVZEW8Q589Sd99wj/atFPXUJbgEhvWSMJIyGvOmIPIvMYI/lzhqxt+3ejz+q/PM01PngBRa3sfU5nhH9sB+YC5ApDKQejPImCx77fOD3FeEa3Q0ehuQWU7nmF3R8xxjs8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158270706844924.090270272485668; Wed, 26 Feb 2020 00:51:08 -0800 (PST) Received: from localhost ([::1]:40058 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sPJ-0005nd-L1 for importer@patchew.org; Wed, 26 Feb 2020 03:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44575) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM6-0000Ov-4L for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM5-0007Uj-0f for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:46 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:59038 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM4-0007Nj-Ks; Wed, 26 Feb 2020 03:47:44 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 69975A471B758272973D; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:35 +0800 From: To: , Subject: [PATCH v2 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() Date: Wed, 26 Feb 2020 16:46:42 +0800 Message-ID: <20200226084647.20636-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>=3D 5; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/blizzard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a..62517bdf75 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, g =3D (data & 0x3f) << 2; data >>=3D 6; r =3D (data & 0x1f) << 3; - data >>=3D 5; *dest++ =3D rgb_to_pixel32(r, g, b); } } --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707191; cv=none; d=zohomail.com; s=zohoarc; b=QJJTqVPh8O7+RA7kKdTHoMHiy7HbBKmpmXKTSiIrRQITtnBQ0KDta8/H798Y4InTio5QceGNB9J197nWQIQSm41nik6a5V3ZPWDZt8XfineZORxQsPRxAza1j7aHENnoTv2wILJrJjpxJs9mmtDedz8e5ak2O2xDg3WSyB+TbhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707191; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nBn+yTsU+xe1MaM8/R9X9bGcrvSU6nCVW0oehoq7y08=; b=YDhXPePoFuZV1HnOio4cB+hSjmKQvdbIW1FF9nQ571QqVqFWij44PUMqcyp1Eg9h7HMJ+rj4JKXX5t5rSmtRRw0Ba0xIFodw/cjXPs36zwl7GQKMUjpXotPBa7nfK0/pUJMKOqkciJVT6PthYTl65GeBAeD8xQ7+t0omenKCAzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707191492745.3477941083086; Wed, 26 Feb 2020 00:53:11 -0800 (PST) Received: from localhost ([::1]:40106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sRK-00018N-D3 for importer@patchew.org; Wed, 26 Feb 2020 03:53:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44568) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM6-0000Ou-1O for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM4-0007UD-Tf for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:45 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58916 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM4-0007Mh-Gr; Wed, 26 Feb 2020 03:47:44 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5D2F9822B375C71AF9F1; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:35 +0800 From: To: , Subject: [PATCH v2 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Date: Wed, 26 Feb 2020 16:46:43 +0800 Message-ID: <20200226084647.20636-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Alistair Francis , Euler Robot , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_W= ORD3, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: Philippe Mathieu-Daud=C3=A9 v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion). --- hw/dma/xlnx-zdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c index 8fb83f5b07..eeacad59ce 100644 --- a/hw/dma/xlnx-zdma.c +++ b/hw/dma/xlnx-zdma.c @@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, boo= l type, static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len) { uint32_t dst_size, dlen; - bool dst_intr, dst_type; + bool dst_intr; unsigned int ptype =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_= TYPE); unsigned int rw_mode =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE= ); unsigned int burst_type =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATT= R, @@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf,= uint32_t len) while (len) { dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD= 2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD= 3, - TYPE); if (dst_size =3D=3D 0 && ptype =3D=3D PT_MEM) { uint64_t next; + bool dst_type =3D FIELD_EX32(s->dsc_dst.words[3], + ZDMA_CH_DST_DSCR_WORD3, + TYPE); + next =3D zdma_update_descr_addr(s, dst_type, R_ZDMA_CH_DST_CUR_DSCR_LSB); zdma_load_descriptor(s, next, &s->dsc_dst); dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_= WORD2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_= WORD3, - TYPE); } =20 /* Match what hardware does by ignoring the dst_size and only using --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707084; cv=none; d=zohomail.com; s=zohoarc; b=IurzbQ0OdZGCe5nyXvvKb5oIUZHfWS9C4SCLdEKzWaYERR4S0uSFbNKfP7SDwBHTE0hz/9ibDiuwsDUMzY5E2lrpE/qGyC7IiXUb9q/iRUkWeERIBj/JjWWv2j6zJsbrP0R4CVdkVSlBEx2E022yb72efVYJX6nzIHVZeodRF24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707084; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gfpsd+CTeBsW3V/bYW8KqTIaIKvoapwt2ZGKjFO1QHE=; b=iUgBT0vk+y6orI1av9Wgd0676WqxqhUPi5bxPZeF6SYlJPESTAvRgxPbjm+HTCzkYFKZWUDrhUdppTydSn+3okI7t+WxMsJ2UY/vx46sSW4ltrXxvryggo5UqFcnKMcfQfsFpExeww9IdTtk7Q+hGg5fFo7ttXnjnm0yKyRk/80= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707084726664.3187078825815; Wed, 26 Feb 2020 00:51:24 -0800 (PST) Received: from localhost ([::1]:40062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sPb-00066t-Ef for importer@patchew.org; Wed, 26 Feb 2020 03:51:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44626) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM6-0000Pc-Uf for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM5-0007Yn-UF for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:46 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3169 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM5-0007Nu-Gs; Wed, 26 Feb 2020 03:47:45 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 92B7FCBC3D819B6B070B; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:36 +0800 From: To: , Subject: [PATCH v2 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() Date: Wed, 26 Feb 2020 16:46:44 +0800 Message-ID: <20200226084647.20636-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Juan Quintela , "Dr. David Alan Gilbert" , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun The "ret" has been assigned in all branches. It didn't need to be assigned separately. Clang static code analyzer show warning: migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Juan Quintela --- Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- migration/vmstate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index 7dd8ef66c6..bafa890384 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -362,7 +362,6 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDesc= ription *vmsd, } for (i =3D 0; i < n_elems; i++) { void *curr_elem =3D first_elem + size * i; - ret =3D 0; =20 vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems= ); old_offset =3D qemu_ftell_fast(f); --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707223; cv=none; d=zohomail.com; s=zohoarc; b=XvXM1aUmYfCpbeYSwG+abTNIHgW4+iCt007SpccPmYrYWXVzJ+meZAPwOC66ImC5mi6yW9iwUpJkw34pQkvKMxTzrI0EOMFU5Yj2ckMcXc+FQpGGNfxbpDajkIJ14OSQRwrcKV79RnhfUbCG4ZRZWtqkjfVi5Ck5GOEj3Q6Eoc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707223; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qs2nwSnvhyWm9SlYqm/i8ZV+giM2jvNi967P4hEijhw=; b=kxbhH5HVnoSm6NLtXw1/mV2E1rCGTsaIwiAVmA4xsC/7gm8AcSeTntmvx/Oq+cfXF79g06RDy5YMuKxjVhibkx6ENNL3hdy5p+HXCOKB+XWHNzdbXvmQKslMedIMKKWQkVku62tWJtMl/uXiespzwMxPGjwhLx/pz+hS6TdBtUg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707223640821.9117266727884; Wed, 26 Feb 2020 00:53:43 -0800 (PST) Received: from localhost ([::1]:40112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sRq-00023L-IL for importer@patchew.org; Wed, 26 Feb 2020 03:53:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44831) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sMB-0000aV-2A for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM9-0007tX-TY for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:50 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:46018 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM9-0007ii-Hb; Wed, 26 Feb 2020 03:47:49 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6538763AA6C33F9451EE; Wed, 26 Feb 2020 16:47:47 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:36 +0800 From: To: , Subject: [PATCH v2 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Date: Wed, 26 Feb 2020 16:46:45 +0800 Message-ID: <20200226084647.20636-12-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/timer/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..570cf7075b 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); - DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_FRCCNTB_WRITE; --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707305; cv=none; d=zohomail.com; s=zohoarc; b=LTUUeiU7BTvFSfZW2npZWtI2Spy6Yx3/1zyZllNWA/6+KbCug9dGYURwkew8Xe8czn345GSGxwViS7cj6QxBEwi19JqdtnkVLIamg7zS6J3PKFrA3a9hOTpHIn8jfyRUdwI0krb8U+BZqje+Vwlkstj9DqHfLT+pNnYgG+czD9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e4YD8cBie9uY3LBRhreGow3sUocGVPYszg0DW4w4Xrw=; b=mAmvtgrVPHl5gftkYJoqlypXRj+oReho4Vdl9L+JitPTMqT/Xw73T1cGkLQA+Ao5C/H4EFNAsGgIeLJqQg/4+FEmZTAv3EpQCy6M6NphHQ4d7XBG49YrVPINpMxj+6mFSc1iAwCTXCzN1B23lFziHpQRV3ncCaUxV9/XRByd3KQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707305142708.0937633292531; Wed, 26 Feb 2020 00:55:05 -0800 (PST) Received: from localhost ([::1]:40154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sT9-0004wj-Rx for importer@patchew.org; Wed, 26 Feb 2020 03:55:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44838) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sMB-0000b7-7b for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sMA-0007uk-3y for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:51 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:46048 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM9-0007jV-Nr; Wed, 26 Feb 2020 03:47:50 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9221BA449786916D8ADB; Wed, 26 Feb 2020 16:47:47 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:37 +0800 From: To: , Subject: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements Date: Wed, 26 Feb 2020 16:46:46 +0800 Message-ID: <20200226084647.20636-13-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Gerd Hoffmann , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read again =3D -1; ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Gerd Hoffmann Cc: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-ehci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f457f..29d49c2d7e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } =20 /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int a= sync) =20 default: fprintf(stderr, "Bad state!\n"); - again =3D -1; g_assert_not_reached(); - break; } =20 if (again < 0 || itd_count > 16) { --=20 2.23.0 From nobody Thu Nov 13 20:42:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707361; cv=none; d=zohomail.com; s=zohoarc; b=l/shHQrvrNeiKQW/c5U7q4ssq/pqydQmi+hHAL0hslhjHPaf/II3bjTI7psm5AeE+M0fR8A+QbP+o/D1lio/dwjvonX8Wgxu/MCq5+PWjwiLFmp8Ly3HIk+KCexyGpT/wr8b3TVDBMFGUrTZjwy5YXfstSylvFi/EWoebOFT7Hw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707361; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zl6YXPbOpiDhQ1Yy/7ZMcsk0P+WOzW7ZPoj11SB4oWQ=; b=duxBG9otAKpw2wkQ+bpLcYsTc5uOY0NbauAwkhmNwCVnTkYkzHavHekdj+VAdDK1dqXobeL97hWXpZHU0joqiRsBskKDauzZypIFkXXXfHf3fE45lwOsqqIT9HK6y6tDeQOBKjCiGeYNBlEb0DfHJAUCrJ0sx8LnFRUodoNm6dk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707361410842.2837211920136; Wed, 26 Feb 2020 00:56:01 -0800 (PST) Received: from localhost ([::1]:40180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sU4-0006q3-9Y for importer@patchew.org; Wed, 26 Feb 2020 03:56:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44829) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sMA-0000aK-Vn for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM9-0007tz-V6 for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:50 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:46022 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM9-0007it-Iw; Wed, 26 Feb 2020 03:47:49 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6964B7A0165D9F31CFF8; Wed, 26 Feb 2020 16:47:47 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:38 +0800 From: To: , Subject: [PATCH v2 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Date: Wed, 26 Feb 2020 16:46:47 +0800 Message-ID: <20200226084647.20636-14-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, "Dr. David Alan Gilbert" , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set =3D true; ^ ~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: "Dr. David Alan Gilbert" Cc: Philippe Mathieu-Daud=C3=A9 v1->v2: move the 'set' declaration to the for() statement(Base on Philippe'= s suggestion). --- monitor/hmp-cmds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..c6b0495822 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) const char *name =3D qdict_get_str(qdict, "name"); uint8_t type =3D qdict_get_try_int(qdict, "type", 9); Error *err =3D NULL; - bool set =3D false; =20 list =3D qmp_query_rocker_of_dpa_groups(name, type !=3D 9, type, &err); if (err !=3D NULL) { @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) =20 for (g =3D list; g; g =3D g->next) { RockerOfDpaGroup *group =3D g->value; + bool set =3D false; =20 monitor_printf(mon, "0x%08x", group->id); =20 @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const Q= Dict *qdict) =20 if (group->has_set_eth_dst) { if (!set) { - set =3D true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst); } =20 - set =3D false; - if (group->has_ttl_check && group->ttl_check) { monitor_printf(mon, " check TTL"); } --=20 2.23.0