On 2/4/20 12:04 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> If we fail when bringing up the socket we can leak the listen_fd;
> in practice the daemon will exit so it's not really a problem.
>
> Fixes: Coverity CID 1413121
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 80a6e929df..dd1c605dbf 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -916,6 +916,7 @@ static int fv_create_listen_socket(struct fuse_session *se)
> old_umask = umask(0077);
> if (bind(listen_sock, (struct sockaddr *)&un, addr_len) == -1) {
> fuse_log(FUSE_LOG_ERR, "vhost socket bind: %m\n");
> + close(listen_sock);
> umask(old_umask);
> return -1;
> }
> @@ -923,6 +924,7 @@ static int fv_create_listen_socket(struct fuse_session *se)
>
> if (listen(listen_sock, 1) == -1) {
> fuse_log(FUSE_LOG_ERR, "vhost socket listen: %m\n");
> + close(listen_sock);
> return -1;
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>