virtiofsd coverity fixes

[PATCH 0/4] virtiofsd coverity fixes

Dr. David Alan Gilbert (git) posted 4 patches 4 years, 3 months ago

Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200204110501.10731-1-dgilbert@redhat.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>

tools/virtiofsd/fuse.h           | 20 --------
tools/virtiofsd/fuse_lowlevel.c  | 81 ++------------------------------
tools/virtiofsd/fuse_lowlevel.h  | 21 ---------
tools/virtiofsd/fuse_virtio.c    |  2 +
tools/virtiofsd/passthrough_ll.c |  1 +
5 files changed, 7 insertions(+), 118 deletions(-)

Expand all Fold all

[PATCH 0/4] virtiofsd coverity fixes

Posted by Dr. David Alan Gilbert (git) 4 years, 3 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Hi,
  This is a set of fixes that fixes things that coverity pointed out.
Only the last one (the NULL check in do_read) is probably important.

Dave

Dr. David Alan Gilbert (4):
  virtiofsd: Remove fuse_req_getgroups
  virtiofsd: fv_create_listen_socket error path socket leak
  virtiofsd: load_capng missing unlock
  virtiofsd: do_read missing NULL check

 tools/virtiofsd/fuse.h           | 20 --------
 tools/virtiofsd/fuse_lowlevel.c  | 81 ++------------------------------
 tools/virtiofsd/fuse_lowlevel.h  | 21 ---------
 tools/virtiofsd/fuse_virtio.c    |  2 +
 tools/virtiofsd/passthrough_ll.c |  1 +
 5 files changed, 7 insertions(+), 118 deletions(-)

-- 
2.24.1

Re: [PATCH 0/4] virtiofsd coverity fixes

Posted by Stefan Hajnoczi 4 years, 3 months ago

On Tue, Feb 04, 2020 at 11:04:57AM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Hi,
>   This is a set of fixes that fixes things that coverity pointed out.
> Only the last one (the NULL check in do_read) is probably important.
> 
> Dave
> 
> Dr. David Alan Gilbert (4):
>   virtiofsd: Remove fuse_req_getgroups
>   virtiofsd: fv_create_listen_socket error path socket leak
>   virtiofsd: load_capng missing unlock
>   virtiofsd: do_read missing NULL check
> 
>  tools/virtiofsd/fuse.h           | 20 --------
>  tools/virtiofsd/fuse_lowlevel.c  | 81 ++------------------------------
>  tools/virtiofsd/fuse_lowlevel.h  | 21 ---------
>  tools/virtiofsd/fuse_virtio.c    |  2 +
>  tools/virtiofsd/passthrough_ll.c |  1 +
>  5 files changed, 7 insertions(+), 118 deletions(-)
> 
> -- 
> 2.24.1
> 
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>