!fixup target/avr merger-rc4

[PATCH 0/2] !fixup target/avr merger-rc4

Philippe Mathieu-Daudé posted 2 patches 5 years, 9 months ago

Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200131010941.10636-1-philmd@redhat.com

Maintainers: Sarah Harris <S.E.Harris@kent.ac.uk>, Michael Rolnik <mrolnik@gmail.com>

hw/misc/avr_power.c    | 17 +++++++++--------
hw/timer/avr_timer16.c | 25 +++++++++++++++----------
hw/misc/trace-events   |  4 ++++
hw/timer/trace-events  | 12 ++++++++++++
4 files changed, 40 insertions(+), 18 deletions(-)

Expand all Fold all

[PATCH 0/2] !fixup target/avr merger-rc4

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

Aleksandar, I addressed Alex Bennée comment as fixup, so you
can squash directly. See:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg673846.html

- convert DB_PRINT() to trace-events
- fix style/indentation

Based-on: <1580428993-4767-1-git-send-email-aleksandar.markovic@rt-rk.com>

Philippe Mathieu-Daudé (2):
  !fixup "hw/misc: Add limited support for AVR power device"
  !fixup "hw/timer: Add limited support for AVR 16-bit timer peripheral"

 hw/misc/avr_power.c    | 17 +++++++++--------
 hw/timer/avr_timer16.c | 25 +++++++++++++++----------
 hw/misc/trace-events   |  4 ++++
 hw/timer/trace-events  | 12 ++++++++++++
 4 files changed, 40 insertions(+), 18 deletions(-)

-- 
2.21.1

Re: [PATCH 0/2] !fixup target/avr merger-rc4

Posted by Aleksandar Markovic 5 years, 9 months ago

On Fri, Jan 31, 2020 at 2:09 AM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
>
> Aleksandar, I addressed Alex Bennée comment as fixup, so you
> can squash directly. See:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg673846.html
>
> - convert DB_PRINT() to trace-events
> - fix style/indentation
>
> Based-on: <1580428993-4767-1-git-send-email-aleksandar.markovic@rt-rk.com>
>

That is great!

I am going to squash it into corresponding patches, and mention that in
commit messages.
Then I guess some r-b (by Alex) can be added.

Cool!

> Philippe Mathieu-Daudé (2):
>   !fixup "hw/misc: Add limited support for AVR power device"
>   !fixup "hw/timer: Add limited support for AVR 16-bit timer peripheral"
>
>  hw/misc/avr_power.c    | 17 +++++++++--------
>  hw/timer/avr_timer16.c | 25 +++++++++++++++----------
>  hw/misc/trace-events   |  4 ++++
>  hw/timer/trace-events  | 12 ++++++++++++
>  4 files changed, 40 insertions(+), 18 deletions(-)
>
> --
> 2.21.1
>