fix mismatches between g_strsplit and g_free

[PATCH v2 0/2] fix mismatches between g_strsplit and g_free

pannengyuan@huawei.com posted 2 patches 4 years, 3 months ago

Download series mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200110091710.53424-1-pannengyuan@huawei.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>

qga/main.c | 2 +-
vl.c       | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v2 0/2] fix mismatches between g_strsplit and g_free

Posted by pannengyuan@huawei.com 4 years, 3 months ago

From: Pan Nengyuan <pannengyuan@huawei.com>

v1: fix a mismatch in vl.c
v2: fix mismatch in vl.c and qga/main.c

Pan Nengyuan (2):
  vl: Don't mismatch g_strsplit()/g_free()
  qga/main: Don't mismatch g_strsplit/g_free in split_list()

 qga/main.c | 2 +-
 vl.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.21.0.windows.1

Re: [PATCH v2 0/2] fix mismatches between g_strsplit and g_free

Posted by no-reply@patchew.org 4 years, 3 months ago

Patchew URL: https://patchew.org/QEMU/20200110091710.53424-1-pannengyuan@huawei.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===

  TEST    check-unit: tests/test-crypto-cipher
  TEST    check-unit: tests/test-crypto-secret
  TEST    check-unit: tests/test-qga
ERROR - too few tests run (expected 25, got 17)
  TEST    iotest-qcow2: 029
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs....
  TEST    iotest-qcow2: 031
  TEST    iotest-qcow2: 032
---
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=327e1beba9794e3085a9e39927d1dfe5', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-1qgcfifd/src/docker-src.2020-01-10-04.27.30.12511:/var/tmp/qemu:z,ro', 'qemu:centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=327e1beba9794e3085a9e39927d1dfe5
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-1qgcfifd/src'
make: *** [docker-run-test-quick@centos7] Error 2

real    10m55.759s
user    0m8.010s


The full log is available at
http://patchew.org/logs/20200110091710.53424-1-pannengyuan@huawei.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PATCH v2 0/2] fix mismatches between g_strsplit and g_free

Posted by Paolo Bonzini 4 years, 2 months ago

On 10/01/20 10:17, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
> 
> v1: fix a mismatch in vl.c
> v2: fix mismatch in vl.c and qga/main.c
> 
> Pan Nengyuan (2):
>   vl: Don't mismatch g_strsplit()/g_free()
>   qga/main: Don't mismatch g_strsplit/g_free in split_list()
> 
>  qga/main.c | 2 +-
>  vl.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Queued patch 1, thanks.

Paolo