From nobody Thu May 2 02:41:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578648122; cv=none; d=zohomail.com; s=zohoarc; b=boG5vh6+BPkgcgngYdErNF63JVaYH2pGP1ijJ86Z0zh/BWz8oBaKbHBlYU7QzecEeP3m3wXpHwXZ7/4RBCagp6eaNnb8SieAhlc+7q6Ku5+NRB2ZBdpHzWgqRfTSjGGr2PxFnepyryUAv6NEH6liZVTjXGuLhIc1Rq6WGSn1Eh8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578648122; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S6lIKTDx6JlQcaqupOjyvdEaLIlRLirGeyJWQO1wwuk=; b=ax5kLy6+66glbd2eyr5Bd4AuzJhKbMCqrpSdVGNlglUbbTWwTFqTA1SbZGPT86D4oGB2pnCTkDqAcVmTuqJqPTtrK6Q+kcxs0Fzeo70ivfAJKVwM3QD+nFOGb9JOFoT6Qi0PKApqKw6CWHIPZDXoMRifP8umyUezdgEw3DIaGa4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578648122067707.9487188509822; Fri, 10 Jan 2020 01:22:02 -0800 (PST) Received: from localhost ([::1]:42884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqUS-0006jK-LI for importer@patchew.org; Fri, 10 Jan 2020 04:22:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33452) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqR5-00029b-RD for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipqR4-0004un-N7 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:31 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2674 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipqR4-0004dV-BV; Fri, 10 Jan 2020 04:18:30 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 2417338EB152DB909AF2; Fri, 10 Jan 2020 17:18:26 +0800 (CST) Received: from DESKTOP-9NTIQGG.china.huawei.com (10.173.221.136) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 10 Jan 2020 17:18:16 +0800 From: To: , Subject: [PATCH v2 1/2] vl: Don't mismatch g_strsplit()/g_free() Date: Fri, 10 Jan 2020 17:17:09 +0800 Message-ID: <20200110091710.53424-2-pannengyuan@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200110091710.53424-1-pannengyuan@huawei.com> References: <20200110091710.53424-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.173.221.136] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Euler Robot , Pan Nengyuan , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan It's a mismatch between g_strsplit and g_free, it will cause a memory leak = as follow: [root@localhost]# ./aarch64-softmmu/qemu-system-aarch64 -accel help Accelerators supported in QEMU binary: tcg kvm =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D1207900=3D=3DERROR: LeakSanitizer: detected memory leaks Direct leak of 8 byte(s) in 2 object(s) allocated from: #0 0xfffd700231cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xfffd6ec57163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) #2 0xfffd6ec724d7 in g_strndup (/lib64/libglib-2.0.so.0+0x724d7) #3 0xfffd6ec73d3f in g_strsplit (/lib64/libglib-2.0.so.0+0x73d3f) #4 0xaaab66be5077 in main /mnt/sdc/qemu-master/qemu-4.2.0-rc0/vl.c:3517 #5 0xfffd6e140b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) #6 0xaaab66bf0f53 (./build/aarch64-softmmu/qemu-system-aarch64+0x8a0f5= 3) Direct leak of 2 byte(s) in 2 object(s) allocated from: #0 0xfffd700231cb in __interceptor_malloc (/lib64/libasan.so.4+0xd31cb) #1 0xfffd6ec57163 in g_malloc (/lib64/libglib-2.0.so.0+0x57163) #2 0xfffd6ec7243b in g_strdup (/lib64/libglib-2.0.so.0+0x7243b) #3 0xfffd6ec73e6f in g_strsplit (/lib64/libglib-2.0.so.0+0x73e6f) #4 0xaaab66be5077 in main /mnt/sdc/qemu-master/qemu-4.2.0-rc0/vl.c:3517 #5 0xfffd6e140b9f in __libc_start_main (/lib64/libc.so.6+0x20b9f) #6 0xaaab66bf0f53 (./build/aarch64-softmmu/qemu-system-aarch64+0x8a0f5= 3) Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - fix another on in qga/main.c --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 86474a55c9..2fa5cb3b9a 100644 --- a/vl.c +++ b/vl.c @@ -3476,7 +3476,7 @@ int main(int argc, char **argv, char **envp) gchar **optname =3D g_strsplit(typename, ACCEL_CLASS_SUFFI= X, 0); printf("%s\n", optname[0]); - g_free(optname); + g_strfreev(optname); } g_free(typename); } --=20 2.21.0.windows.1 From nobody Thu May 2 02:41:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1578648003; cv=none; d=zohomail.com; s=zohoarc; b=XmVLj9HyloHrjANJwZL3ESXFGMPz15FDipEtc9EzeA8JKkSYAgU0iAg0tYhRs0QJcY/gmt1sXmPRSpDHkZy/kSVh92CrWXsnVxQyOesDWehlgNZb/CB9RpYkscLYAIVCe8Kubk5LNrlf/mc5mN2tCqvkSk6eMq672M/cumLar0I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578648003; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s1/Dyxmla5VGEcd+YJ+rKcMEgGdImy/itTAtStKbPnM=; b=iuWGhyhGPTsbATFw9g9ARLsY/cix03VsrlG2RWeLUccgKvtBwi/k1FoyD/pfZZfGbnzUCUu9o6DfzcvxfuNpOCR6Qq1fe0J2lo9ccCpt4E/x2MTLdudzwhZ4wU9W9A5hwqCWrnORQSUGz3jerOAuUcuSQMOARSxGoz5HpUenAb0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1578648003962736.4802413862155; Fri, 10 Jan 2020 01:20:03 -0800 (PST) Received: from localhost ([::1]:42848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqSY-0003Zl-F3 for importer@patchew.org; Fri, 10 Jan 2020 04:20:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33435) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipqR5-00029P-Kl for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipqR4-0004uE-J9 for qemu-devel@nongnu.org; Fri, 10 Jan 2020 04:18:31 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:58486 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ipqR4-0004dX-8F; Fri, 10 Jan 2020 04:18:30 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 1AE58F276BC218B7B793; Fri, 10 Jan 2020 17:18:26 +0800 (CST) Received: from DESKTOP-9NTIQGG.china.huawei.com (10.173.221.136) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.439.0; Fri, 10 Jan 2020 17:18:16 +0800 From: To: , Subject: [PATCH v2 2/2] qga/main: Don't mismatch g_strsplit/g_free in split_list() Date: Fri, 10 Jan 2020 17:17:10 +0800 Message-ID: <20200110091710.53424-3-pannengyuan@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200110091710.53424-1-pannengyuan@huawei.com> References: <20200110091710.53424-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.173.221.136] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Laurent Vivier , Pan Nengyuan , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan fix a mismatch between g_strsplit and g_free Reported-by: Laurent Vivier Signed-off-by: Pan Nengyuan --- Changes v2 to v1: - fix a mismatch in qga/main.c --- qga/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index c35c2a2120..a72ae074f4 100644 --- a/qga/main.c +++ b/qga/main.c @@ -933,7 +933,7 @@ static GList *split_list(const gchar *str, const gchar = *delim) for (i =3D 0; strv[i]; i++) { list =3D g_list_prepend(list, strv[i]); } - g_free(strv); + g_strfreev(strv); =20 return list; } --=20 2.21.0.windows.1