[PATCH v3 6/8] tests/acceptance: Do not set the machine type manually

Philippe Mathieu-Daudé posted 8 patches 5 years, 11 months ago
There is a newer version of this series
[PATCH v3 6/8] tests/acceptance: Do not set the machine type manually
Posted by Philippe Mathieu-Daudé 5 years, 11 months ago
Since commit ba21bde93 we don't need to set the machine type
manually, the one set by the ":avocado: tags=machine" will be used.

Suggested-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tests/acceptance/machine_avr6.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py
index 7a7d8afc29..394b3d4f8f 100644
--- a/tests/acceptance/machine_avr6.py
+++ b/tests/acceptance/machine_avr6.py
@@ -45,7 +45,6 @@ class AVR6Machine(Test):
         rom_hash = '7eb521f511ca8f2622e0a3c5e8dd686efbb911d4'
         rom_path = self.fetch_asset(rom_url, asset_hash=rom_hash)
 
-        self.vm.set_machine('sample')
         self.vm.add_args('-bios', rom_path)
         self.vm.add_args('-nographic')
         self.vm.launch()
-- 
2.21.0


Re: [PATCH v3 6/8] tests/acceptance: Do not set the machine type manually
Posted by Wainer dos Santos Moschetta 5 years, 11 months ago
On 12/29/19 8:45 PM, Philippe Mathieu-Daudé wrote:
> Since commit ba21bde93 we don't need to set the machine type
> manually, the one set by the ":avocado: tags=machine" will be used.

Correct.

>
> Suggested-by: Cleber Rosa <crosa@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   tests/acceptance/machine_avr6.py | 1 -
>   1 file changed, 1 deletion(-)


Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/acceptance/machine_avr6.py b/tests/acceptance/machine_avr6.py
> index 7a7d8afc29..394b3d4f8f 100644
> --- a/tests/acceptance/machine_avr6.py
> +++ b/tests/acceptance/machine_avr6.py
> @@ -45,7 +45,6 @@ class AVR6Machine(Test):
>           rom_hash = '7eb521f511ca8f2622e0a3c5e8dd686efbb911d4'
>           rom_path = self.fetch_asset(rom_url, asset_hash=rom_hash)
>   
> -        self.vm.set_machine('sample')
>           self.vm.add_args('-bios', rom_path)
>           self.vm.add_args('-nographic')
>           self.vm.launch()