[PATCH v3 0/8] hw/avr: Introduce the Arduino boards

Philippe Mathieu-Daudé posted 8 patches 4 years, 4 months ago
Test asan failed
Test checkpatch passed
Test FreeBSD failed
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191229224505.24466-1-f4bug@amsat.org
There is a newer version of this series
hw/avr/atmega.h                  |  48 ++++
hw/avr/arduino.c                 | 177 ++++++++++++
hw/avr/atmega.c                  | 464 +++++++++++++++++++++++++++++++
hw/char/avr_usart.c              |   2 +-
hw/timer/avr_timer16.c           |   6 +-
tests/boot-serial-test.c         |   2 +
hw/avr/Makefile.objs             |   2 +
tests/acceptance/machine_avr6.py |  11 +-
8 files changed, 701 insertions(+), 11 deletions(-)
create mode 100644 hw/avr/atmega.h
create mode 100644 hw/avr/arduino.c
create mode 100644 hw/avr/atmega.c
[PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by Philippe Mathieu-Daudé 4 years, 4 months ago
Hi,

This series add the arduino boards, aiming at removing the
'sample' board that doesn't follow any specification.

Since v2:
- rebased on Michael's v40

Since v1:
- Addressed Igor comments
- Addressed Aleksandar comments
- Fixed UART issue (was due to IRQ shifted by 2 in CPU)

TODO after merge is:
- Extract Timer8 common parts from Timer16
- Add GPIOs
- Connect LED to GPIO on Arduino
- Plug to Scratch (See http://s4a.cat/).
  (I plan to purpose that as a GSoC idea).

Michael, thank you for having insisted with this port during so long!

Regards,

Phil.

Series available at https://gitlab.com/philmd/qemu/commits/arduino-v3

Regards,

Phil.

Based-on: <20191229215158.5788-1-mrolnik@gmail.com>
https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05309.html

Philippe Mathieu-Daudé (8):
  hw/char/avr: Reduce USART I/O size
  hw/timer/avr_timer16: Rename memory region debugging name
  hw/avr: Add some ATmega microcontrollers
  hw/avr: Add some Arduino boards
  tests/boot-serial-test: Test some Arduino boards (AVR based)
  tests/acceptance: Do not set the machine type manually
  tests/acceptance: Keep multilines comment consistent with other tests
  tests/acceptance: Test the Arduino MEGA2560 board

 hw/avr/atmega.h                  |  48 ++++
 hw/avr/arduino.c                 | 177 ++++++++++++
 hw/avr/atmega.c                  | 464 +++++++++++++++++++++++++++++++
 hw/char/avr_usart.c              |   2 +-
 hw/timer/avr_timer16.c           |   6 +-
 tests/boot-serial-test.c         |   2 +
 hw/avr/Makefile.objs             |   2 +
 tests/acceptance/machine_avr6.py |  11 +-
 8 files changed, 701 insertions(+), 11 deletions(-)
 create mode 100644 hw/avr/atmega.h
 create mode 100644 hw/avr/arduino.c
 create mode 100644 hw/avr/atmega.c

-- 
2.21.0


Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by Michael Rolnik 4 years, 4 months ago
Hi Philippe.

Thank you for joining the effort.

Regards,
Michael Rolnik


On Mon, Dec 30, 2019 at 12:45 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:

> Hi,
>
> This series add the arduino boards, aiming at removing the
> 'sample' board that doesn't follow any specification.
>
> Since v2:
> - rebased on Michael's v40
>
> Since v1:
> - Addressed Igor comments
> - Addressed Aleksandar comments
> - Fixed UART issue (was due to IRQ shifted by 2 in CPU)
>
> TODO after merge is:
> - Extract Timer8 common parts from Timer16
> - Add GPIOs
> - Connect LED to GPIO on Arduino
> - Plug to Scratch (See http://s4a.cat/).
>   (I plan to purpose that as a GSoC idea).
>
> Michael, thank you for having insisted with this port during so long!
>
> Regards,
>
> Phil.
>
> Series available at https://gitlab.com/philmd/qemu/commits/arduino-v3
>
> Regards,
>
> Phil.
>
> Based-on: <20191229215158.5788-1-mrolnik@gmail.com>
> https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05309.html
>
> Philippe Mathieu-Daudé (8):
>   hw/char/avr: Reduce USART I/O size
>   hw/timer/avr_timer16: Rename memory region debugging name
>   hw/avr: Add some ATmega microcontrollers
>   hw/avr: Add some Arduino boards
>   tests/boot-serial-test: Test some Arduino boards (AVR based)
>   tests/acceptance: Do not set the machine type manually
>   tests/acceptance: Keep multilines comment consistent with other tests
>   tests/acceptance: Test the Arduino MEGA2560 board
>
>  hw/avr/atmega.h                  |  48 ++++
>  hw/avr/arduino.c                 | 177 ++++++++++++
>  hw/avr/atmega.c                  | 464 +++++++++++++++++++++++++++++++
>  hw/char/avr_usart.c              |   2 +-
>  hw/timer/avr_timer16.c           |   6 +-
>  tests/boot-serial-test.c         |   2 +
>  hw/avr/Makefile.objs             |   2 +
>  tests/acceptance/machine_avr6.py |  11 +-
>  8 files changed, 701 insertions(+), 11 deletions(-)
>  create mode 100644 hw/avr/atmega.h
>  create mode 100644 hw/avr/arduino.c
>  create mode 100644 hw/avr/atmega.c
>
> --
> 2.21.0
>
>

-- 
Best Regards,
Michael Rolnik
Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
Hi Michael,

On 12/30/19 7:17 PM, Michael Rolnik wrote:
> Hi Philippe.
> 
> Thank you for joining the effort.

Could you test this series?

Are you OK if we use the Arduino machines it introduces to replace your
'sample' board?

> Regards,
> Michael Rolnik
> 
> 
> On Mon, Dec 30, 2019 at 12:45 AM Philippe Mathieu-Daudé <f4bug@amsat.org
> <mailto:f4bug@amsat.org>> wrote:
> 
>     Hi,
> 
>     This series add the arduino boards, aiming at removing the
>     'sample' board that doesn't follow any specification.
> 
>     Since v2:
>     - rebased on Michael's v40
> 
>     Since v1:
>     - Addressed Igor comments
>     - Addressed Aleksandar comments
>     - Fixed UART issue (was due to IRQ shifted by 2 in CPU)
> 
>     TODO after merge is:
>     - Extract Timer8 common parts from Timer16
>     - Add GPIOs
>     - Connect LED to GPIO on Arduino
>     - Plug to Scratch (See http://s4a.cat/).
>       (I plan to purpose that as a GSoC idea).
> 
>     Michael, thank you for having insisted with this port during so long!
> 
>     Regards,
> 
>     Phil.
> 
>     Series available at https://gitlab.com/philmd/qemu/commits/arduino-v3
> 
>     Regards,
> 
>     Phil.
> 
>     Based-on: <20191229215158.5788-1-mrolnik@gmail.com
>     <mailto:20191229215158.5788-1-mrolnik@gmail.com>>
>     https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05309.html
> 
>     Philippe Mathieu-Daudé (8):
>       hw/char/avr: Reduce USART I/O size
>       hw/timer/avr_timer16: Rename memory region debugging name
>       hw/avr: Add some ATmega microcontrollers
>       hw/avr: Add some Arduino boards
>       tests/boot-serial-test: Test some Arduino boards (AVR based)
>       tests/acceptance: Do not set the machine type manually
>       tests/acceptance: Keep multilines comment consistent with other tests
>       tests/acceptance: Test the Arduino MEGA2560 board
> 
>      hw/avr/atmega.h                  |  48 ++++
>      hw/avr/arduino.c                 | 177 ++++++++++++
>      hw/avr/atmega.c                  | 464 +++++++++++++++++++++++++++++++
>      hw/char/avr_usart.c              |   2 +-
>      hw/timer/avr_timer16.c           |   6 +-
>      tests/boot-serial-test.c         |   2 +
>      hw/avr/Makefile.objs             |   2 +
>      tests/acceptance/machine_avr6.py |  11 +-
>      8 files changed, 701 insertions(+), 11 deletions(-)
>      create mode 100644 hw/avr/atmega.h
>      create mode 100644 hw/avr/arduino.c
>      create mode 100644 hw/avr/atmega.c
> 
>     -- 
>     2.21.0
> 
> 
> 
> -- 
> Best Regards,
> Michael Rolnik

Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by Michael Rolnik 4 years, 3 months ago
Sure, no problem.

On Mon, Jan 20, 2020 at 12:50 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:

> Hi Michael,
>
> On 12/30/19 7:17 PM, Michael Rolnik wrote:
> > Hi Philippe.
> >
> > Thank you for joining the effort.
>
> Could you test this series?
>
> Are you OK if we use the Arduino machines it introduces to replace your
> 'sample' board?
>
> > Regards,
> > Michael Rolnik
> >
> >
> > On Mon, Dec 30, 2019 at 12:45 AM Philippe Mathieu-Daudé <f4bug@amsat.org
> > <mailto:f4bug@amsat.org>> wrote:
> >
> >     Hi,
> >
> >     This series add the arduino boards, aiming at removing the
> >     'sample' board that doesn't follow any specification.
> >
> >     Since v2:
> >     - rebased on Michael's v40
> >
> >     Since v1:
> >     - Addressed Igor comments
> >     - Addressed Aleksandar comments
> >     - Fixed UART issue (was due to IRQ shifted by 2 in CPU)
> >
> >     TODO after merge is:
> >     - Extract Timer8 common parts from Timer16
> >     - Add GPIOs
> >     - Connect LED to GPIO on Arduino
> >     - Plug to Scratch (See http://s4a.cat/).
> >       (I plan to purpose that as a GSoC idea).
> >
> >     Michael, thank you for having insisted with this port during so long!
> >
> >     Regards,
> >
> >     Phil.
> >
> >     Series available at
> https://gitlab.com/philmd/qemu/commits/arduino-v3
> >
> >     Regards,
> >
> >     Phil.
> >
> >     Based-on: <20191229215158.5788-1-mrolnik@gmail.com
> >     <mailto:20191229215158.5788-1-mrolnik@gmail.com>>
> >     https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05309.html
> >
> >     Philippe Mathieu-Daudé (8):
> >       hw/char/avr: Reduce USART I/O size
> >       hw/timer/avr_timer16: Rename memory region debugging name
> >       hw/avr: Add some ATmega microcontrollers
> >       hw/avr: Add some Arduino boards
> >       tests/boot-serial-test: Test some Arduino boards (AVR based)
> >       tests/acceptance: Do not set the machine type manually
> >       tests/acceptance: Keep multilines comment consistent with other
> tests
> >       tests/acceptance: Test the Arduino MEGA2560 board
> >
> >      hw/avr/atmega.h                  |  48 ++++
> >      hw/avr/arduino.c                 | 177 ++++++++++++
> >      hw/avr/atmega.c                  | 464
> +++++++++++++++++++++++++++++++
> >      hw/char/avr_usart.c              |   2 +-
> >      hw/timer/avr_timer16.c           |   6 +-
> >      tests/boot-serial-test.c         |   2 +
> >      hw/avr/Makefile.objs             |   2 +
> >      tests/acceptance/machine_avr6.py |  11 +-
> >      8 files changed, 701 insertions(+), 11 deletions(-)
> >      create mode 100644 hw/avr/atmega.h
> >      create mode 100644 hw/avr/arduino.c
> >      create mode 100644 hw/avr/atmega.c
> >
> >     --
> >     2.21.0
> >
> >
> >
> > --
> > Best Regards,
> > Michael Rolnik
>


-- 
Best Regards,
Michael Rolnik
Re: [PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by no-reply@patchew.org 4 years, 4 months ago
Patchew URL: https://patchew.org/QEMU/20191229224505.24466-1-f4bug@amsat.org/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/20191229224505.24466-1-f4bug@amsat.org/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Patchew-devel] [PATCH v3 0/8] hw/avr: Introduce the Arduino boards
Posted by Philippe Mathieu-Daudé 4 years, 4 months ago
On Sun, Dec 29, 2019 at 11:58 PM <no-reply@patchew.org> wrote:
> This series failed the docker-quick@centos7 build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> Please send your feedback to patchew-devel@redhat.com

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20191229215158.5788-1-mrolnik@gmail.com
-> patchew/20191229215158.5788-1-mrolnik@gmail.com
 * [new tag]         patchew/20191229224505.24466-1-f4bug@amsat.org ->
patchew/20191229224505.24466-1-f4bug@amsat.org
fatal: failed to write ref-pack file
fatal: The remote end hung up unexpectedly

Is patchew disk full?


_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel