Raspi sd-bus cleanup and multiphase reset

[PATCH 0/3] Raspi sd-bus cleanup and multiphase reset

Damien Hedde posted 3 patches 4 years, 4 months ago

Download series mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191220144616.911466-1-damien.hedde@greensocs.com

Maintainers: Andrew Baumann <Andrew.Baumann@microsoft.com>, Peter Maydell <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <philmd@redhat.com>

include/hw/gpio/bcm2835_gpio.h |  1 -
hw/arm/bcm2835_peripherals.c   |  2 +-
hw/gpio/bcm2835_gpio.c         | 35 +++++++++++++++++++++++-----------
3 files changed, 25 insertions(+), 13 deletions(-)

Expand all Fold all

[PATCH 0/3] Raspi sd-bus cleanup and multiphase reset

Posted by Damien Hedde 4 years, 4 months ago

Hi All,

This series is a follow-up of my reset series,
https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04664.html

I've extracted the raspberry-pi related patches. As suggested by Peter
in the previous version of the reset serie, these patches do a cleanup
of the raspberry-pi sd-bus then does the multiphase reset switch of the
gpio soc part.

Patch 1 remove the bcm2835_gpio sd-bus which is only used to host the
sd-card before the machine initial reset. As the soc exhibits the "default"
sd-bus to the machine using an alias, we can simply exhibit the sdhci instead.
Patch 2 prepare the multiphase reset switch by isolating the sd-card parent
change. Patch 3 finally does the multiphase transition of the bcm2835_gpio.

Thanks for your feedback,
Damien

Based-on: <20191220115035.709876-1-damien.hedde@greensocs.com>

Damien Hedde (3):
  hw/arm/bcm2835: remove gpio/sd-bus
  hw/gpio/bcm2835_gpio: Isolate sdbus reparenting
  hw/gpio/bcm2835_gpio: Update to resettable

 include/hw/gpio/bcm2835_gpio.h |  1 -
 hw/arm/bcm2835_peripherals.c   |  2 +-
 hw/gpio/bcm2835_gpio.c         | 35 +++++++++++++++++++++++-----------
 3 files changed, 25 insertions(+), 13 deletions(-)

-- 
2.24.0

Re: [PATCH 0/3] Raspi sd-bus cleanup and multiphase reset

Posted by Richard Henderson 4 years, 3 months ago

On 12/21/19 12:46 AM, Damien Hedde wrote:
> Hi All,
> 
> This series is a follow-up of my reset series,
> https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04664.html
> 
> I've extracted the raspberry-pi related patches. As suggested by Peter
> in the previous version of the reset serie, these patches do a cleanup
> of the raspberry-pi sd-bus then does the multiphase reset switch of the
> gpio soc part.
> 
> Patch 1 remove the bcm2835_gpio sd-bus which is only used to host the
> sd-card before the machine initial reset. As the soc exhibits the "default"
> sd-bus to the machine using an alias, we can simply exhibit the sdhci instead.
> Patch 2 prepare the multiphase reset switch by isolating the sd-card parent
> change. Patch 3 finally does the multiphase transition of the bcm2835_gpio.
> 
> Thanks for your feedback,
> Damien
> 
> Based-on: <20191220115035.709876-1-damien.hedde@greensocs.com>

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~