From nobody Fri May 3 06:12:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576853473343976.2198428774826; Fri, 20 Dec 2019 06:51:13 -0800 (PST) Received: from localhost ([::1]:57528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJcV-0001tX-St for importer@patchew.org; Fri, 20 Dec 2019 09:51:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50634) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJY0-0006lh-S9 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiJXz-0008AL-I0 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:32 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:52552) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiJXw-0007yN-Qr; Fri, 20 Dec 2019 09:46:29 -0500 Received: from crumble.bar.greensocs.com (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPS id 94A7396EF2; Fri, 20 Dec 2019 14:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbgvYJhx6Lit3rs3j+nNkUTo6mP2ku7nAV624s9t11k=; b=pLxt1y8YeyRjjFOiEwU4gagAknZGqxqWTGjKTT9U+mWGN0sXPLzYwIHeDIGucqkrUrT+qd tATMQgU+kdBTh8aOnIKeASvvTlqhte4XIqfNk4lO3BiH1Ch49ugeQNZqg/z3TFYrq2yc4l TpEfot6HSwDHUQj0hnm8vP2R/m5QIJ0= From: Damien Hedde To: qemu-devel@nongnu.org Subject: [PATCH 1/3] hw/arm/bcm2835: remove gpio/sd-bus Date: Fri, 20 Dec 2019 15:46:14 +0100 Message-Id: <20191220144616.911466-2-damien.hedde@greensocs.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191220144616.911466-1-damien.hedde@greensocs.com> References: <20191220144616.911466-1-damien.hedde@greensocs.com> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853187; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbgvYJhx6Lit3rs3j+nNkUTo6mP2ku7nAV624s9t11k=; b=MI6qLUDmaWiMtZ3wTmX4U+UnYBrHtvhcLZ+Zh6LmHC+M4LB6m2UPZwYqRBXRv0lnrVWsqk nHhdJIQc3cHFoA4M4H/cKVszyxb2K6mC9EWgDlFbJMuMyelG80EtIcDI76nG1BfmPsYla2 ElP6436uEPVv9LCeG9VwkdH7Ahc7Slc= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1576853187; a=rsa-sha256; cv=none; b=MxI/C14GDculPwqELFq5jEitYIDfAKg3A5TE7rxod3NVWQ2WuOakifmty2f/MXV+a29S3B P7fm0WjKiybmRabInhNXuzBYXpdxZBuB34q5Ld8nzw7mtJawAdWUxEcEPHVIWcWbYUlfOl 4A7kNuLl3YtmwU9y/cVKiC09jR+2KcQ= ARC-Authentication-Results: i=1; beetle.greensocs.com; none Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , peter.maydell@linaro.org, qemu-arm@nongnu.org, philmd@redhat.com, Andrew.Baumann@microsoft.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Remove gpio/sdbus which is only used to host the sd card before reset. Instead directly we exhibit the sdhci bus to the soc and machine. Thus the sd card is created on the sdhci bus and do not need to be moved during first reset. Signed-off-by: Damien Hedde Reviewed-by: Richard Henderson --- include/hw/gpio/bcm2835_gpio.h | 1 - hw/arm/bcm2835_peripherals.c | 2 +- hw/gpio/bcm2835_gpio.c | 6 ------ 3 files changed, 1 insertion(+), 8 deletions(-) diff --git a/include/hw/gpio/bcm2835_gpio.h b/include/hw/gpio/bcm2835_gpio.h index b0de0a3c74..f8416d43d3 100644 --- a/include/hw/gpio/bcm2835_gpio.h +++ b/include/hw/gpio/bcm2835_gpio.h @@ -23,7 +23,6 @@ typedef struct BCM2835GpioState { MemoryRegion iomem; =20 /* SDBus selector */ - SDBus sdbus; SDBus *sdbus_sdhci; SDBus *sdbus_sdhost; =20 diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 17207ae07e..93477c5b2f 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -360,7 +360,7 @@ static void bcm2835_peripherals_realize(DeviceState *de= v, Error **errp) memory_region_add_subregion(&s->peri_mr, GPIO_OFFSET, sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->gpio), 0)); =20 - object_property_add_alias(OBJECT(s), "sd-bus", OBJECT(&s->gpio), "sd-b= us", + object_property_add_alias(OBJECT(s), "sd-bus", OBJECT(&s->sdhci), "sd-= bus", &err); if (err) { error_propagate(errp, err); diff --git a/hw/gpio/bcm2835_gpio.c b/hw/gpio/bcm2835_gpio.c index 91ce3d10cc..25c180423f 100644 --- a/hw/gpio/bcm2835_gpio.c +++ b/hw/gpio/bcm2835_gpio.c @@ -267,9 +267,6 @@ static void bcm2835_gpio_reset(DeviceState *dev) =20 s->sd_fsel =3D 0; =20 - /* SDHCI is selected by default */ - sdbus_reparent_card(&s->sdbus, s->sdbus_sdhci); - s->lev0 =3D 0; s->lev1 =3D 0; } @@ -299,9 +296,6 @@ static void bcm2835_gpio_init(Object *obj) DeviceState *dev =3D DEVICE(obj); SysBusDevice *sbd =3D SYS_BUS_DEVICE(obj); =20 - qbus_create_inplace(&s->sdbus, sizeof(s->sdbus), - TYPE_SD_BUS, DEVICE(s), "sd-bus"); - memory_region_init_io(&s->iomem, obj, &bcm2835_gpio_ops, s, "bcm2835_gpio", 0x1000); sysbus_init_mmio(sbd, &s->iomem); --=20 2.24.0 From nobody Fri May 3 06:12:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576853389959689.912378724257; Fri, 20 Dec 2019 06:49:49 -0800 (PST) Received: from localhost ([::1]:57522 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJbA-0000r4-Fh for importer@patchew.org; Fri, 20 Dec 2019 09:49:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50809) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJY1-0006no-R5 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiJY0-0008FG-OC for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:33 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:52566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiJXy-00081w-7P; Fri, 20 Dec 2019 09:46:30 -0500 Received: from crumble.bar.greensocs.com (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPS id F2B3796F50; Fri, 20 Dec 2019 14:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lM12RI0EHDUNjslinRXmoW1BfejdQGdartCVRRzWAmE=; b=Vvt1dya3SavXYQzVTEWVATCFU2MszH4rUbjkT4YbxDGgkf40K/XO1F7h5sImmdoN2GO9Hl LrW5VV8RMsWTRaigIu6Y3ez9+fh5i8aqTvzv0itAzmbBbpI77Glhwgachzbdxma3lfeFvS kAmKnZWC/V0e1HLdtQIBYJ+rXlvMD9k= From: Damien Hedde To: qemu-devel@nongnu.org Subject: [PATCH 2/3] hw/gpio/bcm2835_gpio: Isolate sdbus reparenting Date: Fri, 20 Dec 2019 15:46:15 +0100 Message-Id: <20191220144616.911466-3-damien.hedde@greensocs.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191220144616.911466-1-damien.hedde@greensocs.com> References: <20191220144616.911466-1-damien.hedde@greensocs.com> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lM12RI0EHDUNjslinRXmoW1BfejdQGdartCVRRzWAmE=; b=s6FLgPAzjEcjCAtj001VhqG2TKWSG5pmbxIE+28yQNdPwGhqGH/KLK3VrkHqKduY3HjurT 0I42w+jQ/AcxuxmpuruyuezSUFLtlqefcLTwkex7q5vBCyhA6ScOTpZr1T6eo8ebj8+ywA HmHnDzYQJPs7Km7q4hEhHEtzfOO3r4k= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1576853189; a=rsa-sha256; cv=none; b=HzoF3GU8k2kXjvUvNfjETN56zrIEk8EPSW3bPdUOGCTXALu92UkvUp4QgdiyLf+65T3Gpe hpSNrQ03jZKWwNz56v2E4O7e+ItvzIUh/PZY/SGN3+9EFKqk9FooKswhtDC4duPs7Xjh5N /U8DEqJO/IZmAsoSln0ruGB8nFxNvqU= ARC-Authentication-Results: i=1; beetle.greensocs.com; none Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , peter.maydell@linaro.org, qemu-arm@nongnu.org, philmd@redhat.com, Andrew.Baumann@microsoft.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Split gpfsel_set() in 2 so that the sdbus reparenting is done in a dedicated function: gpfsel_update_sdbus(). Update call sites of gpfsel_set() to also call gpfsel_update_sdbus(). This commit is a preparation to switch to multiphase reset. Signed-off-by: Damien Hedde Reviewed-by: Richard Henderson --- hw/gpio/bcm2835_gpio.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/gpio/bcm2835_gpio.c b/hw/gpio/bcm2835_gpio.c index 25c180423f..88dc652018 100644 --- a/hw/gpio/bcm2835_gpio.c +++ b/hw/gpio/bcm2835_gpio.c @@ -75,7 +75,10 @@ static void gpfsel_set(BCM2835GpioState *s, uint8_t reg,= uint32_t value) s->fsel[index] =3D fsel; } } +} =20 +static void gpfsel_update_sdbus(BCM2835GpioState *s) +{ /* SD controller selection (48-53) */ if (s->sd_fsel !=3D 0 && (s->fsel[48] =3D=3D 0) /* SD_CLK_R */ @@ -210,6 +213,7 @@ static void bcm2835_gpio_write(void *opaque, hwaddr off= set, case GPFSEL4: case GPFSEL5: gpfsel_set(s, offset / 4, value); + gpfsel_update_sdbus(s); break; case GPSET0: gpset(s, value, 0, 32, &s->lev0); @@ -261,11 +265,15 @@ static void bcm2835_gpio_reset(DeviceState *dev) BCM2835GpioState *s =3D BCM2835_GPIO(dev); =20 int i; + /* + * Initialize the gpfsel registers. In particular, it selects the SDHC= I bus + * for the sd card. + */ for (i =3D 0; i < 6; i++) { gpfsel_set(s, i, 0); } - - s->sd_fsel =3D 0; + /* Update s->sd_fsel and move the sd card */ + gpfsel_update_sdbus(s); =20 s->lev0 =3D 0; s->lev1 =3D 0; --=20 2.24.0 From nobody Fri May 3 06:12:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=fail (BodyHash is different from the expected one) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576853420723240.10422231395899; Fri, 20 Dec 2019 06:50:20 -0800 (PST) Received: from localhost ([::1]:57526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJbf-0001H2-8V for importer@patchew.org; Fri, 20 Dec 2019 09:50:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51292) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iiJY4-0006tu-S1 for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iiJY3-0008Sd-JX for qemu-devel@nongnu.org; Fri, 20 Dec 2019 09:46:36 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:52582) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iiJY0-0008BK-Je; Fri, 20 Dec 2019 09:46:32 -0500 Received: from crumble.bar.greensocs.com (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPS id 4A98296EF0; Fri, 20 Dec 2019 14:46:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUI425C+0o7N1J/sQKvdILj2VDsYvQDc77nK8FmyVMw=; b=mnFhCOtLHBzDl4db+ogmJ95bJMXPzMHAs/c9TT/mkczrEsfTaVOlyFXVdCh7eiP1NrygN+ ZFNqobWMXhS7IiLlCt6tqHhF02A5TOQkMoFY+1JaZoxCevzAoah4nu921X0GqZ+JU9K7B7 axqL7fuKqlDCO7lzq1GAB0XhgFyy62g= From: Damien Hedde To: qemu-devel@nongnu.org Subject: [PATCH 3/3] hw/gpio/bcm2835_gpio: Update to resettable Date: Fri, 20 Dec 2019 15:46:16 +0100 Message-Id: <20191220144616.911466-4-damien.hedde@greensocs.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191220144616.911466-1-damien.hedde@greensocs.com> References: <20191220144616.911466-1-damien.hedde@greensocs.com> MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1576853191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUI425C+0o7N1J/sQKvdILj2VDsYvQDc77nK8FmyVMw=; b=v4PXMf3e3fN5GPotJCE0hmynD6R8VF5WBV5PwRiqaIqEDd28zT2//41sdHTZK/jnZvSgOR R145uyAr8z64J2jnwkAV4GkGzq1M8wEbm6HXvHCd0SAIU1WbQZuGcFp9ZQKX9y9JGmqFew KdqZkXj+F15FGG7scZb/vV5RMalU1Ag= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1576853191; a=rsa-sha256; cv=none; b=ObKsXkHIbTwaPniAdkeMAtyy4zEDhgGnLkxhdBvvuMcncuqk0lCBgE1OAnXCiM5DXeOia/ kX+Z+ho3szT5ORGNtsi6xIdjDW+wuBYXk6Grrjo3D9x9LvEtHl8tEQynIzBl5c8RUw9pOK 4kpav68JB2PWmlzYl1c23r/lUcKNqlo= ARC-Authentication-Results: i=1; beetle.greensocs.com; none Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , peter.maydell@linaro.org, qemu-arm@nongnu.org, philmd@redhat.com, Andrew.Baumann@microsoft.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Transition the bcm2835_gpio device class to Resettable. The sdbus reparenting is delayed in hold phase to respect resettable side-effect rules. Signed-off-by: Damien Hedde Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- hw/gpio/bcm2835_gpio.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/hw/gpio/bcm2835_gpio.c b/hw/gpio/bcm2835_gpio.c index 88dc652018..4d393c6a47 100644 --- a/hw/gpio/bcm2835_gpio.c +++ b/hw/gpio/bcm2835_gpio.c @@ -260,9 +260,9 @@ err_out: __func__, offset); } =20 -static void bcm2835_gpio_reset(DeviceState *dev) +static void bcm2835_gpio_reset_enter(Object *obj, ResetType type) { - BCM2835GpioState *s =3D BCM2835_GPIO(dev); + BCM2835GpioState *s =3D BCM2835_GPIO(obj); =20 int i; /* @@ -272,13 +272,22 @@ static void bcm2835_gpio_reset(DeviceState *dev) for (i =3D 0; i < 6; i++) { gpfsel_set(s, i, 0); } - /* Update s->sd_fsel and move the sd card */ - gpfsel_update_sdbus(s); =20 s->lev0 =3D 0; s->lev1 =3D 0; } =20 +static void bcm2835_gpio_reset_hold(Object *obj) +{ + BCM2835GpioState *s =3D BCM2835_GPIO(obj); + + /* + * Update s->sd_fsel and move the sd card according to the config set = in + * bcm2835_gpio_reset_enter(). + */ + gpfsel_update_sdbus(s); +} + static const MemoryRegionOps bcm2835_gpio_ops =3D { .read =3D bcm2835_gpio_read, .write =3D bcm2835_gpio_write, @@ -336,10 +345,12 @@ static void bcm2835_gpio_realize(DeviceState *dev, Er= ror **errp) static void bcm2835_gpio_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + ResettableClass *rc =3D RESETTABLE_CLASS(klass); =20 dc->vmsd =3D &vmstate_bcm2835_gpio; dc->realize =3D &bcm2835_gpio_realize; - dc->reset =3D &bcm2835_gpio_reset; + rc->phases.enter =3D &bcm2835_gpio_reset_enter; + rc->phases.hold =3D &bcm2835_gpio_reset_hold; } =20 static const TypeInfo bcm2835_gpio_info =3D { --=20 2.24.0