[v2] Fix more GCC9 -O3 warnings

[PATCH v2 0/6] Fix more GCC9 -O3 warnings

Philippe Mathieu-Daudé posted 6 patches 4 years, 4 months ago

Diff against v1 v1
Download series mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191218192526.13845-1-philmd@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, Peter Chubb <peter.chubb@nicta.com.au>, Andrey Smirnov <andrew.smirnov@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Joel Stanley <joel@jms.id.au>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, "Cédric Le Goater" <clg@kaod.org>, Jason Wang <jasowang@redhat.com>, Andrew Jeffery <andrew@aj.id.au>

audio/audio.c            | 1 +
hw/display/tcx.c         | 2 ++
hw/net/imx_fec.c         | 7 ++++---
hw/pci-host/designware.c | 2 +-
hw/timer/aspeed_timer.c  | 2 +-
5 files changed, 9 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH v2 0/6] Fix more GCC9 -O3 warnings

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

Fix some trivial warnings when building with -O3.

v2:
- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'

Philippe Mathieu-Daudé (6):
  audio/audio: Add missing fall through comment
  hw/display/tcx: Add missing fall through comments
  hw/timer/aspeed_timer: Add a fall through comment
  hw/net/imx_fec: Rewrite fall through comments
  hw/net/imx_fec: Remove unuseful FALLTHROUGH comments
  hw/pci-host/designware: Remove unuseful FALLTHROUGH comment

 audio/audio.c            | 1 +
 hw/display/tcx.c         | 2 ++
 hw/net/imx_fec.c         | 7 ++++---
 hw/pci-host/designware.c | 2 +-
 hw/timer/aspeed_timer.c  | 2 +-
 5 files changed, 9 insertions(+), 5 deletions(-)

Cc: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: "Cédric Le Goater" <clg@kaod.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Joel Stanley <joel@jms.id.au>
Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Olivier Danet <odanet@caramail.com>
Cc: Peter Chubb <peter.chubb@nicta.com.au>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org
-- 
2.21.0

Re: [PATCH v2 0/6] Fix more GCC9 -O3 warnings

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

Cc'ing qemu-trivial as this series is fully reviewed.

On 12/18/19 8:25 PM, Philippe Mathieu-Daudé wrote:
> Fix some trivial warnings when building with -O3.
> 
> v2:
> - addressed Thomas and Aleksandar comments
> - dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
> - dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'
> 
> Philippe Mathieu-Daudé (6):
>    audio/audio: Add missing fall through comment
>    hw/display/tcx: Add missing fall through comments
>    hw/timer/aspeed_timer: Add a fall through comment
>    hw/net/imx_fec: Rewrite fall through comments
>    hw/net/imx_fec: Remove unuseful FALLTHROUGH comments
>    hw/pci-host/designware: Remove unuseful FALLTHROUGH comment
> 
>   audio/audio.c            | 1 +
>   hw/display/tcx.c         | 2 ++
>   hw/net/imx_fec.c         | 7 ++++---
>   hw/pci-host/designware.c | 2 +-
>   hw/timer/aspeed_timer.c  | 2 +-
>   5 files changed, 9 insertions(+), 5 deletions(-)
> 
> Cc: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: "Cédric Le Goater" <clg@kaod.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Olivier Danet <odanet@caramail.com>
> Cc: Peter Chubb <peter.chubb@nicta.com.au>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-arm@nongnu.org
>