From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697281; cv=none; d=zohomail.com; s=zohoarc; b=czCY4XfBKnSKvzmoW+FJ99fxbhM4gLPJNMNj29zRMncsZPlVtrJZDxHv/0y7PQxe11VcybeHf86AFpt9JiMGpw0aWfCuff7DRiPzjruD8dePD+seaK71FzPq0Dj46fQuj6/EEsEPPY11JfTzW5o19c+VA2F36JtXoxUShJKKvnM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uuh8UofcW0PixAC6FAxpsmAjIHeSqODHyjZhHex+ypc=; b=QtdmWUCf1UAN4GajitQepRudlxyHpuJaTJNR8p2T9/5DUkH1CZpKT/1OxOsYqomNR5MdurvKBZIgB+M49aRJ+HWdm7vJsq+GpGZAak5Y7XOf8IRUmR2fGK3JAQWmC/6bYdp95kUOJktJVlCnOZQMr9TKIbZbsHlMRpZsqbLU/XM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 157669728156394.70214065975813; Wed, 18 Dec 2019 11:28:01 -0800 (PST) Received: from localhost ([::1]:59514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihezH-0001UW-S7 for importer@patchew.org; Wed, 18 Dec 2019 14:27:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60772) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexO-0007wY-3t for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexN-0003Fj-36 for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:31033 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexM-0003Db-T4 for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:00 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-WjxdumrSNdSzzWtem2prnw-1; Wed, 18 Dec 2019 14:25:56 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2B51107ACC5; Wed, 18 Dec 2019 19:25:55 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1556060CD1; Wed, 18 Dec 2019 19:25:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uuh8UofcW0PixAC6FAxpsmAjIHeSqODHyjZhHex+ypc=; b=dg9AfcweEftUvIlaG/1sR+S6OM90O4+WwlkKqHNvrkx9y6BweJPTAJISf7eVs83Qi02amz bjAsspwDzWFZnMcQ9gaNgiaSXDBeNthTmwkih0PfbCDL1p01tr96lBo/Py7/bBhZmj6oQo cAogl8umN3pRtTzQsjC9IsC1gzRjSfQ= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/6] audio/audio: Add missing fall through comment Date: Wed, 18 Dec 2019 20:25:21 +0100 Message-Id: <20191218192526.13845-2-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: WjxdumrSNdSzzWtem2prnw-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Aleksandar Markovic , =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When building with GCC9 using CFLAG -Wimplicit-fallthrough=3D2 we get: audio/audio.c: In function =E2=80=98audio_pcm_init_info=E2=80=99: audio/audio.c:306:14: error: this statement may fall through [-Werror=3Di= mplicit-fallthrough=3D] 306 | sign =3D 1; | ~~~~~^~~ audio/audio.c:307:5: note: here 307 | case AUDIO_FORMAT_U8: | ^~~~ cc1: all warnings being treated as errors Similarly to e46349414, add the missing fall through comment to hint GCC. Fixes: 2b9cce8c8c Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Gerd Hoffmann --- v2: Reword the description (Aleksandar) Cc: Aleksandar Markovic Cc: Gerd Hoffmann Cc: "K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n" --- audio/audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/audio.c b/audio/audio.c index 56fae55047..57daf3f620 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, = struct audsettings *as) switch (as->fmt) { case AUDIO_FORMAT_S8: sign =3D 1; + /* fall through */ case AUDIO_FORMAT_U8: mul =3D 1; break; --=20 2.21.0 From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697281; cv=none; d=zohomail.com; s=zohoarc; b=f5boHxF1ZinlR4zYD5M07mbb8jm0dPiZl78S9GK4f4LDl/8Uret8UZw9jAUVN78jZ56D8pt547Frzho6mJJEUJL02wkjkd32aymJCQedpO97+FiUWevWsKYF2qn5vod8JH4EiOcxdbpRU9E54d+XqxaHw2XzBHsm3VdRo2CdEyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EBUSnrX9Xj4Cd46mcJUhEO/KAuVtcVoqZZfjQwOzsSI=; b=arD7pKpc8+9uxVGfOsynE6GjP6+fdLRmReMZ02u8mN+k9J/BreEbWFq5Czzms2+y5y9zrCviM6crf5E5ZhT2DIw6ib/cVp68ZhHeWGSF2oI16fwpeug1YNwEHwWDCpjF1B9AqvCBtsYsiqQrrc2wRIJq4E0ONeYBryKinN4weds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697281341102.5339164161445; Wed, 18 Dec 2019 11:28:01 -0800 (PST) Received: from localhost ([::1]:59510 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihezH-0001Og-4p for importer@patchew.org; Wed, 18 Dec 2019 14:27:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexP-0007wZ-1j for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexN-0003Gw-HG for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:02 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:36041 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexN-0003E3-Cx for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:01 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-fccG64bLMmC8M51TdRLDmQ-1; Wed, 18 Dec 2019 14:25:59 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 368F812BA80; Wed, 18 Dec 2019 19:25:58 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 10B4F60C81; Wed, 18 Dec 2019 19:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EBUSnrX9Xj4Cd46mcJUhEO/KAuVtcVoqZZfjQwOzsSI=; b=eGGn/XXZuJ7SNNRzUKr19GeY7UuelKYRIML088ReGjS8X36W0D18cntLx3dVXvjj4IymKY JKViGDsBfzc5rixkmtJrqW/ufv9NP9D1raYxnW5x6Jl+RJhtSEqF0MFle2qlqc/5p210lt lZUPWOLp9KmXm0o7BfUV4vPbcSIi0N8= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/6] hw/display/tcx: Add missing fall through comments Date: Wed, 18 Dec 2019 20:25:22 +0100 Message-Id: <20191218192526.13845-3-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: fccG64bLMmC8M51TdRLDmQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Olivier Danet , Aleksandar Markovic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When building with GCC9 using CFLAG -Wimplicit-fallthrough=3D2 we get: hw/display/tcx.c: In function =E2=80=98tcx_dac_writel=E2=80=99: hw/display/tcx.c:453:26: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 453 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index = autoincrement */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:454:9: note: here 454 | default: | ^~~~~~~ hw/display/tcx.c: In function =E2=80=98tcx_dac_readl=E2=80=99: hw/display/tcx.c:412:22: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 412 | s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index auto= increment */ | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/display/tcx.c:413:5: note: here 413 | default: | ^~~~~~~ cc1: all warnings being treated as errors Give a hint to GCC by adding the missing fall through comments. Fixes: 55d7bfe22 Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Mark Cave-Ayland --- v2: Reword the description (Aleksandar) Cc: Aleksandar Markovic Cc: Olivier Danet Cc: Mark Cave-Ayland --- hw/display/tcx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 14e829d3fa..abbeb30284 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -410,6 +410,7 @@ static uint64_t tcx_dac_readl(void *opaque, hwaddr addr, case 2: val =3D s->b[s->dac_index] << 24; s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincrement= */ + /* fall through */ default: s->dac_state =3D 0; break; @@ -451,6 +452,7 @@ static void tcx_dac_writel(void *opaque, hwaddr addr, u= int64_t val, s->b[index] =3D val >> 24; update_palette_entries(s, index, index + 1); s->dac_index =3D (s->dac_index + 1) & 0xff; /* Index autoincre= ment */ + /* fall through */ default: s->dac_state =3D 0; break; --=20 2.21.0 From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697621; cv=none; d=zohomail.com; s=zohoarc; b=Yz3urBY0gyj/ifg+sHgYc5/xaVfFjuGe1O40R+8NezWVLtwWMVN4Y4+GLB8oOckPPpk2ZeY6PXfpCf0mobPJL7xRPcTX5Zvf0qQk7d8Sg+tBL108Hu5j7s78LAMtehNPDCnuuIC0oqmkm2wt4PbFVvjKfVXVi4l4JQ0cDw+G3m8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697621; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gvKn3E3vtip/x6nya4V8EKu5DfUXiZ0uZoETj2uOGIA=; b=n436Ha9WI1c8VO6FLZh6M9RTip/sodAlxZAbdI8gUycza7xDOITGLVvSJS5JuTBtDO0xgAK39A7ALAQI3LMpmoO3w0NA/b8K66ZNm1yQ4t13w5YNFiYRO6yazlErcjKf4N1/N6Y5Au/kkVS5VfxOGGQYxgNFa2fHUleqq+ulmak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697621494558.751994701236; Wed, 18 Dec 2019 11:33:41 -0800 (PST) Received: from localhost ([::1]:59598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf4l-0007TW-Jk for importer@patchew.org; Wed, 18 Dec 2019 14:33:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexZ-00088s-2W for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexV-0003sL-LV for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:12 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24943 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexV-0003pt-Eh for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-0lMZT4nyOxiOKML3-m51UQ-1; Wed, 18 Dec 2019 14:26:03 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42AE212BA84; Wed, 18 Dec 2019 19:26:01 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C44D60C81; Wed, 18 Dec 2019 19:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gvKn3E3vtip/x6nya4V8EKu5DfUXiZ0uZoETj2uOGIA=; b=XY7zuboI4EDk1jbicx6fgWAMwqopGyBorE6PU7djruSg42ylBNsiV8o1xRDGeotdOLZz2p 15TGVjZD0GMOPlPCPPCbgZPmTOiM7AgmRMX5GxWl5lQWSo4t0aTRZ3Kj9W47RGXRfL02zy 0mfw+W6+kTgzY1KyHfnsN1Uf8Ljsjj8= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/6] hw/timer/aspeed_timer: Add a fall through comment Date: Wed, 18 Dec 2019 20:25:23 +0100 Message-Id: <20191218192526.13845-4-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 0lMZT4nyOxiOKML3-m51UQ-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jeffery , qemu-arm@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Aleksandar Markovic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Joel Stanley Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=3D2: hw/timer/aspeed_timer.c: In function =E2=80=98aspeed_timer_set_value=E2= =80=99: hw/timer/aspeed_timer.c:283:24: error: this statement may fall through [-= Werror=3Dimplicit-fallthrough=3D] 283 | if (old_reload || !t->reload) { | ~~~~~~~~~~~^~~~~~~~~~~~~ hw/timer/aspeed_timer.c:287:5: note: here 287 | case TIMER_REG_STATUS: | ^~~~ cc1: all warnings being treated as errors Add the missing fall through comment. Fixes: 1403f364472 Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: "C=C3=A9dric Le Goater" Cc: Peter Maydell Cc: Andrew Jeffery Cc: Joel Stanley Cc: qemu-arm@nongnu.org --- hw/timer/aspeed_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index a8c38cc118..c91f18415c 100644 --- a/hw/timer/aspeed_timer.c +++ b/hw/timer/aspeed_timer.c @@ -283,7 +283,7 @@ static void aspeed_timer_set_value(AspeedTimerCtrlState= *s, int timer, int reg, if (old_reload || !t->reload) { break; } - + /* fall through to re-enable */ case TIMER_REG_STATUS: if (timer_enabled(t)) { uint64_t now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); --=20 2.21.0 From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697455; cv=none; d=zohomail.com; s=zohoarc; b=cYZwR7R/tZ/um18gTvwG+Fi/BnNcTxF8Z6scBBlLIwsbn5eNoUxGCw/llwuVPRSTjqkhDKrq0wB8i7J4LI8J1GN8VE5GCfnFGr7oQqvTlGht5UZPNQHkzEUdtNc/MPAVPZoVDRWTbbcDv1FJjLU+9nwSe5L0eT08dnEtx8dpXO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697455; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TdxvmB9Qgxghb+PTOnONzrGSfc8UbEoa7GDLETeQHLY=; b=SOlLHisEL6xY5WsvKWkIQ93zcOYx5ZC9wLTfwj93CiQGiVKp3CNDBJjsVEYFW8e57qTWjzexFoGYaXfPAXQmxn4Cxx5NFT5eu2oVV0ykXTcyADk3FMjCn0/H84ki1/F6cg0ICWKJN2Vi4DfRYCWXDgistajUCJraxhq1qGAelVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697455850924.6183884077009; Wed, 18 Dec 2019 11:30:55 -0800 (PST) Received: from localhost ([::1]:59546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf26-0004UQ-6Y for importer@patchew.org; Wed, 18 Dec 2019 14:30:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexZ-00088w-31 for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexW-0003ub-4v for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:12 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:22077 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexV-0003ry-SY for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:09 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-xXWuz7rlM1Cc8jiMhQbi7g-1; Wed, 18 Dec 2019 14:26:08 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FB5D8024D3; Wed, 18 Dec 2019 19:26:06 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98C6B60C81; Wed, 18 Dec 2019 19:26:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdxvmB9Qgxghb+PTOnONzrGSfc8UbEoa7GDLETeQHLY=; b=FufARakBJ6wVGTURsUbZuLvPkirJJDQxQJge8R0RQmPigHYH/y+6vxG76xeKjsWjJR1FPh nOmwEny/dQhdpH+fXgSSKVBLal6K3Adheb/8I/OUqFFC0fOzGvz/pNVyImiK8wuoXq9QEr jfCnWIY8CeYd7+KjKXmhOo/ddJ3p/E8= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 4/6] hw/net/imx_fec: Rewrite fall through comments Date: Wed, 18 Dec 2019 20:25:24 +0100 Message-Id: <20191218192526.13845-5-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: xXWuz7rlM1Cc8jiMhQbi7g-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Richard Henderson , qemu-arm@nongnu.org, Peter Chubb , Aleksandar Markovic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/net/imx_fec.c: In function =E2=80=98imx_eth_write=E2=80=99: hw/net/imx_fec.c:906:12: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 906 | if (unlikely(single_tx_ring)) { | ^ hw/net/imx_fec.c:912:5: note: here 912 | case ENET_TDAR: /* FALLTHROUGH */ | ^~~~ cc1: all warnings being treated as errors Rewrite the comments in the correct place, using 'fall through' which is recognized by GCC and static analyzers. Reviewed-by: Richard Henderson Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- Cc: Peter Chubb Cc: Peter Maydell Cc: Jason Wang Cc: qemu-arm@nongnu.org --- hw/net/imx_fec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index bd99236864..c01ce4f078 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -909,7 +909,8 @@ static void imx_eth_write(void *opaque, hwaddr offset, = uint64_t value, TYPE_IMX_FEC, __func__); return; } - case ENET_TDAR: /* FALLTHROUGH */ + /* fall through */ + case ENET_TDAR: if (s->regs[ENET_ECR] & ENET_ECR_ETHEREN) { s->regs[index] =3D ENET_TDAR_TDAR; imx_eth_do_tx(s, index); --=20 2.21.0 From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697449; cv=none; d=zohomail.com; s=zohoarc; b=nOz2U2D+2MZPnTrG3ZKnS/dmP/M8E1ZxQFVAftjqVStmji24SH+fNKJDe9ILNE7/UGzEEP8XSdLzNmCbdfe7SztMJVfMQkaZvN0rd8GMBwsCuNVkIkuZ3WSpsyDBWI5k6Rl6GnkR+aIg127humERfK1HL+LepYAd4S54z7I9ejo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697449; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vYieTMV2GGryjAYltk1B6hSeskuepnCEd/upKBPg6sc=; b=j2NJvAdlMikUENCON/u+dLir4ae1ZJuoRFQjkYAEybOwPCWA8uc7ThKGlaxOqId1n3v3yaq5MHlFubSUVf9Zygb3kvfQZwhwD377RK++OE2K2vl3jfeOblBkegOhfMAY7ZtDUNG3GvMvtCKViZzj3CuaYRZNkxcbXmIdUkPXv3g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697449550466.14924310410936; Wed, 18 Dec 2019 11:30:49 -0800 (PST) Received: from localhost ([::1]:59538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf1z-0004PB-GK for importer@patchew.org; Wed, 18 Dec 2019 14:30:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34558) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexi-0008IQ-7c for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexf-00044U-S3 for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:21 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:40347 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexe-0003yK-Kg for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:19 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-GKU3JQVBO16wNXnwHLjn3A-1; Wed, 18 Dec 2019 14:26:11 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3E60801E6C; Wed, 18 Dec 2019 19:26:09 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 002A260C84; Wed, 18 Dec 2019 19:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vYieTMV2GGryjAYltk1B6hSeskuepnCEd/upKBPg6sc=; b=M6fdaq1Yt4oPBsyMg23IXo+khTps7qQ4oAiOYM7Jdk3A8HUd74Bdk2qMjW3oCyyHMyeUIC o6hGUi3YanVcgqP6rWNsMaNwjWh1cQx/xHmwDlki4FN5OpSwV+cWMNXVv8pulelNWpxQeB Npcv9svB4bLl2xw7SfZ1UyODNFM+2y8= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments Date: Wed, 18 Dec 2019 20:25:25 +0100 Message-Id: <20191218192526.13845-6-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: GKU3JQVBO16wNXnwHLjn3A-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Jason Wang , Markus Armbruster , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We don't need to explicit these obvious switch fall through comments. Stay consistent with the rest of the codebase. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- Cc: Peter Chubb Cc: Markus Armbruster Cc: Peter Maydell Cc: Jason Wang Cc: qemu-arm@nongnu.org --- hw/net/imx_fec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index c01ce4f078..5a83678f64 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -901,8 +901,8 @@ static void imx_eth_write(void *opaque, hwaddr offset, = uint64_t value, s->regs[index] =3D 0; } break; - case ENET_TDAR1: /* FALLTHROUGH */ - case ENET_TDAR2: /* FALLTHROUGH */ + case ENET_TDAR1: + case ENET_TDAR2: if (unlikely(single_tx_ring)) { qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: trying to access TDAR2 or TDAR1\n", --=20 2.21.0 From nobody Sun May 5 12:50:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1576697465; cv=none; d=zohomail.com; s=zohoarc; b=STIYCV33u5qsBJGA3unotvtZbVLPpTwoYnJWCwBNj8WlibNwpbCIBD4l3DRJdWA9XISA4bSIzomuGEitnJLbH9reCjEtO4ok4cTFuhT3aPB/P1PEy+klrGnoWetiLzvgjmrJU2x78q109jWlGGkJx43/HDdfY7aZ0S1eScpg0nI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1576697465; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y6YG32m8JkF0CpWQ1Sg7hx1MiUEtHJOD6PbN9L9fnDQ=; b=kdij76bMh+toZ3I8rIyd7CyMhivtpRuSec3CjUjIAhZgRKo/++z/iGa0rEg6jQz0V6Kyd49wZk3ezb6cmoJHZ41TwXjbW/kGohIYeT3qml9ntp+TQiJ/nOK9l/U1Fb+9iCdD49r5TyyYCDghn1yZZF7yVFRxMd24FnRt2v+PMUM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1576697465497138.87021861488336; Wed, 18 Dec 2019 11:31:05 -0800 (PST) Received: from localhost ([::1]:59550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf2F-0004fg-Mp for importer@patchew.org; Wed, 18 Dec 2019 14:31:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34796) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexk-0008Lw-IO for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexi-00047E-7H for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:24 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27726 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexf-00040I-Rh for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:20 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-TnFNLP5ZPDqKdARPyQIwwA-1; Wed, 18 Dec 2019 14:26:14 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C530A12BA84; Wed, 18 Dec 2019 19:26:12 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C51B60C81; Wed, 18 Dec 2019 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y6YG32m8JkF0CpWQ1Sg7hx1MiUEtHJOD6PbN9L9fnDQ=; b=G3LIoWHe7MpEawC90M2Ah2AbGBmAhOqMXGDk4+PRrh7JQZ+YzTTMFI+2OG9O8Sz64xlSsu k9T1cRDsIttFm3rhu628aUcc244d5CY4BVfEF9Btczy1INh+8WXdscJP/Gj/jaraEsi0rA lapxt94JmgMY59eCwpUwF1FK8SUt7Qg= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment Date: Wed, 18 Dec 2019 20:25:26 +0100 Message-Id: <20191218192526.13845-7-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: TnFNLP5ZPDqKdARPyQIwwA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrey Smirnov , Markus Armbruster , qemu-arm@nongnu.org, Peter Chubb , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We don't need to explicit this obvious switch fall through. Stay consistent with the rest of the codebase. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Aleksandar Markovic Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- Cc: Peter Chubb Cc: Markus Armbruster Cc: Peter Maydell Cc: Andrey Smirnov Cc: qemu-arm@nongnu.org --- hw/pci-host/designware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index 71e9b0d9b5..dd245516dd 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32_t= address, int len) break; =20 case DESIGNWARE_PCIE_ATU_CR1: - case DESIGNWARE_PCIE_ATU_CR2: /* FALLTHROUGH */ + case DESIGNWARE_PCIE_ATU_CR2: val =3D viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) / sizeof(uint32_t)]; break; --=20 2.21.0