[v1] block: Introduce real BdrvChildRole

[PATCH for-5.0 06/31] block: Keep BDRV_O_NO_IO in *inherited_fmt_options

Max Reitz posted 31 patches 6 years, 2 months ago

Diff against v2 v3 v4
Download mbox

Maintainers: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>, Alberto Garcia <berto@igalia.com>, Jeff Cody <codyprime@gmail.com>, Stefan Weil <sw@weilnetz.de>, "Denis V. Lunev" <den@openvz.org>, Xie Changlong <xiechanglong.d@gmail.com>, Wen Congyang <wencongyang2@huawei.com>, Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>, Ari Sundholm <ari@tuxera.com>, Stefan Hajnoczi <stefanha@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>, Max Reitz <mreitz@redhat.com>

There is a newer version of this series

Expand all Fold all

[PATCH for-5.0 06/31] block: Keep BDRV_O_NO_IO in *inherited_fmt_options

Posted by Max Reitz 6 years, 2 months ago

bdrv_inherited_fmt_options() is used only by (pseudo-)filter drivers,
namely quorum and blkverify.  Both should pass on BDRV_O_NO_IO to their
children.  There is no reason to clear it in
bdrv_inherited_fmt_options().

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index 6c50ad661e..58252007af 100644
--- a/block.c
+++ b/block.c
@@ -1034,7 +1034,7 @@ static void bdrv_inherited_fmt_options(int *child_flags, QDict *child_options,
     child_file.inherit_options(child_flags, child_options,
                                parent_flags, parent_options);
 
-    *child_flags &= ~(BDRV_O_PROTOCOL | BDRV_O_NO_IO);
+    *child_flags &= ~BDRV_O_PROTOCOL;
 }
 
 const BdrvChildClass child_format = {
-- 
2.23.0