From nobody Mon Feb 9 15:46:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1574861550; cv=none; d=zohomail.com; s=zohoarc; b=cTgBhBdyY/sXzdMUf7tXcEb2ouRswhSa6WsLd08zCXoXsg2FpRmctLC+/qQ0cJVoVy90FFmouv4HTM5j1ITL7z7MwxdnvGqJF5V8rKRQ+qgCS94yVJaOCv8QuLOudFEE23qaFvK6UOjBfFaY1ZwaPD4XJgS/phsj2/1zL5ROs10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1574861550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZDd7OLdtrZb8YDc/Zs/Zu+YXZxfFmqwEYBIUNMWS4y8=; b=jMcaEGPj9VFV92N8wLLb7Q0jMnsPC8LcOgHOhyS8G3BUI6ucLcC+pqlaVioiLwd1HmZ4ToHZqMjSqHuU3S4EU6M42jt27u8fI1A4oxGc4r51LL0wWI2Ic2UiQdsper2aocWvYI+t139lx9MwIA6K2U6YZXKaUae8hjnWHHpWCbY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15748615506741017.1627859131358; Wed, 27 Nov 2019 05:32:30 -0800 (PST) Received: from localhost ([::1]:38394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZxQi-0000cD-OM for importer@patchew.org; Wed, 27 Nov 2019 08:32:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33588) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZxBd-0003u5-27 for qemu-devel@nongnu.org; Wed, 27 Nov 2019 08:16:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZxBX-0006KP-6F for qemu-devel@nongnu.org; Wed, 27 Nov 2019 08:16:50 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:38727 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZxBX-0006HA-2j for qemu-devel@nongnu.org; Wed, 27 Nov 2019 08:16:47 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-M8BoC09tNfqc9DdJIrF8CA-1; Wed, 27 Nov 2019 08:16:43 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E50E7184CAA9; Wed, 27 Nov 2019 13:16:41 +0000 (UTC) Received: from localhost (ovpn-205-186.brq.redhat.com [10.40.205.186]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D5CD67646; Wed, 27 Nov 2019 13:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574860606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZDd7OLdtrZb8YDc/Zs/Zu+YXZxfFmqwEYBIUNMWS4y8=; b=JqXt5+qMvvapzDuiYyjTAAspArsHHUnRHNg2pDYSj0+RQikG7MbKlDwnTT7HG2Lg3jvoTH m/648YtUXI/HxruWXi+Ljh0xBr6VPjLcDHsLb3xfavcdaPzpfgrfrwndUhWmlT15mvyog9 rft/+skvvmorw1Io7XXwUTVI4Pd4ius= From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH for-5.0 06/31] block: Keep BDRV_O_NO_IO in *inherited_fmt_options Date: Wed, 27 Nov 2019 14:15:59 +0100 Message-Id: <20191127131624.1062403-7-mreitz@redhat.com> In-Reply-To: <20191127131624.1062403-1-mreitz@redhat.com> References: <20191127131624.1062403-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: M8BoC09tNfqc9DdJIrF8CA-1 X-Mimecast-Spam-Score: 0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" bdrv_inherited_fmt_options() is used only by (pseudo-)filter drivers, namely quorum and blkverify. Both should pass on BDRV_O_NO_IO to their children. There is no reason to clear it in bdrv_inherited_fmt_options(). Signed-off-by: Max Reitz --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 6c50ad661e..58252007af 100644 --- a/block.c +++ b/block.c @@ -1034,7 +1034,7 @@ static void bdrv_inherited_fmt_options(int *child_fla= gs, QDict *child_options, child_file.inherit_options(child_flags, child_options, parent_flags, parent_options); =20 - *child_flags &=3D ~(BDRV_O_PROTOCOL | BDRV_O_NO_IO); + *child_flags &=3D ~BDRV_O_PROTOCOL; } =20 const BdrvChildClass child_format =3D { --=20 2.23.0