[v4] hw: Remove dynamic field width from trace events

[PATCH v4 0/2] hw: Remove dynamic field width from trace events

Philippe Mathieu-Daudé posted 2 patches 4 years, 5 months ago

Diff against v2 v3
Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191118222746.31467-1-philmd@redhat.com

Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Max Reitz <mreitz@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>

hw/block/pflash_cfi01.c |  8 ++++----
hw/block/pflash_cfi02.c |  8 ++++----
hw/mips/gt64xxx_pci.c   | 16 ++++++++--------
hw/block/trace-events   |  8 ++++----
hw/mips/trace-events    |  4 ++--
5 files changed, 22 insertions(+), 22 deletions(-)

Expand all Fold all

[PATCH v4 0/2] hw: Remove dynamic field width from trace events

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

This series fixes LP#1844817 [2].

(Eric noted in [1] the dtrace via stap backend can not support
the dynamic '*' width format.)

If they are trivial/block/tracing pull in preparation, this
series will be happy to be taken, else it will go via mips-next.

Thanks,

Phil.

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04720.html
[2] https://bugs.launchpad.net/qemu/+bug/1844817

Philippe Mathieu-Daudé (2):
  hw/block/pflash: Remove dynamic field width from trace events
  hw/mips/gt64xxx: Remove dynamic field width from trace events

 hw/block/pflash_cfi01.c |  8 ++++----
 hw/block/pflash_cfi02.c |  8 ++++----
 hw/mips/gt64xxx_pci.c   | 16 ++++++++--------
 hw/block/trace-events   |  8 ++++----
 hw/mips/trace-events    |  4 ++--
 5 files changed, 22 insertions(+), 22 deletions(-)

-- 
2.21.0

Re: [PATCH-for-4.2 v4 0/2] hw: Remove dynamic field width from trace events

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

This is material for 4.2-rc2.

On 11/18/19 11:27 PM, Philippe Mathieu-Daudé wrote:
> This series fixes LP#1844817 [2].
> 
> (Eric noted in [1] the dtrace via stap backend can not support
> the dynamic '*' width format.)
> 
> If they are trivial/block/tracing pull in preparation, this
> series will be happy to be taken, else it will go via mips-next.
> 
> Thanks,
> 
> Phil.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04720.html
> [2] https://bugs.launchpad.net/qemu/+bug/1844817

Re: [PATCH v4 0/2] hw: Remove dynamic field width from trace events

Posted by Stefan Hajnoczi 4 years, 5 months ago

On Mon, Nov 18, 2019 at 11:27:44PM +0100, Philippe Mathieu-Daudé wrote:
> This series fixes LP#1844817 [2].
> 
> (Eric noted in [1] the dtrace via stap backend can not support
> the dynamic '*' width format.)
> 
> If they are trivial/block/tracing pull in preparation, this
> series will be happy to be taken, else it will go via mips-next.
> 
> Thanks,
> 
> Phil.
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04720.html
> [2] https://bugs.launchpad.net/qemu/+bug/1844817
> 
> Philippe Mathieu-Daudé (2):
>   hw/block/pflash: Remove dynamic field width from trace events
>   hw/mips/gt64xxx: Remove dynamic field width from trace events
> 
>  hw/block/pflash_cfi01.c |  8 ++++----
>  hw/block/pflash_cfi02.c |  8 ++++----
>  hw/mips/gt64xxx_pci.c   | 16 ++++++++--------
>  hw/block/trace-events   |  8 ++++----
>  hw/mips/trace-events    |  4 ++--
>  5 files changed, 22 insertions(+), 22 deletions(-)
> 
> -- 
> 2.21.0
> 

Will send a pull request today.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

Re: [PATCH v4 0/2] hw: Remove dynamic field width from trace events

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

On 11/19/19 5:21 PM, Stefan Hajnoczi wrote:
> On Mon, Nov 18, 2019 at 11:27:44PM +0100, Philippe Mathieu-Daudé wrote:
>> This series fixes LP#1844817 [2].
>>
>> (Eric noted in [1] the dtrace via stap backend can not support
>> the dynamic '*' width format.)
>>
>> If they are trivial/block/tracing pull in preparation, this
>> series will be happy to be taken, else it will go via mips-next.
>>
>> Thanks,
>>
>> Phil.
>>
>> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04720.html
>> [2] https://bugs.launchpad.net/qemu/+bug/1844817
>>
>> Philippe Mathieu-Daudé (2):
>>    hw/block/pflash: Remove dynamic field width from trace events
>>    hw/mips/gt64xxx: Remove dynamic field width from trace events
>>
>>   hw/block/pflash_cfi01.c |  8 ++++----
>>   hw/block/pflash_cfi02.c |  8 ++++----
>>   hw/mips/gt64xxx_pci.c   | 16 ++++++++--------
>>   hw/block/trace-events   |  8 ++++----
>>   hw/mips/trace-events    |  4 ++--
>>   5 files changed, 22 insertions(+), 22 deletions(-)
>>
>> -- 
>> 2.21.0
>>
> 
> Will send a pull request today.

Oh thanks Stefan, but it was getting late for the RC tag so I sent a 
pull for these patches via mips-next a pair of hours ago:
https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg02894.html