[v3] hw: Remove dynamic field width from trace events

[PATCH-for-4.2 v3 0/3] hw: Remove dynamic field width from trace events

Philippe Mathieu-Daudé posted 3 patches 4 years, 5 months ago

Diff against v2 v4
Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191118210458.11959-1-philmd@redhat.com

Maintainers: "Philippe Mathieu-Daudé" <philmd@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>

There is a newer version of this series

docs/devel/tracing.txt        |  3 ++-
hw/block/pflash_cfi01.c       |  8 ++++----
hw/block/pflash_cfi02.c       |  8 ++++----
hw/mips/gt64xxx_pci.c         | 16 ++++++++--------
hw/block/trace-events         |  8 ++++----
hw/mips/trace-events          |  4 ++--
scripts/tracetool/__init__.py |  3 +++
7 files changed, 27 insertions(+), 23 deletions(-)

Expand all Fold all

[PATCH-for-4.2 v3 0/3] hw: Remove dynamic field width from trace events

Posted by Philippe Mathieu-Daudé 4 years, 5 months ago

Eric noted in [1] the dtrace via stap backend can not support
the dynamic '*' width format.
I'd really like to use dynamic width in trace event because the
read/write accesses are easier to read but it is not a priority.
Since next release is close, time to fix LP#1844817 [2].

Since v2:
- addressed Eric review comments from v2
- improved the documentation

Since v1:
- Do not update the qemu_log_mask() calls in hw/mips/gt64xxx_pci.c

[1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg04720.html
[2] https://bugs.launchpad.net/qemu/+bug/1844817

Philippe Mathieu-Daudé (3):
  hw/block/pflash: Remove dynamic field width from trace events
  hw/mips/gt64xxx: Remove dynamic field width from trace events
  trace: Forbid dynamic field width in event format

 docs/devel/tracing.txt        |  3 ++-
 hw/block/pflash_cfi01.c       |  8 ++++----
 hw/block/pflash_cfi02.c       |  8 ++++----
 hw/mips/gt64xxx_pci.c         | 16 ++++++++--------
 hw/block/trace-events         |  8 ++++----
 hw/mips/trace-events          |  4 ++--
 scripts/tracetool/__init__.py |  3 +++
 7 files changed, 27 insertions(+), 23 deletions(-)

-- 
2.21.0

Re: [PATCH-for-4.2 v3 0/3] hw: Remove dynamic field width from trace events

Posted by Richard Henderson 4 years, 5 months ago

On 11/18/19 10:04 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
>   hw/block/pflash: Remove dynamic field width from trace events
>   hw/mips/gt64xxx: Remove dynamic field width from trace events
>   trace: Forbid dynamic field width in event format

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~