s390x/cpumodel: Add missing visit_free

[PATCH] s390x/cpumodel: Add missing visit_free

Andrew Jones posted 1 patch 4 years, 6 months ago

Download mbox

Test asan passed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20191016145434.7007-1-drjones@redhat.com

Maintainers: Halil Pasic <pasic@linux.ibm.com>, Richard Henderson <rth@twiddle.net>, David Hildenbrand <david@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cohuck@redhat.com>

target/s390x/cpu_models.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] s390x/cpumodel: Add missing visit_free

Posted by Andrew Jones 4 years, 6 months ago

Beata Michalska noticed this missing visit_free() while reviewing
arm's implementation of qmp_query_cpu_model_expansion(), which is
modeled off this s390x implementation.

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 target/s390x/cpu_models.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
index 009afc38b92d..7e92fb2e156d 100644
--- a/target/s390x/cpu_models.c
+++ b/target/s390x/cpu_models.c
@@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
         visitor = qobject_input_visitor_new(info->props);
         visit_start_struct(visitor, NULL, NULL, 0, errp);
         if (*errp) {
+            visit_free(visitor);
             object_unref(obj);
             return;
         }
-- 
2.21.0

Re: [PATCH] s390x/cpumodel: Add missing visit_free

Posted by Cornelia Huck 4 years, 6 months ago

On Wed, 16 Oct 2019 16:54:34 +0200
Andrew Jones <drjones@redhat.com> wrote:

> Beata Michalska noticed this missing visit_free() while reviewing
> arm's implementation of qmp_query_cpu_model_expansion(), which is
> modeled off this s390x implementation.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  target/s390x/cpu_models.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 009afc38b92d..7e92fb2e156d 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
>          visitor = qobject_input_visitor_new(info->props);
>          visit_start_struct(visitor, NULL, NULL, 0, errp);
>          if (*errp) {
> +            visit_free(visitor);
>              object_unref(obj);
>              return;
>          }

Thanks, applied.

Re: [PATCH] s390x/cpumodel: Add missing visit_free

Posted by David Hildenbrand 4 years, 6 months ago

On 16.10.19 16:54, Andrew Jones wrote:
> Beata Michalska noticed this missing visit_free() while reviewing
> arm's implementation of qmp_query_cpu_model_expansion(), which is
> modeled off this s390x implementation.

Nice to see ARM support getting added.

> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>   target/s390x/cpu_models.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index 009afc38b92d..7e92fb2e156d 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -515,6 +515,7 @@ static void cpu_model_from_info(S390CPUModel *model, const CpuModelInfo *info,
>           visitor = qobject_input_visitor_new(info->props);
>           visit_start_struct(visitor, NULL, NULL, 0, errp);
>           if (*errp) {
> +            visit_free(visitor);
>               object_unref(obj);
>               return;
>           }
> 

Right, thanks

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 

Thanks,

David / dhildenb